diff mbox

[dpdk-dev] crypto/scheduler: fix slave name parsing

Message ID 20170707051730.1878-1-roy.fan.zhang@intel.com (mailing list archive)
State Accepted, archived
Delegated to: Pablo de Lara Guarch
Headers

Checks

Context Check Description
ci/checkpatch success coding style OK
ci/Intel-compilation fail Compilation issues

Commit Message

Fan Zhang July 7, 2017, 5:17 a.m. UTC 
  Fixes: 503e9c5afb38 ("crypto/scheduler: register as vdev driver")

This patch fixes the incorrect index checking in parse_slave
function.

Signed-off-by: Fan Zhang <roy.fan.zhang@intel.com>
---
 drivers/crypto/scheduler/scheduler_pmd.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

De Lara Guarch, Pablo July 11, 2017, 2:22 p.m. UTC | #1 
> -----Original Message-----
> From: Zhang, Roy Fan
> Sent: Friday, July 7, 2017 6:18 AM
> To: dev@dpdk.org
> Cc: De Lara Guarch, Pablo <pablo.de.lara.guarch@intel.com>
> Subject: [PATCH] crypto/scheduler: fix slave name parsing
> 
> Fixes: 503e9c5afb38 ("crypto/scheduler: register as vdev driver")
> 
> This patch fixes the incorrect index checking in parse_slave function.
> 
> Signed-off-by: Fan Zhang <roy.fan.zhang@intel.com>
> ---
>  drivers/crypto/scheduler/scheduler_pmd.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/crypto/scheduler/scheduler_pmd.c
> b/drivers/crypto/scheduler/scheduler_pmd.c
> index 0f57fbe..400fc4f 100644
> --- a/drivers/crypto/scheduler/scheduler_pmd.c
> +++ b/drivers/crypto/scheduler/scheduler_pmd.c
> @@ -325,7 +325,7 @@ parse_slave_arg(const char *key __rte_unused,  {
>  	struct scheduler_init_params *param = extra_args;
> 
> -	if (param->nb_slaves >=
> RTE_CRYPTODEV_SCHEDULER_MAX_NB_SLAVES - 1) {
> +	if (param->nb_slaves >=
> RTE_CRYPTODEV_SCHEDULER_MAX_NB_SLAVES) {
>  		CS_LOG_ERR("Too many slaves.\n");
>  		return -ENOMEM;
>  	}
> --
> 2.9.4

This should be backported to the stable branch, so I will add CC: stable@dpdk.org,
before applying this patch.

Apart from that:

Acked-by: Pablo de Lara <pablo.de.lara.guarch@intel.com>
De Lara Guarch, Pablo July 11, 2017, 2:24 p.m. UTC | #2 
> -----Original Message-----
> From: De Lara Guarch, Pablo
> Sent: Tuesday, July 11, 2017 3:23 PM
> To: Zhang, Roy Fan <roy.fan.zhang@intel.com>; dev@dpdk.org
> Cc: stable@dpdk.org
> Subject: RE: [PATCH] crypto/scheduler: fix slave name parsing
> 
> 
> 
> > -----Original Message-----
> > From: Zhang, Roy Fan
> > Sent: Friday, July 7, 2017 6:18 AM
> > To: dev@dpdk.org
> > Cc: De Lara Guarch, Pablo <pablo.de.lara.guarch@intel.com>
> > Subject: [PATCH] crypto/scheduler: fix slave name parsing
> >
> > Fixes: 503e9c5afb38 ("crypto/scheduler: register as vdev driver")
> >
> > This patch fixes the incorrect index checking in parse_slave function.
> >
> > Signed-off-by: Fan Zhang <roy.fan.zhang@intel.com>
...
> This should be backported to the stable branch, so I will add CC:
> stable@dpdk.org, before applying this patch.
> 
> Apart from that:
> 
> Acked-by: Pablo de Lara <pablo.de.lara.guarch@intel.com>

Applied to dpdk-next-crypto.
Thanks,

Pablo
diff mbox

Patch

diff --git a/drivers/crypto/scheduler/scheduler_pmd.c b/drivers/crypto/scheduler/scheduler_pmd.c
index 0f57fbe..400fc4f 100644
--- a/drivers/crypto/scheduler/scheduler_pmd.c
+++ b/drivers/crypto/scheduler/scheduler_pmd.c
@@ -325,7 +325,7 @@  parse_slave_arg(const char *key __rte_unused,
 {
 	struct scheduler_init_params *param = extra_args;
 
-	if (param->nb_slaves >= RTE_CRYPTODEV_SCHEDULER_MAX_NB_SLAVES - 1) {
+	if (param->nb_slaves >= RTE_CRYPTODEV_SCHEDULER_MAX_NB_SLAVES) {
 		CS_LOG_ERR("Too many slaves.\n");
 		return -ENOMEM;
 	}