diff mbox

[dpdk-dev] cryptodev: fix icc build

Message ID 20170710025923.66395-1-pablo.de.lara.guarch@intel.com (mailing list archive)
State Accepted, archived
Headers

Checks

Context Check Description
ci/Intel-compilation success Compilation OK
ci/checkpatch success coding style OK

Commit Message

De Lara Guarch, Pablo July 10, 2017, 2:59 a.m. UTC 
  Removed unnecessary macro RTE_STD_C11, which is used
for unnamed structs.
Since there is no longer an unnamed structure in
rte_cryptodev_sym_session, this is not needed and
it is actually breaking compilation on icc:

lib/librte_cryptodev/rte_cryptodev.h(887): error: expected a declaration
  	__extension__ void *sess_private_data[0];
  	^
Fixes: 7c110ce7aa4e ("cryptodev: remove mempool from session")

Signed-off-by: Pablo de Lara <pablo.de.lara.guarch@intel.com>
---
 lib/librte_cryptodev/rte_cryptodev.h | 1 -
 1 file changed, 1 deletion(-)

Comments

Doherty, Declan July 12, 2017, 10:09 a.m. UTC | #1 
On 10/07/17 03:59, Pablo de Lara wrote:
> Removed unnecessary macro RTE_STD_C11, which is used
> for unnamed structs.
> Since there is no longer an unnamed structure in
> rte_cryptodev_sym_session, this is not needed and
> it is actually breaking compilation on icc:
> 
> lib/librte_cryptodev/rte_cryptodev.h(887): error: expected a declaration
>    	__extension__ void *sess_private_data[0];
>    	^
> Fixes: 7c110ce7aa4e ("cryptodev: remove mempool from session")
> 
> Signed-off-by: Pablo de Lara <pablo.de.lara.guarch@intel.com>
> ---
...
> 

Acked-by: Declan Doherty <declan.doherty@intel.com>
Thomas Monjalon July 12, 2017, 12:42 p.m. UTC | #2 
12/07/2017 12:09, Declan Doherty:
> On 10/07/17 03:59, Pablo de Lara wrote:
> > Removed unnecessary macro RTE_STD_C11, which is used
> > for unnamed structs.
> > Since there is no longer an unnamed structure in
> > rte_cryptodev_sym_session, this is not needed and
> > it is actually breaking compilation on icc:
> > 
> > lib/librte_cryptodev/rte_cryptodev.h(887): error: expected a declaration
> >    	__extension__ void *sess_private_data[0];
> >    	^
> > Fixes: 7c110ce7aa4e ("cryptodev: remove mempool from session")
> > 
> > Signed-off-by: Pablo de Lara <pablo.de.lara.guarch@intel.com>
> 
> Acked-by: Declan Doherty <declan.doherty@intel.com>

Applied, thanks
diff mbox

Patch

diff --git a/lib/librte_cryptodev/rte_cryptodev.h b/lib/librte_cryptodev/rte_cryptodev.h
index ca7cbdd..1d975e5 100644
--- a/lib/librte_cryptodev/rte_cryptodev.h
+++ b/lib/librte_cryptodev/rte_cryptodev.h
@@ -883,7 +883,6 @@  rte_cryptodev_enqueue_burst(uint8_t dev_id, uint16_t qp_id,
 
 /** Cryptodev symmetric crypto session */
 struct rte_cryptodev_sym_session {
-	RTE_STD_C11
 	__extension__ void *sess_private_data[0];
 	/**< Private session material */
 };