diff mbox

[dpdk-dev] net/i40e: remove an unnecessary goto

Message ID 1500272816-129323-1-git-send-email-tiwei.bie@intel.com (mailing list archive)
State Accepted, archived
Delegated to: Ferruh Yigit
Headers

Checks

Context Check Description
ci/checkpatch success coding style OK
ci/Intel-compilation success Compilation OK

Commit Message

Tiwei Bie July 17, 2017, 6:26 a.m. UTC 
  Signed-off-by: Tiwei Bie <tiwei.bie@intel.com>
---
 drivers/net/i40e/i40e_tm.c | 2 --
 1 file changed, 2 deletions(-)

Comments

Xing, Beilei July 18, 2017, 3:18 a.m. UTC | #1 
> -----Original Message-----
> From: Bie, Tiwei
> Sent: Monday, July 17, 2017 2:27 PM
> To: Wu, Jingjing <jingjing.wu@intel.com>; Xing, Beilei
> <beilei.xing@intel.com>; dev@dpdk.org
> Cc: Bie, Tiwei <tiwei.bie@intel.com>
> Subject: [PATCH] net/i40e: remove an unnecessary goto
> 
> Signed-off-by: Tiwei Bie <tiwei.bie@intel.com>
> ---
>  drivers/net/i40e/i40e_tm.c | 2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/drivers/net/i40e/i40e_tm.c b/drivers/net/i40e/i40e_tm.c index
> 56013b1..d90313a 100644
> --- a/drivers/net/i40e/i40e_tm.c
> +++ b/drivers/net/i40e/i40e_tm.c
> @@ -962,8 +962,6 @@ i40e_hierarchy_commit(struct rte_eth_dev *dev,
>  		goto fail_clear;
>  	}
> 
> -	goto done;
> -
>  done:
>  	pf->tm_conf.committed = true;
>  	return 0;
> --
> 2.7.4

Acked-by: Beilei Xing <beilei.xing@intel.com>
Ferruh Yigit July 18, 2017, 11:03 a.m. UTC | #2 
On 7/18/2017 4:18 AM, Xing, Beilei wrote:
>> -----Original Message-----
>> From: Bie, Tiwei
>> Sent: Monday, July 17, 2017 2:27 PM
>> To: Wu, Jingjing <jingjing.wu@intel.com>; Xing, Beilei
>> <beilei.xing@intel.com>; dev@dpdk.org
>> Cc: Bie, Tiwei <tiwei.bie@intel.com>
>> Subject: [PATCH] net/i40e: remove an unnecessary goto
>>
>> Signed-off-by: Tiwei Bie <tiwei.bie@intel.com>

> Acked-by: Beilei Xing <beilei.xing@intel.com>

Applied to dpdk-next-net/master, thanks.
diff mbox

Patch

diff --git a/drivers/net/i40e/i40e_tm.c b/drivers/net/i40e/i40e_tm.c
index 56013b1..d90313a 100644
--- a/drivers/net/i40e/i40e_tm.c
+++ b/drivers/net/i40e/i40e_tm.c
@@ -962,8 +962,6 @@  i40e_hierarchy_commit(struct rte_eth_dev *dev,
 		goto fail_clear;
 	}
 
-	goto done;
-
 done:
 	pf->tm_conf.committed = true;
 	return 0;