diff mbox

[dpdk-dev] examples/load_balancer: enable the build for lesser lcores

Message ID 1500280902-7333-1-git-send-email-hemant.agrawal@nxp.com (mailing list archive)
State Superseded, archived
Headers

Checks

Context Check Description
ci/checkpatch success coding style OK
ci/Intel-compilation success Compilation OK

Commit Message

Hemant Agrawal July 17, 2017, 8:41 a.m. UTC 
  load_balancer app can also work for lower number of cores.
Limit the cores Worker and IO cores to 16 as defined in original
App. Otherwise use the actual number of lcores as MAX.

Signed-off-by: Hemant Agrawal <hemant.agrawal@nxp.com>
---
 examples/load_balancer/main.h | 10 ++++++----
 1 file changed, 6 insertions(+), 4 deletions(-)

Comments

Thomas Monjalon July 19, 2017, 5:21 a.m. UTC | #1 
17/07/2017 11:41, Hemant Agrawal:
> --- a/examples/load_balancer/main.h
> +++ b/examples/load_balancer/main.h
>  #ifndef APP_MAX_IO_LCORES
> +#if (APP_MAX_LCORES > 16)
>  #define APP_MAX_IO_LCORES 16
> +#else
> +#define APP_MAX_IO_LCORES APP_MAX_LCORES
>  #endif
> -#if (APP_MAX_IO_LCORES > APP_MAX_LCORES)
> -#error "APP_MAX_IO_LCORES is too big"
>  #endif
[...]
>  #ifndef APP_MAX_WORKER_LCORES
> +#if (APP_MAX_LCORES > 16)
>  #define APP_MAX_WORKER_LCORES 16
> +#else
> +#define APP_MAX_WORKER_LCORES APP_MAX_LCORES
>  #endif
> -#if (APP_MAX_WORKER_LCORES > APP_MAX_LCORES)
> -#error "APP_MAX_WORKER_LCORES is too big"
>  #endif

Why removing the checks > APP_MAX_LCORES ?
Hemant Agrawal July 19, 2017, 7:57 a.m. UTC | #2 
On 7/19/2017 10:51 AM, Thomas Monjalon wrote:
> 17/07/2017 11:41, Hemant Agrawal:
>> --- a/examples/load_balancer/main.h
>> +++ b/examples/load_balancer/main.h
>>  #ifndef APP_MAX_IO_LCORES
>> +#if (APP_MAX_LCORES > 16)
>>  #define APP_MAX_IO_LCORES 16
>> +#else
>> +#define APP_MAX_IO_LCORES APP_MAX_LCORES
>>  #endif
>> -#if (APP_MAX_IO_LCORES > APP_MAX_LCORES)
>> -#error "APP_MAX_IO_LCORES is too big"
>>  #endif
> [...]
>>  #ifndef APP_MAX_WORKER_LCORES
>> +#if (APP_MAX_LCORES > 16)
>>  #define APP_MAX_WORKER_LCORES 16
>> +#else
>> +#define APP_MAX_WORKER_LCORES APP_MAX_LCORES
>>  #endif
>> -#if (APP_MAX_WORKER_LCORES > APP_MAX_LCORES)
>> -#error "APP_MAX_WORKER_LCORES is too big"
>>  #endif
>
> Why removing the checks > APP_MAX_LCORES ?
>
It is not going to be needed unless someone defines it.
I will send v2 with reverting them back.
diff mbox

Patch

diff --git a/examples/load_balancer/main.h b/examples/load_balancer/main.h
index d98468a..8b8963d 100644
--- a/examples/load_balancer/main.h
+++ b/examples/load_balancer/main.h
@@ -56,10 +56,11 @@ 
 #endif
 
 #ifndef APP_MAX_IO_LCORES
+#if (APP_MAX_LCORES > 16)
 #define APP_MAX_IO_LCORES 16
+#else
+#define APP_MAX_IO_LCORES APP_MAX_LCORES
 #endif
-#if (APP_MAX_IO_LCORES > APP_MAX_LCORES)
-#error "APP_MAX_IO_LCORES is too big"
 #endif
 
 #ifndef APP_MAX_NIC_RX_QUEUES_PER_IO_LCORE
@@ -74,10 +75,11 @@ 
 #endif
 
 #ifndef APP_MAX_WORKER_LCORES
+#if (APP_MAX_LCORES > 16)
 #define APP_MAX_WORKER_LCORES 16
+#else
+#define APP_MAX_WORKER_LCORES APP_MAX_LCORES
 #endif
-#if (APP_MAX_WORKER_LCORES > APP_MAX_LCORES)
-#error "APP_MAX_WORKER_LCORES is too big"
 #endif