diff mbox

[dpdk-dev] crypto/dpaa2_sec: add check for gcc toolchain

Message ID 20170726112737.18239-1-akhil.goyal@nxp.com (mailing list archive)
State Accepted, archived
Delegated to: Pablo de Lara Guarch
Headers

Checks

Context Check Description
ci/checkpatch success coding style OK
ci/Intel-compilation success Compilation OK

Commit Message

Akhil Goyal July 26, 2017, 11:27 a.m. UTC 
  Signed-off-by: Akhil Goyal <akhil.goyal@nxp.com>
---
 drivers/crypto/dpaa2_sec/Makefile | 2 ++
 1 file changed, 2 insertions(+)

Comments

De Lara Guarch, Pablo July 27, 2017, 8:52 a.m. UTC | #1 
HI Akhil,

> -----Original Message-----
> From: Akhil Goyal [mailto:akhil.goyal@nxp.com]
> Sent: Wednesday, July 26, 2017 12:28 PM
> To: dev@dpdk.org
> Cc: De Lara Guarch, Pablo <pablo.de.lara.guarch@intel.com>;
> hemant.agrawal@nxp.com; Akhil Goyal <akhil.goyal@nxp.com>
> Subject: [PATCH] crypto/dpaa2_sec: add check for gcc toolchain
> 
> Signed-off-by: Akhil Goyal <akhil.goyal@nxp.com>

I think you need to include a fixes line here, and CC stable, as this is a fix.

Thanks,
Pablo
Akhil Goyal July 27, 2017, 11:42 a.m. UTC | #2 
On 7/27/2017 2:22 PM, De Lara Guarch, Pablo wrote:
> HI Akhil,
> 
>> -----Original Message-----
>> From: Akhil Goyal [mailto:akhil.goyal@nxp.com]
>> Sent: Wednesday, July 26, 2017 12:28 PM
>> To: dev@dpdk.org
>> Cc: De Lara Guarch, Pablo <pablo.de.lara.guarch@intel.com>;
>> hemant.agrawal@nxp.com; Akhil Goyal <akhil.goyal@nxp.com>
>> Subject: [PATCH] crypto/dpaa2_sec: add check for gcc toolchain
>>
>> Signed-off-by: Akhil Goyal <akhil.goyal@nxp.com>
> 
> I think you need to include a fixes line here, and CC stable, as this is a fix.
> 

This is not valid for 17.05 stable release. This is recently added in 
below commit. Should I resend this patch with commit message updated?

  ed5ed6b344f2 ("crypto/dpaa2_sec: remove GCC 7.1 compilation error")

Thanks,
Akhil
De Lara Guarch, Pablo July 27, 2017, 12:48 p.m. UTC | #3 
Hi,

> -----Original Message-----

> From: Akhil Goyal [mailto:akhil.goyal@nxp.com]

> Sent: Thursday, July 27, 2017 12:43 PM

> To: De Lara Guarch, Pablo <pablo.de.lara.guarch@intel.com>;

> dev@dpdk.org

> Cc: hemant.agrawal@nxp.com

> Subject: Re: [PATCH] crypto/dpaa2_sec: add check for gcc toolchain

> 

> On 7/27/2017 2:22 PM, De Lara Guarch, Pablo wrote:

> > HI Akhil,

> >

> >> -----Original Message-----

> >> From: Akhil Goyal [mailto:akhil.goyal@nxp.com]

> >> Sent: Wednesday, July 26, 2017 12:28 PM

> >> To: dev@dpdk.org

> >> Cc: De Lara Guarch, Pablo <pablo.de.lara.guarch@intel.com>;

> >> hemant.agrawal@nxp.com; Akhil Goyal <akhil.goyal@nxp.com>

> >> Subject: [PATCH] crypto/dpaa2_sec: add check for gcc toolchain

> >>

> >> Signed-off-by: Akhil Goyal <akhil.goyal@nxp.com>

> >

> > I think you need to include a fixes line here, and CC stable, as this is a fix.

> >

> 

> This is not valid for 17.05 stable release. This is recently added in below

> commit. Should I resend this patch with commit message updated?

> 

>   ed5ed6b344f2 ("crypto/dpaa2_sec: remove GCC 7.1 compilation error")


Oh, you are right. Well, I can add the line for you.

Thanks,
Pablo

> 

> Thanks,

> Akhil
De Lara Guarch, Pablo July 27, 2017, 2:33 p.m. UTC | #4 
> -----Original Message-----

> From: Akhil Goyal [mailto:akhil.goyal@nxp.com]

> Sent: Thursday, July 27, 2017 12:43 PM

> To: De Lara Guarch, Pablo <pablo.de.lara.guarch@intel.com>;

> dev@dpdk.org

> Cc: hemant.agrawal@nxp.com

> Subject: Re: [PATCH] crypto/dpaa2_sec: add check for gcc toolchain

> 

> On 7/27/2017 2:22 PM, De Lara Guarch, Pablo wrote:

> > HI Akhil,

> >

> >> -----Original Message-----

> >> From: Akhil Goyal [mailto:akhil.goyal@nxp.com]

> >> Sent: Wednesday, July 26, 2017 12:28 PM

> >> To: dev@dpdk.org

> >> Cc: De Lara Guarch, Pablo <pablo.de.lara.guarch@intel.com>;

> >> hemant.agrawal@nxp.com; Akhil Goyal <akhil.goyal@nxp.com>

> >> Subject: [PATCH] crypto/dpaa2_sec: add check for gcc toolchain

> >>

> >> Signed-off-by: Akhil Goyal <akhil.goyal@nxp.com>

> >

> > I think you need to include a fixes line here, and CC stable, as this is a fix.

> >

> 

> This is not valid for 17.05 stable release. This is recently added in below

> commit. Should I resend this patch with commit message updated?

> 

>   ed5ed6b344f2 ("crypto/dpaa2_sec: remove GCC 7.1 compilation error")

> 

> Thanks,

> Akhil


Added fixes line [Fixes: 6a95466d78de ("crypto/dpaa2_sec: fix build with gcc 7.1")].
Remember to use the commit ID of the patch that was actually merged.

Applied to dpdk-next-crypto.
Thanks,

Pablo
diff mbox

Patch

diff --git a/drivers/crypto/dpaa2_sec/Makefile b/drivers/crypto/dpaa2_sec/Makefile
index c2a02ed..ae15c99 100644
--- a/drivers/crypto/dpaa2_sec/Makefile
+++ b/drivers/crypto/dpaa2_sec/Makefile
@@ -46,9 +46,11 @@  CFLAGS += $(WERROR_FLAGS)
 endif
 CFLAGS += -D _GNU_SOURCE
 
+ifeq ($(CONFIG_RTE_TOOLCHAIN_GCC),y)
 ifeq ($(shell test $(GCC_VERSION) -gt 70 && echo 1), 1)
 CFLAGS += -Wno-implicit-fallthrough
 endif
+endif
 
 CFLAGS += -I$(RTE_SDK)/drivers/crypto/dpaa2_sec/
 CFLAGS += -I$(RTE_SDK)/drivers/crypto/dpaa2_sec/mc