[dpdk-dev] net/i40e: fix return code not checked
Checks
Commit Message
Calling i40e_vsi_delete_mac without checking return
value (as is done elsewhere 5 out of 6 times)
Coverity issue: 140735
Fixes: 43c89d5a4fde ("net/i40e: set VF MAC from PF")
Signed-off-by: Daniel Mrzyglod <danielx.t.mrzyglod@intel.com>
---
drivers/net/i40e/rte_pmd_i40e.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
Comments
On 8/10/2017 10:12 AM, Daniel Mrzyglod wrote:
> Calling i40e_vsi_delete_mac without checking return
> value (as is done elsewhere 5 out of 6 times)
>
> Coverity issue: 140735
> Fixes: 43c89d5a4fde ("net/i40e: set VF MAC from PF")
>
> Signed-off-by: Daniel Mrzyglod <danielx.t.mrzyglod@intel.com>
Reviewed-by: Ferruh Yigit <ferruh.yigit@intel.com>
On 8/18/2017 3:23 PM, Ferruh Yigit wrote:
> On 8/10/2017 10:12 AM, Daniel Mrzyglod wrote:
>> Calling i40e_vsi_delete_mac without checking return
>> value (as is done elsewhere 5 out of 6 times)
>>
>> Coverity issue: 140735
>> Fixes: 43c89d5a4fde ("net/i40e: set VF MAC from PF")
>>
>> Signed-off-by: Daniel Mrzyglod <danielx.t.mrzyglod@intel.com>
>
> Reviewed-by: Ferruh Yigit <ferruh.yigit@intel.com>
Applied to dpdk-next-net/master, thanks.
@@ -591,7 +591,9 @@ rte_pmd_i40e_set_vf_mac_addr(uint8_t port, uint16_t vf_id,
/* Remove all existing mac */
TAILQ_FOREACH_SAFE(f, &vsi->mac_list, next, temp)
- i40e_vsi_delete_mac(vsi, &f->mac_info.mac_addr);
+ if (i40e_vsi_delete_mac(vsi, &f->mac_info.mac_addr)
+ != I40E_SUCCESS)
+ PMD_DRV_LOG(WARNING, "Delete MAC failed");
return 0;
}