[dpdk-dev,12/12] examples/helloworld: do not exit automatically

  Signed-off-by: Jianfeng Tan <jianfeng.tan@intel.com>
---
 examples/helloworld/main.c | 3 +++
 1 file changed, 3 insertions(+)
  

> -----Original Message-----
> From: Tan, Jianfeng
> Sent: Friday, August 25, 2017 10:41 AM
> To: dev@dpdk.org
> Cc: Richardson, Bruce <bruce.richardson@intel.com>; Ananyev, Konstantin
> <konstantin.ananyev@intel.com>; De Lara Guarch, Pablo
> <pablo.de.lara.guarch@intel.com>; thomas@monjalon.net;
> yliu@fridaylinux.org; maxime.coquelin@redhat.com;
> mtetsuyah@gmail.com; Yigit, Ferruh <ferruh.yigit@intel.com>; Tan,
> Jianfeng <jianfeng.tan@intel.com>
> Subject: [PATCH 12/12] examples/helloworld: do not exit automatically
> 
> Signed-off-by: Jianfeng Tan <jianfeng.tan@intel.com>
> ---
>  examples/helloworld/main.c | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/examples/helloworld/main.c b/examples/helloworld/main.c
> index 8b7a2de..35b70da 100644
> --- a/examples/helloworld/main.c
> +++ b/examples/helloworld/main.c
> @@ -36,6 +36,7 @@
>  #include <stdint.h>
>  #include <errno.h>
>  #include <sys/queue.h>
> +#include <unistd.h>
> 
>  #include <rte_memory.h>
>  #include <rte_memzone.h>
> @@ -72,6 +73,8 @@ main(int argc, char **argv)
>  	/* call it on master lcore too */
>  	lcore_hello(NULL);
> 
> +	while (1) sleep(5);
> +
>  	rte_eal_mp_wait_lcore();
>  	return 0;
>  }
> --
> 2.7.4

I think this patch should not be in this patchset, as it looks that
it does not have any relation with the other patches.
Am I missing something?

Pablo
  

Hi Pablo,

> -----Original Message-----
> From: De Lara Guarch, Pablo
> Sent: Monday, September 18, 2017 7:44 PM
> To: Tan, Jianfeng; dev@dpdk.org
> Cc: Richardson, Bruce; Ananyev, Konstantin; thomas@monjalon.net;
> yliu@fridaylinux.org; maxime.coquelin@redhat.com; mtetsuyah@gmail.com;
> Yigit, Ferruh
> Subject: RE: [PATCH 12/12] examples/helloworld: do not exit automatically
> 
> 
...
> >  #include <rte_memory.h>
> >  #include <rte_memzone.h>
> > @@ -72,6 +73,8 @@ main(int argc, char **argv)
> >  	/* call it on master lcore too */
> >  	lcore_hello(NULL);
> >
> > +	while (1) sleep(5);
> > +
> >  	rte_eal_mp_wait_lcore();
> >  	return 0;
> >  }
> > --
> > 2.7.4
> 
> I think this patch should not be in this patchset, as it looks that
> it does not have any relation with the other patches.
> Am I missing something?

We want to use this example as a *clean* primary process; but without this example, we can still use those examples in examples/multi_process/.

So will drop this patch.

Thanks,
Jianfeng

> 
> Pablo