diff mbox

[dpdk-dev] net/failsafe: fix adding MAC error report miss

Message ID 1504452405-63569-1-git-send-email-matan@mellanox.com (mailing list archive)
State Accepted, archived
Delegated to: Ferruh Yigit
Headers

Checks

Context Check Description
ci/checkpatch success coding style OK
ci/Intel-compilation success Compilation OK

Commit Message

Matan Azrad Sept. 3, 2017, 3:26 p.m. UTC 
  The corrupted code don't reply error in case of MAC
address adding failure while failsafe PMD was trying
to apply configuration to the sub device.

Hence, the application may get unwanted packets.

The fix adds error report for this case.

Fixes: ebea83f899d8 ("net/failsafe: add plug-in support")
Cc: stable@dpdk.org

Signed-off-by: Matan Azrad <matan@mellanox.com>
---
 drivers/net/failsafe/failsafe_ether.c | 1 +
 1 file changed, 1 insertion(+)

Comments

Gaëtan Rivet Sept. 4, 2017, 8:47 a.m. UTC | #1 
On Sun, Sep 03, 2017 at 06:26:45PM +0300, Matan Azrad wrote:
> The corrupted code don't reply error in case of MAC
> address adding failure while failsafe PMD was trying
> to apply configuration to the sub device.
> 
> Hence, the application may get unwanted packets.
> 
> The fix adds error report for this case.
> 
> Fixes: ebea83f899d8 ("net/failsafe: add plug-in support")
> Cc: stable@dpdk.org
> 
> Signed-off-by: Matan Azrad <matan@mellanox.com>
Acked-by: Gaetan Rivet <gaetan.rivet@6wind.com>
> ---
>  drivers/net/failsafe/failsafe_ether.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/net/failsafe/failsafe_ether.c b/drivers/net/failsafe/failsafe_ether.c
> index a3a8cce..fb9bbce 100644
> --- a/drivers/net/failsafe/failsafe_ether.c
> +++ b/drivers/net/failsafe/failsafe_ether.c
> @@ -203,6 +203,7 @@ fs_eth_dev_conf_apply(struct rte_eth_dev *dev,
>  
>  			ether_format_addr(ea_fmt, ETHER_ADDR_FMT_SIZE, ea);
>  			ERROR("Adding MAC address %s failed", ea_fmt);
> +			return ret;
>  		}
>  	}
>  	/* VLAN filter */
> -- 
> 2.7.4
>
Ferruh Yigit Sept. 5, 2017, 3:35 p.m. UTC | #2 
On 9/4/2017 9:47 AM, Gaëtan Rivet wrote:
> On Sun, Sep 03, 2017 at 06:26:45PM +0300, Matan Azrad wrote:
>> The corrupted code don't reply error in case of MAC
>> address adding failure while failsafe PMD was trying
>> to apply configuration to the sub device.
>>
>> Hence, the application may get unwanted packets.
>>
>> The fix adds error report for this case.
>>
>> Fixes: ebea83f899d8 ("net/failsafe: add plug-in support")
>> Cc: stable@dpdk.org
>>
>> Signed-off-by: Matan Azrad <matan@mellanox.com>
> Acked-by: Gaetan Rivet <gaetan.rivet@6wind.com>

Applied to dpdk-next-net/master, thanks.
diff mbox

Patch

diff --git a/drivers/net/failsafe/failsafe_ether.c b/drivers/net/failsafe/failsafe_ether.c
index a3a8cce..fb9bbce 100644
--- a/drivers/net/failsafe/failsafe_ether.c
+++ b/drivers/net/failsafe/failsafe_ether.c
@@ -203,6 +203,7 @@  fs_eth_dev_conf_apply(struct rte_eth_dev *dev,
 
 			ether_format_addr(ea_fmt, ETHER_ADDR_FMT_SIZE, ea);
 			ERROR("Adding MAC address %s failed", ea_fmt);
+			return ret;
 		}
 	}
 	/* VLAN filter */