[dpdk-dev,v2] buildtools: zero elf info variable in pmdinfogen

Message ID 1504618078-76742-1-git-send-email-harry.van.haaren@intel.com (mailing list archive)
State Accepted, archived
Headers

Checks

Context Check Description
ci/checkpatch success coding style OK
ci/Intel-compilation success Compilation OK

Commit Message

Van Haaren, Harry Sept. 5, 2017, 1:27 p.m. UTC
  This commit zeros out the elf_info struct at startup of the
pmdinfogen code. If it is not zeroed, later in the code gcc
produces "may be unused" prints. Clang does not report any
issue.

This issue is only observed when compiling pmdinfogen as an
optimized build, hence this warning is not disabled in the
existing Makefile.

This commit enables a simplification in the meson build
system, removing the requirement for "-Wno-maybe-uninitialized".

Signed-off-by: Harry van Haaren <harry.van.haaren@intel.com>

---

v2:
- Added note to commit message about optimized compiles (Bruce)

---
 buildtools/pmdinfogen/pmdinfogen.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
  

Comments

Bruce Richardson Sept. 5, 2017, 2:36 p.m. UTC | #1
On Tue, Sep 05, 2017 at 02:27:58PM +0100, Harry van Haaren wrote:
> This commit zeros out the elf_info struct at startup of the
> pmdinfogen code. If it is not zeroed, later in the code gcc
> produces "may be unused" prints. Clang does not report any
> issue.
> 
> This issue is only observed when compiling pmdinfogen as an
> optimized build, hence this warning is not disabled in the
> existing Makefile.
> 
> This commit enables a simplification in the meson build
> system, removing the requirement for "-Wno-maybe-uninitialized".
> 
> Signed-off-by: Harry van Haaren <harry.van.haaren@intel.com>
> 
Acked-by: Bruce Richardson <bruce.richardson@intel.com>
  
Thomas Monjalon Sept. 14, 2017, 12:21 p.m. UTC | #2
05/09/2017 16:36, Bruce Richardson:
> On Tue, Sep 05, 2017 at 02:27:58PM +0100, Harry van Haaren wrote:
> > This commit zeros out the elf_info struct at startup of the
> > pmdinfogen code. If it is not zeroed, later in the code gcc
> > produces "may be unused" prints. Clang does not report any
> > issue.
> > 
> > This issue is only observed when compiling pmdinfogen as an
> > optimized build, hence this warning is not disabled in the
> > existing Makefile.
> > 
> > This commit enables a simplification in the meson build
> > system, removing the requirement for "-Wno-maybe-uninitialized".
> > 
> > Signed-off-by: Harry van Haaren <harry.van.haaren@intel.com>
> > 
> Acked-by: Bruce Richardson <bruce.richardson@intel.com>

Applied, thanks
  

Patch

diff --git a/buildtools/pmdinfogen/pmdinfogen.c b/buildtools/pmdinfogen/pmdinfogen.c
index ba1a12e..e73fc76 100644
--- a/buildtools/pmdinfogen/pmdinfogen.c
+++ b/buildtools/pmdinfogen/pmdinfogen.c
@@ -397,7 +397,7 @@  static void output_pmd_info_string(struct elf_info *info, char *outfile)
 
 int main(int argc, char **argv)
 {
-	struct elf_info info;
+	struct elf_info info = {0};
 	int rc = 1;
 
 	if (argc < 3) {