diff mbox

[dpdk-dev] test: support to check AVX512F

Message ID 20170908074454.37149-1-zhiyong.yang@intel.com (mailing list archive)
State Superseded, archived
Delegated to: Bruce Richardson
Headers

Checks

Context Check Description
ci/checkpatch success coding style OK
ci/Intel-compilation success Compilation OK

Commit Message

Yang, Zhiyong Sept. 8, 2017, 7:44 a.m. UTC 
  The CPUs which support AVX512 have been released. Add the support
of checking AVX512F instruction set.

Signed-off-by: Zhiyong Yang <zhiyong.yang@intel.com>
---
 test/test/test_cpuflags.c | 3 +++
 1 file changed, 3 insertions(+)

Comments

Bruce Richardson Sept. 18, 2017, 3:07 p.m. UTC | #1 
suggest title as: test: add check for AVX512F

On Fri, Sep 08, 2017 at 03:44:54PM +0800, Zhiyong Yang wrote:
> The CPUs which support AVX512 have been released. Add the support
> of checking AVX512F instruction set.
>
s/the support of/support for/

> Signed-off-by: Zhiyong Yang <zhiyong.yang@intel.com>
> ---
Simple enough patch which adds one more check to the test. Probably
worth having. Reports the presence of the flag correctly on my board.

With commit message rewording:

Acked-by: Bruce Richardson <bruce.richardson@intel.com>
Yang, Zhiyong Sept. 19, 2017, 2:12 a.m. UTC | #2 
Hi Bruce,

> -----Original Message-----
> From: Richardson, Bruce
> Sent: Monday, September 18, 2017 11:08 PM
> To: Yang, Zhiyong <zhiyong.yang@intel.com>
> Cc: dev@dpdk.org
> Subject: Re: [dpdk-dev] [PATCH] test: support to check AVX512F
> 
> suggest title as: test: add check for AVX512F
> 
> On Fri, Sep 08, 2017 at 03:44:54PM +0800, Zhiyong Yang wrote:
> > The CPUs which support AVX512 have been released. Add the support of
> > checking AVX512F instruction set.
> >
> s/the support of/support for/
> 
> > Signed-off-by: Zhiyong Yang <zhiyong.yang@intel.com>
> > ---
> Simple enough patch which adds one more check to the test. Probably worth
> having. Reports the presence of the flag correctly on my board.
> 
> With commit message rewording:
> 
> Acked-by: Bruce Richardson <bruce.richardson@intel.com>

Thanks for your reviews , I will send V2 out sooner according to your comments.

Thanks
Zhiyong
diff mbox

Patch

diff --git a/test/test/test_cpuflags.c b/test/test/test_cpuflags.c
index 0e5ebe788..08c166139 100644
--- a/test/test/test_cpuflags.c
+++ b/test/test/test_cpuflags.c
@@ -171,6 +171,9 @@  test_cpuflags(void)
 	printf("Check for AVX2:\t\t");
 	CHECK_FOR_FLAG(RTE_CPUFLAG_AVX2);
 
+	printf("Check for AVX512F:\t");
+	CHECK_FOR_FLAG(RTE_CPUFLAG_AVX512F);
+
 	printf("Check for TRBOBST:\t");
 	CHECK_FOR_FLAG(RTE_CPUFLAG_TRBOBST);