[dpdk-dev,v5] net/mlx5: support device removal event
Checks
Commit Message
Extend the LSC event handling to support the device removal as well.
The mlx5 event handling has been made capable of receiving and
signaling several event types at once.
This support includes next:
1. Removal event detection according to the user configuration.
2. Calling to all registered mlx5 removal callbacks.
3. Capabilities extension to include removal interrupt handling.
Signed-off-by: Matan Azrad <matan@mellanox.com>
---
doc/guides/nics/features/mlx5.ini | 1 +
drivers/net/mlx5/mlx5.c | 2 +-
drivers/net/mlx5/mlx5_ethdev.c | 13 +++++++++++--
3 files changed, 13 insertions(+), 3 deletions(-)
V5 for adding support in mlx5 feature doc.
Comments
On 9/8/2017 11:47 AM, Matan Azrad wrote:
> Extend the LSC event handling to support the device removal as well.
>
> The mlx5 event handling has been made capable of receiving and
> signaling several event types at once.
>
> This support includes next:
> 1. Removal event detection according to the user configuration.
> 2. Calling to all registered mlx5 removal callbacks.
> 3. Capabilities extension to include removal interrupt handling.
>
> Signed-off-by: Matan Azrad <matan@mellanox.com>
Acked-by: Adrien Mazarguil <adrien.mazarguil@6wind.com>
Applied to dpdk-next-net/master, thanks.
(kept ack from previous version of the patch)
@@ -7,6 +7,7 @@
Speed capabilities = Y
Link status = Y
Link status event = Y
+Removal event = Y
Rx interrupt = Y
Queue start/stop = Y
MTU update = Y
@@ -870,7 +870,7 @@ static struct rte_pci_driver mlx5_driver = {
},
.id_table = mlx5_pci_id_map,
.probe = mlx5_pci_probe,
- .drv_flags = RTE_PCI_DRV_INTR_LSC,
+ .drv_flags = RTE_PCI_DRV_INTR_LSC | RTE_PCI_DRV_INTR_RMV,
};
/**
@@ -1172,6 +1172,9 @@ priv_dev_status_handler(struct priv *priv)
event.event_type == IBV_EVENT_PORT_ERR) &&
(priv->dev->data->dev_conf.intr_conf.lsc == 1))
ret |= (1 << RTE_ETH_EVENT_INTR_LSC);
+ else if (event.event_type == IBV_EVENT_DEVICE_FATAL &&
+ priv->dev->data->dev_conf.intr_conf.rmv == 1)
+ ret |= (1 << RTE_ETH_EVENT_INTR_RMV);
else
DEBUG("event type %d on port %d not handled",
event.event_type, event.element.port_num);
@@ -1227,6 +1230,9 @@ mlx5_dev_interrupt_handler(void *cb_arg)
if (events & (1 << RTE_ETH_EVENT_INTR_LSC))
_rte_eth_dev_callback_process(dev, RTE_ETH_EVENT_INTR_LSC, NULL,
NULL);
+ if (events & (1 << RTE_ETH_EVENT_INTR_RMV))
+ _rte_eth_dev_callback_process(dev, RTE_ETH_EVENT_INTR_RMV, NULL,
+ NULL);
}
/**
@@ -1240,7 +1246,8 @@ mlx5_dev_interrupt_handler(void *cb_arg)
void
priv_dev_interrupt_handler_uninstall(struct priv *priv, struct rte_eth_dev *dev)
{
- if (!dev->data->dev_conf.intr_conf.lsc)
+ if (!dev->data->dev_conf.intr_conf.lsc &&
+ !dev->data->dev_conf.intr_conf.rmv)
return;
rte_intr_callback_unregister(&priv->intr_handle,
mlx5_dev_interrupt_handler,
@@ -1265,7 +1272,8 @@ priv_dev_interrupt_handler_install(struct priv *priv, struct rte_eth_dev *dev)
{
int rc, flags;
- if (!dev->data->dev_conf.intr_conf.lsc)
+ if (!dev->data->dev_conf.intr_conf.lsc &&
+ !dev->data->dev_conf.intr_conf.rmv)
return;
assert(priv->ctx->async_fd > 0);
flags = fcntl(priv->ctx->async_fd, F_GETFL);
@@ -1273,6 +1281,7 @@ priv_dev_interrupt_handler_install(struct priv *priv, struct rte_eth_dev *dev)
if (rc < 0) {
INFO("failed to change file descriptor async event queue");
dev->data->dev_conf.intr_conf.lsc = 0;
+ dev->data->dev_conf.intr_conf.rmv = 0;
} else {
priv->intr_handle.fd = priv->ctx->async_fd;
priv->intr_handle.type = RTE_INTR_HANDLE_EXT;