diff mbox

[dpdk-dev,1/4] Add AMD XGBE Ethernet config support in DPDK

Message ID 1505324838-25734-1-git-send-email-ravi1.kumar@amd.com (mailing list archive)
State Changes Requested, archived
Delegated to: Ferruh Yigit
Headers

Checks

Context Check Description
ci/checkpatch success coding style OK
ci/Intel-compilation success Compilation OK

Commit Message

Kumar, Ravi1 Sept. 13, 2017, 5:47 p.m. UTC 
  Signed-off-by: Ravi Kumar <ravi1.kumar@amd.com>
---
 config/common_base | 6 ++++++
 mk/rte.app.mk      | 1 +
 2 files changed, 7 insertions(+)

Comments

Ferruh Yigit Sept. 14, 2017, 8:53 a.m. UTC | #1 
On 9/13/2017 6:47 PM, Ravi Kumar wrote:
> Signed-off-by: Ravi Kumar <ravi1.kumar@amd.com>
> ---
>  config/common_base | 6 ++++++
>  mk/rte.app.mk      | 1 +
>  2 files changed, 7 insertions(+)
> 
> diff --git a/config/common_base b/config/common_base
> index 5e97a08..fab46b5 100644
> --- a/config/common_base
> +++ b/config/common_base
> @@ -405,6 +405,12 @@ CONFIG_RTE_LIBRTE_AVP_DEBUG_DRIVER=y
>  CONFIG_RTE_LIBRTE_AVP_DEBUG_BUFFERS=n
>  
>  #
> +# Compile AMD PMD
> +#
> +CONFIG_RTE_LIBRTE_AXGBE_PMD=n

Hi Ravi,

This is a new networking driver from AMD. Great to see new vendors in
DPDK, welcome.

Patch 2/4 seems missing in the mail list, it may be stuck because of the
size limit if it is a big patch,
which may mean it needs to be split into multiple patches :)

Thanks,
ferruh


> +CONFIG_RTE_LIBRTE_AXGBE_DEBUG_INIT=n
> +
> +#
>  # Compile the TAP PMD
>  # It is enabled by default for Linux only.
>  #
> diff --git a/mk/rte.app.mk b/mk/rte.app.mk
> index c25fdd9..478ece1 100644
> --- a/mk/rte.app.mk
> +++ b/mk/rte.app.mk
> @@ -112,6 +112,7 @@ _LDLIBS-$(CONFIG_RTE_DRIVER_MEMPOOL_STACK)  += -lrte_mempool_stack
>  _LDLIBS-$(CONFIG_RTE_LIBRTE_PMD_AF_PACKET)  += -lrte_pmd_af_packet
>  _LDLIBS-$(CONFIG_RTE_LIBRTE_ARK_PMD)        += -lrte_pmd_ark
>  _LDLIBS-$(CONFIG_RTE_LIBRTE_AVP_PMD)        += -lrte_pmd_avp
> +_LDLIBS-$(CONFIG_RTE_LIBRTE_AXGBE_PMD)      += -lrte_pmd_axgbe
>  _LDLIBS-$(CONFIG_RTE_LIBRTE_BNX2X_PMD)      += -lrte_pmd_bnx2x -lz
>  _LDLIBS-$(CONFIG_RTE_LIBRTE_BNXT_PMD)       += -lrte_pmd_bnxt
>  _LDLIBS-$(CONFIG_RTE_LIBRTE_PMD_BOND)       += -lrte_pmd_bond
>
Kumar, Ravi1 Sept. 14, 2017, 9:48 a.m. UTC | #2 
>On 9/13/2017 6:47 PM, Ravi Kumar wrote:

>> Signed-off-by: Ravi Kumar <ravi1.kumar@amd.com>

>> ---

>>  config/common_base | 6 ++++++

>>  mk/rte.app.mk      | 1 +

>>  2 files changed, 7 insertions(+)

>> 

>> diff --git a/config/common_base b/config/common_base index 

>> 5e97a08..fab46b5 100644

>> --- a/config/common_base

>> +++ b/config/common_base

>> @@ -405,6 +405,12 @@ CONFIG_RTE_LIBRTE_AVP_DEBUG_DRIVER=y

>>  CONFIG_RTE_LIBRTE_AVP_DEBUG_BUFFERS=n

>>  

>>  #

>> +# Compile AMD PMD

>> +#

>> +CONFIG_RTE_LIBRTE_AXGBE_PMD=n

>

>Hi Ravi,

>

>This is a new networking driver from AMD. Great to see new vendors in DPDK, welcome.

>

>Patch 2/4 seems missing in the mail list, it may be stuck because of the size limit if it is a big patch, which may mean it needs to be split into multiple patches :)

>

>Thanks,

>ferruh


Hi Ferruh,

Thanks a lot. The Patch 2/4 got posted just now. It will be great to get review comments on the same.

Regards,
Ravi

>

>

>> +CONFIG_RTE_LIBRTE_AXGBE_DEBUG_INIT=n

>> +

>> +#

>>  # Compile the TAP PMD

>>  # It is enabled by default for Linux only.

>>  #

>> diff --git a/mk/rte.app.mk b/mk/rte.app.mk index c25fdd9..478ece1 

>> 100644

>> --- a/mk/rte.app.mk

>> +++ b/mk/rte.app.mk

>> @@ -112,6 +112,7 @@ _LDLIBS-$(CONFIG_RTE_DRIVER_MEMPOOL_STACK)  += 

>> -lrte_mempool_stack

>>  _LDLIBS-$(CONFIG_RTE_LIBRTE_PMD_AF_PACKET)  += -lrte_pmd_af_packet

>>  _LDLIBS-$(CONFIG_RTE_LIBRTE_ARK_PMD)        += -lrte_pmd_ark

>>  _LDLIBS-$(CONFIG_RTE_LIBRTE_AVP_PMD)        += -lrte_pmd_avp

>> +_LDLIBS-$(CONFIG_RTE_LIBRTE_AXGBE_PMD)      += -lrte_pmd_axgbe

>>  _LDLIBS-$(CONFIG_RTE_LIBRTE_BNX2X_PMD)      += -lrte_pmd_bnx2x -lz

>>  _LDLIBS-$(CONFIG_RTE_LIBRTE_BNXT_PMD)       += -lrte_pmd_bnxt

>>  _LDLIBS-$(CONFIG_RTE_LIBRTE_PMD_BOND)       += -lrte_pmd_bond

>>
Ferruh Yigit Sept. 14, 2017, 4:25 p.m. UTC | #3 
On 9/14/2017 10:48 AM, Kumar, Ravi1 wrote:
>> On 9/13/2017 6:47 PM, Ravi Kumar wrote:
>>> Signed-off-by: Ravi Kumar <ravi1.kumar@amd.com>
>>> ---
>>>  config/common_base | 6 ++++++
>>>  mk/rte.app.mk      | 1 +
>>>  2 files changed, 7 insertions(+)
>>>
>>> diff --git a/config/common_base b/config/common_base index 
>>> 5e97a08..fab46b5 100644
>>> --- a/config/common_base
>>> +++ b/config/common_base
>>> @@ -405,6 +405,12 @@ CONFIG_RTE_LIBRTE_AVP_DEBUG_DRIVER=y
>>>  CONFIG_RTE_LIBRTE_AVP_DEBUG_BUFFERS=n
>>>  
>>>  #
>>> +# Compile AMD PMD
>>> +#
>>> +CONFIG_RTE_LIBRTE_AXGBE_PMD=n
>>
>> Hi Ravi,
>>
>> This is a new networking driver from AMD. Great to see new vendors in DPDK, welcome.
>>
>> Patch 2/4 seems missing in the mail list, it may be stuck because of the size limit if it is a big patch, which may mean it needs to be split into multiple patches :)
>>
>> Thanks,
>> ferruh
> 
> Hi Ferruh,
> 
> Thanks a lot. The Patch 2/4 got posted just now. It will be great to get review comments on the same.

At first glance:

- There is a new licensing, that needs to be approved.
- patch 2/4 is big and hard to review properly, is it possible to have
multiple incremental patches, there are good previous samples of this.
- Can you please update release notes to announce new PMD?
- ICC is giving build error [1], but this can be handled later.


[1]
#pragma GCC diagnostic ignored "-Wcast-qual"

> 
> Regards,
> Ravi
<...>
diff mbox

Patch

diff --git a/config/common_base b/config/common_base
index 5e97a08..fab46b5 100644
--- a/config/common_base
+++ b/config/common_base
@@ -405,6 +405,12 @@  CONFIG_RTE_LIBRTE_AVP_DEBUG_DRIVER=y
 CONFIG_RTE_LIBRTE_AVP_DEBUG_BUFFERS=n
 
 #
+# Compile AMD PMD
+#
+CONFIG_RTE_LIBRTE_AXGBE_PMD=n
+CONFIG_RTE_LIBRTE_AXGBE_DEBUG_INIT=n
+
+#
 # Compile the TAP PMD
 # It is enabled by default for Linux only.
 #
diff --git a/mk/rte.app.mk b/mk/rte.app.mk
index c25fdd9..478ece1 100644
--- a/mk/rte.app.mk
+++ b/mk/rte.app.mk
@@ -112,6 +112,7 @@  _LDLIBS-$(CONFIG_RTE_DRIVER_MEMPOOL_STACK)  += -lrte_mempool_stack
 _LDLIBS-$(CONFIG_RTE_LIBRTE_PMD_AF_PACKET)  += -lrte_pmd_af_packet
 _LDLIBS-$(CONFIG_RTE_LIBRTE_ARK_PMD)        += -lrte_pmd_ark
 _LDLIBS-$(CONFIG_RTE_LIBRTE_AVP_PMD)        += -lrte_pmd_avp
+_LDLIBS-$(CONFIG_RTE_LIBRTE_AXGBE_PMD)      += -lrte_pmd_axgbe
 _LDLIBS-$(CONFIG_RTE_LIBRTE_BNX2X_PMD)      += -lrte_pmd_bnx2x -lz
 _LDLIBS-$(CONFIG_RTE_LIBRTE_BNXT_PMD)       += -lrte_pmd_bnxt
 _LDLIBS-$(CONFIG_RTE_LIBRTE_PMD_BOND)       += -lrte_pmd_bond