diff mbox

[dpdk-dev] test: fix wrong assignment operation

Message ID 20170915021616.34428-1-zhiyong.yang@intel.com (mailing list archive)
State Superseded, archived
Headers

Checks

Context Check Description
ci/checkpatch success coding style OK
ci/Intel-compilation success Compilation OK

Commit Message

Yang, Zhiyong Sept. 15, 2017, 2:16 a.m. UTC 
  It should be an comparation operation rather than an assignment
operation.

Fixes: 5e41ab250dfa("app/test: unit tests for bonding mode 4")

cc: Wodkowski, PawelX <pawelx.wodkowski@intel.com>
cc: Kulasek, TomaszX <tomaszx.kulasek@intel.com>
cc: Declan Doherty <declan.doherty@intel.com>
Signed-off-by: Zhiyong Yang <zhiyong.yang@intel.com>
---
 test/test/test_link_bonding_mode4.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Yang, Zhiyong Sept. 15, 2017, 2:42 a.m. UTC | #1 
Sorry. I make a mistake in Cc: email address.  This one is Superseded. 

> -----Original Message-----
> From: Yang, Zhiyong
> Sent: Friday, September 15, 2017 10:16 AM
> To: dev@dpdk.org
> Cc: Wodkowski; Wodkowski, PawelX <pawelx.wodkowski@intel.com>; Kulasek;
> Kulasek, TomaszX <tomaszx.kulasek@intel.com>; Doherty, Declan
> <declan.doherty@intel.com>; Yang, Zhiyong <zhiyong.yang@intel.com>
> Subject: [PATCH] test: fix wrong assignment operation
> 
> It should be an comparation operation rather than an assignment operation.
> 
> Fixes: 5e41ab250dfa("app/test: unit tests for bonding mode 4")
> 
> cc: Wodkowski, PawelX <pawelx.wodkowski@intel.com>
> cc: Kulasek, TomaszX <tomaszx.kulasek@intel.com>
> cc: Declan Doherty <declan.doherty@intel.com>
> Signed-off-by: Zhiyong Yang <zhiyong.yang@intel.com>
> ---
>  test/test/test_link_bonding_mode4.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/test/test/test_link_bonding_mode4.c
> b/test/test/test_link_bonding_mode4.c
> index 8e9e23db5..e246f0148 100644
> --- a/test/test/test_link_bonding_mode4.c
> +++ b/test/test/test_link_bonding_mode4.c
> @@ -661,7 +661,7 @@ bond_handshake(void)
>  	TEST_ASSERT_EQUAL(all_slaves_done, 1, "Bond handshake failed\n");
> 
>  	/* If flags doesn't match - report failure */
> -	return all_slaves_done = 1 ? TEST_SUCCESS : TEST_FAILED;
> +	return all_slaves_done == 1 ? TEST_SUCCESS : TEST_FAILED;
>  }
> 
>  #define TEST_LACP_SLAVE_COUT RTE_DIM(test_params.slave_ports)
> --
> 2.13.3
diff mbox

Patch

diff --git a/test/test/test_link_bonding_mode4.c b/test/test/test_link_bonding_mode4.c
index 8e9e23db5..e246f0148 100644
--- a/test/test/test_link_bonding_mode4.c
+++ b/test/test/test_link_bonding_mode4.c
@@ -661,7 +661,7 @@  bond_handshake(void)
 	TEST_ASSERT_EQUAL(all_slaves_done, 1, "Bond handshake failed\n");
 
 	/* If flags doesn't match - report failure */
-	return all_slaves_done = 1 ? TEST_SUCCESS : TEST_FAILED;
+	return all_slaves_done == 1 ? TEST_SUCCESS : TEST_FAILED;
 }
 
 #define TEST_LACP_SLAVE_COUT RTE_DIM(test_params.slave_ports)