diff mbox

[dpdk-dev] pmd_virtio: Buffer not null terminated

Message ID 1505821264-33518-1-git-send-email-sebastianx.basierski@intel.com (mailing list archive)
State Accepted, archived
Delegated to: Yuanhan Liu
Headers

Checks

Context Check Description
ci/checkpatch success coding style OK
ci/Intel-compilation success Compilation OK

Commit Message

SebastianX Basierski Sept. 19, 2017, 11:41 a.m. UTC 
  Fix calling strncpy with the a maximum size equal of destination
array size.

Coverity issue: 140732

Fixes: e3b434818bbb ("net/virtio-user: support kernel vhost")
Cc: jianfeng.tan@intel.com
cc: dev@dpdk.org

Signed-off-by: SebastianX Basierski <sebastianx.basierski@intel.com>
---
 drivers/net/virtio/virtio_user/vhost_kernel_tap.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Comments

Jianfeng Tan Sept. 20, 2017, 12:52 a.m. UTC | #1 
> -----Original Message-----
> From: Basierski, SebastianX
> Sent: Tuesday, September 19, 2017 7:41 PM
> To: skhare@vmware.com
> Cc: Basierski, SebastianX; Tan, Jianfeng; dev@dpdk.org
> Subject: [PATCH] pmd_virtio: Buffer not null terminated
> 
> Fix calling strncpy with the a maximum size equal of destination
> array size.
> 
> Coverity issue: 140732
> 
> Fixes: e3b434818bbb ("net/virtio-user: support kernel vhost")
> Cc: jianfeng.tan@intel.com
> cc: dev@dpdk.org

You want to Cc stable@dpdk.org?

> 
> Signed-off-by: SebastianX Basierski <sebastianx.basierski@intel.com>

Besides the above nit,
Acked-by: Jianfeng Tan <jianfeng.tan@intel.com>
SebastianX Basierski Sept. 20, 2017, 9:19 a.m. UTC | #2 
> -----Original Message-----
> From: Basierski, SebastianX
> Sent: Tuesday, September 19, 2017 7:41 PM
> To: skhare@vmware.com
> Cc: Basierski, SebastianX; Tan, Jianfeng; dev@dpdk.org
> Subject: [PATCH] pmd_virtio: Buffer not null terminated
> 
> Fix calling strncpy with the a maximum size equal of destination array 
> size.
> 
> Coverity issue: 140732
> 
> Fixes: e3b434818bbb ("net/virtio-user: support kernel vhost")
> Cc: jianfeng.tan@intel.com
> cc: dev@dpdk.org

You want to Cc stable@dpdk.org?

> 
> Signed-off-by: SebastianX Basierski <sebastianx.basierski@intel.com>

Besides the above nit,
Acked-by: Jianfeng Tan <jianfeng.tan@intel.com>


Hi,

I don't understand.
Are You asking me to send this patch as cc to stable@dpdk.org, but without lines below?

> 
> Signed-off-by: SebastianX Basierski <sebastianx.basierski@intel.com>

--------------------------------------------------------------------

Intel Technology Poland sp. z o.o.
ul. Slowackiego 173 | 80-298 Gdansk | Sad Rejonowy Gdansk Polnoc | VII Wydzial Gospodarczy Krajowego Rejestru Sadowego - KRS 101882 | NIP 957-07-52-316 | Kapital zakladowy 200.000 PLN.

Ta wiadomosc wraz z zalacznikami jest przeznaczona dla okreslonego adresata i moze zawierac informacje poufne. W razie przypadkowego otrzymania tej wiadomosci, prosimy o powiadomienie nadawcy oraz trwale jej usuniecie; jakiekolwiek
przegladanie lub rozpowszechnianie jest zabronione.
This e-mail and any attachments may contain confidential material for the sole use of the intended recipient(s). If you are not the intended recipient, please contact the sender and delete all copies; any review or distribution by
others is strictly prohibited.
Jianfeng Tan Sept. 20, 2017, 9:41 a.m. UTC | #3 
> -----Original Message-----
> From: Basierski, SebastianX
> Sent: Wednesday, September 20, 2017 5:20 PM
> To: Tan, Jianfeng; skhare@vmware.com
> Cc: dev@dpdk.org
> Subject: RE: [PATCH] pmd_virtio: Buffer not null terminated
> 
...
> 
> 
> Hi,
> 
> I don't understand.
> Are You asking me to send this patch as cc to stable@dpdk.org, but without
> lines below?

Nope. We need to cc stable@dpdk.org for bug fixes.
Yuanhan Liu Oct. 9, 2017, 3:07 a.m. UTC | #4 
On Tue, Sep 19, 2017 at 01:41:04PM +0200, SebastianX Basierski wrote:
> Fix calling strncpy with the a maximum size equal of destination
> array size.
> 
> Coverity issue: 140732
> 
> Fixes: e3b434818bbb ("net/virtio-user: support kernel vhost")
> Cc: jianfeng.tan@intel.com
> cc: dev@dpdk.org
> 
> Signed-off-by: SebastianX Basierski <sebastianx.basierski@intel.com>

Applied to dpdk-next-virtio.

Thanks.

	--yliu
diff mbox

Patch

diff --git a/drivers/net/virtio/virtio_user/vhost_kernel_tap.c b/drivers/net/virtio/virtio_user/vhost_kernel_tap.c
index f585de8..689a5cf 100644
--- a/drivers/net/virtio/virtio_user/vhost_kernel_tap.c
+++ b/drivers/net/virtio/virtio_user/vhost_kernel_tap.c
@@ -95,9 +95,9 @@  vhost_kernel_open_tap(char **p_ifname, int hdr_size, int req_mq)
 		ifr.ifr_flags |= IFF_MULTI_QUEUE;
 
 	if (*p_ifname)
-		strncpy(ifr.ifr_name, *p_ifname, IFNAMSIZ);
+		strncpy(ifr.ifr_name, *p_ifname, IFNAMSIZ - 1);
 	else
-		strncpy(ifr.ifr_name, "tap%d", IFNAMSIZ);
+		strncpy(ifr.ifr_name, "tap%d", IFNAMSIZ - 1);
 	if (ioctl(tapfd, TUNSETIFF, (void *)&ifr) == -1) {
 		PMD_DRV_LOG(ERR, "TUNSETIFF failed: %s", strerror(errno));
 		goto error;