diff mbox

[dpdk-dev,2/3] build: fix driver install path

Message ID 20170920105107.153935-3-bruce.richardson@intel.com (mailing list archive)
State Accepted, archived
Delegated to: Bruce Richardson
Headers

Checks

Context Check Description
ci/checkpatch success coding style OK
ci/Intel-compilation success Compilation OK

Commit Message

Bruce Richardson Sept. 20, 2017, 10:51 a.m. UTC 
  To comply with the "hier" standard [Ref: man 7 hier], the driver .so files
should not be placed in $datadir. Therefore we install them in a
sub-directory of $libdir instead.

Fixes: d123bba2dfbe ("build: add initial infrastructure for meson & ninja builds")

Reported-by: Timothy M. Redaelli <tredaelli@redhat.com>
Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>
---
 meson.build | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Bruce Richardson Sept. 20, 2017, 11:28 a.m. UTC | #1 
+Timothy, since git doesn't seem to automatically add reporters on CC.

On Wed, Sep 20, 2017 at 11:51:06AM +0100, Bruce Richardson wrote:
> To comply with the "hier" standard [Ref: man 7 hier], the driver .so files
> should not be placed in $datadir. Therefore we install them in a
> sub-directory of $libdir instead.
> 
> Fixes: d123bba2dfbe ("build: add initial infrastructure for meson & ninja builds")
> 
> Reported-by: Timothy M. Redaelli <tredaelli@redhat.com>
> Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>
> ---
>  meson.build | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/meson.build b/meson.build
> index 41426a706..6e4752562 100644
> --- a/meson.build
> +++ b/meson.build
> @@ -48,7 +48,7 @@ dpdk_extra_ldflags = []
>  if get_option('default_library') == 'static'
>  	driver_install_path = get_option('libdir')
>  else
> -	driver_install_path = join_paths(get_option('datadir'), 'dpdk/drivers')
> +	driver_install_path = join_paths(get_option('libdir'), 'dpdk/drivers')
>  endif
>  
>  # configure the build, and make sure configs here and in config folder are
> -- 
> 2.13.5
>
diff mbox

Patch

diff --git a/meson.build b/meson.build
index 41426a706..6e4752562 100644
--- a/meson.build
+++ b/meson.build
@@ -48,7 +48,7 @@  dpdk_extra_ldflags = []
 if get_option('default_library') == 'static'
 	driver_install_path = get_option('libdir')
 else
-	driver_install_path = join_paths(get_option('datadir'), 'dpdk/drivers')
+	driver_install_path = join_paths(get_option('libdir'), 'dpdk/drivers')
 endif
 
 # configure the build, and make sure configs here and in config folder are