diff mbox

[dpdk-dev] mempool: remove get capability debug print

Message ID 1507645031-21774-1-git-send-email-hemant.agrawal@nxp.com (mailing list archive)
State Accepted, archived
Headers

Checks

Context Check Description
ci/checkpatch success coding style OK
ci/Intel-compilation fail Compilation issues

Commit Message

Hemant Agrawal Oct. 10, 2017, 2:17 p.m. UTC 
  This is not required to be printed for every mempool call.

Signed-off-by: Hemant Agrawal <hemant.agrawal@nxp.com>
---
 lib/librte_mempool/rte_mempool.c | 5 +----
 1 file changed, 1 insertion(+), 4 deletions(-)

Comments

Santosh Shukla Oct. 10, 2017, 2:28 p.m. UTC | #1 
On Tuesday 10 October 2017 07:47 PM, Hemant Agrawal wrote:
> This is not required to be printed for every mempool call.
>
> Signed-off-by: Hemant Agrawal <hemant.agrawal@nxp.com>
> ---

Will print only in debug mode though, But ok with patch.

Reviewed-by: Santosh Shukla <santosh.shukla@caviumnetworks.com>
Thanks.
Thomas Monjalon Oct. 12, 2017, 1:31 a.m. UTC | #2 
10/10/2017 16:28, santosh:
> 
> On Tuesday 10 October 2017 07:47 PM, Hemant Agrawal wrote:
> > This is not required to be printed for every mempool call.
> >
> > Signed-off-by: Hemant Agrawal <hemant.agrawal@nxp.com>
> > ---
> 
> Will print only in debug mode though, But ok with patch.
> 
> Reviewed-by: Santosh Shukla <santosh.shukla@caviumnetworks.com>
> Thanks.

Applied, thanks
diff mbox

Patch

diff --git a/lib/librte_mempool/rte_mempool.c b/lib/librte_mempool/rte_mempool.c
index 57a4f81..6357fd4 100644
--- a/lib/librte_mempool/rte_mempool.c
+++ b/lib/librte_mempool/rte_mempool.c
@@ -559,10 +559,7 @@  rte_mempool_populate_default(struct rte_mempool *mp)
 	/* Get mempool capabilities */
 	mp_flags = 0;
 	ret = rte_mempool_ops_get_capabilities(mp, &mp_flags);
-	if (ret == -ENOTSUP)
-		RTE_LOG(DEBUG, MEMPOOL, "get_capability not supported for %s\n",
-					mp->name);
-	else if (ret < 0)
+	if ((ret < 0) && (ret != -ENOTSUP))
 		return ret;
 
 	/* update mempool capabilities */