diff mbox

[dpdk-dev] vhost: fetch again ring_addrs address after NUMA reallocation

Message ID 20171013093021.3196-1-maxime.coquelin@redhat.com (mailing list archive)
State Accepted, archived
Headers

Checks

Context Check Description
ci/checkpatch success coding style OK
ci/Intel-compilation success Compilation OK

Commit Message

Maxime Coquelin Oct. 13, 2017, 9:30 a.m. UTC 
  In case of NUMA reallocation, the virtqueue struct is reallocated
on another socket, meaning that its address changes.

In translate_ring_addresses(), addr pointer was not fetched again
after the reallocation, so it pointed to freed memory.

This patch just fetch again addr pointer after the reallocation.

Reported-by: Yao, Lei A <lei.a.yao@intel.com>
Tested-by: Yao, Lei A <lei.a.yao@intel.com>
Signed-off-by: Maxime Coquelin <maxime.coquelin@redhat.com>
---
 lib/librte_vhost/vhost_user.c | 1 +
 1 file changed, 1 insertion(+)

Comments

Jens Freimann Oct. 13, 2017, 9:43 a.m. UTC | #1 
On Fri, Oct 13, 2017 at 09:30:21AM +0000, Maxime Coquelin wrote:
>In case of NUMA reallocation, the virtqueue struct is reallocated
>on another socket, meaning that its address changes.
>
>In translate_ring_addresses(), addr pointer was not fetched again
>after the reallocation, so it pointed to freed memory.
>
>This patch just fetch again addr pointer after the reallocation.
>
>Reported-by: Yao, Lei A <lei.a.yao@intel.com>
>Tested-by: Yao, Lei A <lei.a.yao@intel.com>
>Signed-off-by: Maxime Coquelin <maxime.coquelin@redhat.com>
>---
> lib/librte_vhost/vhost_user.c | 1 +
> 1 file changed, 1 insertion(+)
>

Reviewed-by: Jens Freimann <jfreimann@redhat.com>
Thomas Monjalon Oct. 13, 2017, 7:31 p.m. UTC | #2 
13/10/2017 11:43, Jens Freimann:
> On Fri, Oct 13, 2017 at 09:30:21AM +0000, Maxime Coquelin wrote:
> >In case of NUMA reallocation, the virtqueue struct is reallocated
> >on another socket, meaning that its address changes.
> >
> >In translate_ring_addresses(), addr pointer was not fetched again
> >after the reallocation, so it pointed to freed memory.
> >
> >This patch just fetch again addr pointer after the reallocation.
> >
> >Reported-by: Yao, Lei A <lei.a.yao@intel.com>
> >Tested-by: Yao, Lei A <lei.a.yao@intel.com>
> >Signed-off-by: Maxime Coquelin <maxime.coquelin@redhat.com>
> 
> Reviewed-by: Jens Freimann <jfreimann@redhat.com>

Applied, thanks
diff mbox

Patch

diff --git a/lib/librte_vhost/vhost_user.c b/lib/librte_vhost/vhost_user.c
index 9acac6125..2416a0061 100644
--- a/lib/librte_vhost/vhost_user.c
+++ b/lib/librte_vhost/vhost_user.c
@@ -417,6 +417,7 @@  translate_ring_addresses(struct virtio_net *dev, int vq_index)
 
 	dev = numa_realloc(dev, vq_index);
 	vq = dev->virtqueue[vq_index];
+	addr = &vq->ring_addrs;
 
 	vq->avail = (struct vring_avail *)(uintptr_t)ring_addr_to_vva(dev,
 			vq, addr->avail_user_addr, sizeof(struct vring_avail));