diff mbox

[dpdk-dev,v1,1/1] rte_crypto.h: Fix compilation issue with Ofast.

Message ID 1508238255-30383-1-git-send-email-ian.stokes@intel.com (mailing list archive)
State Superseded, archived
Delegated to: Pablo de Lara Guarch
Headers

Checks

Context Check Description
ci/checkpatch success coding style OK
ci/Intel-compilation success Compilation OK

Commit Message

Ian Stokes Oct. 17, 2017, 11:04 a.m. UTC 
  When compiling with an application that includes rte_cryptodev.h with
Ofast, an error is reported regarding enumeration
RTE_CRYPTO_OP_TYPE_UNDEFINED not handled in switch case in function
 __rte_crypto_op_reset().

Fix this by adding case for RTE_OP_TYPE_UNDEFINED.

Signed-off-by: Ian Stokes <ian.stokes@intel.com>
---
 lib/librte_cryptodev/rte_crypto.h |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

Comments

De Lara Guarch, Pablo Oct. 17, 2017, 11:54 a.m. UTC | #1 
Hi Ian,

> -----Original Message-----
> From: Stokes, Ian
> Sent: Tuesday, October 17, 2017 12:04 PM
> To: dev@dpdk.org
> Cc: De Lara Guarch, Pablo <pablo.de.lara.guarch@intel.com>; Stokes, Ian
> <ian.stokes@intel.com>
> Subject: [PATCH v1 1/1] rte_crypto.h: Fix compilation issue with Ofast.
> 
> When compiling with an application that includes rte_cryptodev.h with
> Ofast, an error is reported regarding enumeration
> RTE_CRYPTO_OP_TYPE_UNDEFINED not handled in switch case in function
> __rte_crypto_op_reset().
> 
> Fix this by adding case for RTE_OP_TYPE_UNDEFINED.
> 
> Signed-off-by: Ian Stokes <ian.stokes@intel.com>

Since this is a fix, you should add a fixes line with the commit id where the issue was introduced.
This case: Fixes: c0f87eb5252b ("cryptodev: change burst API to be crypto op oriented")

Also, the title should be: "cryptodev: fix build with Ofast"

Could you send a v2 with these changes?

Thanks,
Pablo
Ian Stokes Oct. 17, 2017, 12:50 p.m. UTC | #2 
.
> 
> Hi Ian,
> 
> > -----Original Message-----
> > From: Stokes, Ian
> > Sent: Tuesday, October 17, 2017 12:04 PM
> > To: dev@dpdk.org
> > Cc: De Lara Guarch, Pablo <pablo.de.lara.guarch@intel.com>; Stokes,
> > Ian <ian.stokes@intel.com>
> > Subject: [PATCH v1 1/1] rte_crypto.h: Fix compilation issue with Ofast.
> >
> > When compiling with an application that includes rte_cryptodev.h with
> > Ofast, an error is reported regarding enumeration
> > RTE_CRYPTO_OP_TYPE_UNDEFINED not handled in switch case in function
> > __rte_crypto_op_reset().
> >
> > Fix this by adding case for RTE_OP_TYPE_UNDEFINED.
> >
> > Signed-off-by: Ian Stokes <ian.stokes@intel.com>
> 
> Since this is a fix, you should add a fixes line with the commit id where
> the issue was introduced.
> This case: Fixes: c0f87eb5252b ("cryptodev: change burst API to be crypto
> op oriented")
> 
> Also, the title should be: "cryptodev: fix build with Ofast"
> 
> Could you send a v2 with these changes?

Thanks for the feedback Pablo, will send a v2.

Thanks
Ian
> 
> Thanks,
> Pablo
diff mbox

Patch

diff --git a/lib/librte_cryptodev/rte_crypto.h b/lib/librte_cryptodev/rte_crypto.h
index 10fe080..3ef9e41 100644
--- a/lib/librte_cryptodev/rte_crypto.h
+++ b/lib/librte_cryptodev/rte_crypto.h
@@ -144,6 +144,7 @@  struct rte_crypto_op {
 	case RTE_CRYPTO_OP_TYPE_SYMMETRIC:
 		__rte_crypto_sym_op_reset(op->sym);
 		break;
+	case RTE_CRYPTO_OP_TYPE_UNDEFINED:
 	default:
 		break;
 	}