[dpdk-dev] examples/power: add turbo commands to help text

Message ID 1508405665-232195-1-git-send-email-marko.kovacevic@intel.com (mailing list archive)
State Accepted, archived
Headers

Checks

Context Check Description
ci/checkpatch success coding style OK
ci/Intel-compilation success Compilation OK

Commit Message

Kovacevic, Marko Oct. 19, 2017, 9:34 a.m. UTC
  From: David Hunt <david.hunt@intel.com>

Fixes: d191f0853378 ("examples/vm_power_manager: add per-core turbo CLI")

Signed-off-by: Marko Kovacevic <marko.kovacevic@intel.com>
---
 examples/vm_power_manager/guest_cli/vm_power_cli_guest.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)
  

Comments

Hunt, David Oct. 19, 2017, 12:27 p.m. UTC | #1
Hi Marko,

On 19/10/2017 10:34 AM, Marko Kovacevic wrote:
> From: David Hunt <david.hunt@intel.com>
>
> Fixes: d191f0853378 ("examples/vm_power_manager: add per-core turbo CLI")
>
> Signed-off-by: Marko Kovacevic <marko.kovacevic@intel.com>
> ---
>   examples/vm_power_manager/guest_cli/vm_power_cli_guest.c | 5 +++--
>   1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/examples/vm_power_manager/guest_cli/vm_power_cli_guest.c b/examples/vm_power_manager/guest_cli/vm_power_cli_guest.c
> index dc9efc2..63f711e 100644
> --- a/examples/vm_power_manager/guest_cli/vm_power_cli_guest.c
> +++ b/examples/vm_power_manager/guest_cli/vm_power_cli_guest.c
> @@ -131,8 +131,9 @@ cmdline_parse_token_string_t cmd_set_cpu_freq_cmd_cmd =
>   cmdline_parse_inst_t cmd_set_cpu_freq_set = {
>   	.f = cmd_set_cpu_freq_parsed,
>   	.data = NULL,
> -	.help_str = "set_cpu_freq <core_num> <up|down|min|max>, Set the current "
> -			"frequency for the specified core by scaling up/down/min/max",
> +	.help_str = "set_cpu_freq <core_num> "
> +			"<up|down|min|max|enable_turbo|disable_turbo>, "
> +			"adjust the frequency for the specified core.",
>   	.tokens = {
>   		(void *)&cmd_set_cpu_freq,
>   		(void *)&cmd_set_cpu_freq_core_num,

Thanks for the patch. Looks good to me.

Acked-by: David Hunt <david.hunt@intel.com>
  
Thomas Monjalon Oct. 24, 2017, 9:51 p.m. UTC | #2
19/10/2017 14:27, Hunt, David:
> Hi Marko,
> 
> On 19/10/2017 10:34 AM, Marko Kovacevic wrote:
> > From: David Hunt <david.hunt@intel.com>
> >
> > Fixes: d191f0853378 ("examples/vm_power_manager: add per-core turbo CLI")
> >
> > Signed-off-by: Marko Kovacevic <marko.kovacevic@intel.com>
> > ---
> Thanks for the patch. Looks good to me.
> 
> Acked-by: David Hunt <david.hunt@intel.com>

Applied, thanks
  

Patch

diff --git a/examples/vm_power_manager/guest_cli/vm_power_cli_guest.c b/examples/vm_power_manager/guest_cli/vm_power_cli_guest.c
index dc9efc2..63f711e 100644
--- a/examples/vm_power_manager/guest_cli/vm_power_cli_guest.c
+++ b/examples/vm_power_manager/guest_cli/vm_power_cli_guest.c
@@ -131,8 +131,9 @@  cmdline_parse_token_string_t cmd_set_cpu_freq_cmd_cmd =
 cmdline_parse_inst_t cmd_set_cpu_freq_set = {
 	.f = cmd_set_cpu_freq_parsed,
 	.data = NULL,
-	.help_str = "set_cpu_freq <core_num> <up|down|min|max>, Set the current "
-			"frequency for the specified core by scaling up/down/min/max",
+	.help_str = "set_cpu_freq <core_num> "
+			"<up|down|min|max|enable_turbo|disable_turbo>, "
+			"adjust the frequency for the specified core.",
 	.tokens = {
 		(void *)&cmd_set_cpu_freq,
 		(void *)&cmd_set_cpu_freq_core_num,