| Message ID | 20171020153958.10236-1-santosh.shukla@caviumnetworks.com (mailing list archive) |
|---|---|
| State | Accepted, archived |
| Delegated to: | Thomas Monjalon |
| Headers |
Return-Path: <dev-bounces@dpdk.org> X-Original-To: patchwork@dpdk.org Delivered-To: patchwork@dpdk.org Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 633F41B238; Fri, 20 Oct 2017 17:40:35 +0200 (CEST) Received: from NAM02-CY1-obe.outbound.protection.outlook.com (mail-cys01nam02on0065.outbound.protection.outlook.com [104.47.37.65]) by dpdk.org (Postfix) with ESMTP id 2B2B51B22B for <dev@dpdk.org>; Fri, 20 Oct 2017 17:40:34 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=CAVIUMNETWORKS.onmicrosoft.com; s=selector1-cavium-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=l8u97KCUqvMOGWf8r4OersWOA3SdCZvStMUVaCo/VPM=; b=B5sI5jYr79RNIOfwXh4Wl+ra+k8lptH2HxglOTZlirsE4nAb21alSNdDpP4M7NkFqj/jOHkiARfU4bN+gFne7y4/eBdh5h11Mh+RlntxjGoyaz3I2qa/nlBAI5FPO5K+sCSoIJRX/BO9JiiNDiKXic1D2LNj5A5PDBMbciuhaZs= Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=Santosh.Shukla@cavium.com; Received: from localhost.localdomain (111.93.218.67) by BN6PR07MB3091.namprd07.prod.outlook.com (10.172.105.9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.77.7; Fri, 20 Oct 2017 15:40:30 +0000 From: Santosh Shukla <santosh.shukla@caviumnetworks.com> To: dev@dpdk.org Cc: thomas@monjalon.net, jerin.jacob@caviumnetworks.com, Santosh Shukla <santosh.shukla@caviumnetworks.com> Date: Fri, 20 Oct 2017 15:39:58 +0000 Message-Id: <20171020153958.10236-1-santosh.shukla@caviumnetworks.com> X-Mailer: git-send-email 2.13.0 MIME-Version: 1.0 Content-Type: text/plain X-Originating-IP: [111.93.218.67] X-ClientProxiedBy: MA1PR0101CA0067.INDPRD01.PROD.OUTLOOK.COM (52.134.136.29) To BN6PR07MB3091.namprd07.prod.outlook.com (10.172.105.9) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: fb4a1dab-873e-4527-a1da-08d517d0e5d9 X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(22001)(4534020)(4602075)(4627075)(201703031133081)(201702281549075)(2017052603199); SRVR:BN6PR07MB3091; X-Microsoft-Exchange-Diagnostics: 1; BN6PR07MB3091; 3:zQNRMSjkm4sTi62HqOepXCbFA5lRyi+QREnKK7kl4sdBhFn4NTl6Znwfn1Fmkz6jpw35baglbNM8e01nZ8vklAkiXB9ZZ1iu+2p66p7qQfd7hzGyaMGk/3CwSkbsMp898wsn2wbqgkcVj9Cpe9A63Ukhy3xygzHXOuQSbRh8ixCW35ym6nLhOu/cnVu3hElHtg/ULE0/rkFL+K0g6GHy6RQ7UGYiiVHq/D424PhY+ZX+9W527tcf9QMZTppsHbZy; 25:6hoPErUQm1lHlGjAsbQkdGnu5gIcaLq6bG3Kk+O8LV0UW9NRHYk2yjtQTUbYDLkgd1Zf7FsFKgO/s1G+M449P88NujXtqiVN2gD2SyAx5Ohogmhb4h62CEJMJAzdBXMDVxCfsKWXXN4s2xAomRpQ5wmpQG9qyifmxSSJdR+KMOSN1BCgRWINTpUP5qpTzcfEn095XakisrrfkXZYFovjRdwfQSZXQG4lS2JqM9oZ3Tg9bLaASemP5Qbyj6ZnED6wnQC686tJbf0RHzYCI2EgM6HYjMo1eAtJvXSFfGW39r8OFQ3YLaBejcTDYN/Jally9LSCy/qW8eocSN/Y4LC/Ew==; 31:QFWVlZ4Vdlp8ewpXb+JEe2iKwVbnFynzI7cmJlok0lBPDaHYJi8SKC3tp5awhXUd7+kqDGqUFn/JulINV7Y9x9KVueTQBKhtMKmTMQuF4qhkBZueHmrtK9z8EAtvhPaGU+ohZ9xrLjAMfc6NeRnrFQQkijzmEOxm8ISWa7o5clhkHJkeCMK7CyevnSV4X2isHEegzyzgOt7PoCNqOjGaGsqrCO+L1KQblQjdc5lgRu0= X-MS-TrafficTypeDiagnostic: BN6PR07MB3091: X-Microsoft-Exchange-Diagnostics: 1; BN6PR07MB3091; 20:xSZKLru2MZTs/wweZ0JN156Sy2N80DeTx/XxpDBds0fLRVVFCrW9OKqNqK6H4uNwMmANlj7upQKx7Ao7ONmknuIFWO6H9i3qV3EnPaWpWFXC1qTnmtFqZG4DiVJ1fov79p/qOY5OV8B9BL78VqKkXBrWsQRlyXMIPOef1jLUVYb7Vz1FlYcpWPDvb1nEJeJ6S6c7qOlku3CZ7dFd/G82sS8MvnCCbugQ/rTAWvUPA3ksVAXZXLm7JQO/M0DNE0yfrFb0s2EvCvfdsexApy7QEsXj4iIlVP+iS9lRs6yLIHPzfx844+v3DgpjJQm5XK9I+IWc4Uf8pbEjTItJyBKqBnB+9RC0F2RxVUvWHEhR68ckqCP2eHAL9YdxnNO1FPcNj/jQ5ZC1s9Su13TMQouvrVnlVmdX9kYb/1OIa959T1pqHgumjSlPuZpP3+kuEjndo0KlO5LghexhzE6xWiu3Q9bMoDg2v3TIRXVIW45ePRPn7dp84WMp3YFLLqp7zj1NMn0OG/9e9IiMa/OWsSyr2Qq9J2ki3SDu6txs23sHBrJPUbvzmyT28NU1bQbFChW71oIu5OTAh6V+Jst1tDzM1UyK9d0AkOi5icp+abfStYw=; 4:O9qYryy0WBgGwbGYq5QYyoQh6tLJwUZoKAV4rl14FoaKenA7NFPkaRcrCo0bQXosj1g7C88mT04THf9cCrbZC4l52DM7dUWdL7Fdbp/N51uOeJWNiUcvHA/6qbCuW3h9Ishp/iKTkslyz99g7iozVq35DUeECBKXtHSpEOVCHabHsy8v8ZWjgXy45aO43iEpk207h8ueOOTu2AM7uoqD+WsUBpmkvor3oPwC2sKoxFvvqWPjHCouzR9BFJCF5eU4 X-Exchange-Antispam-Report-Test: UriScan:; X-Microsoft-Antispam-PRVS: <BN6PR07MB3091D1A00AADCDBB7E942E1CEA430@BN6PR07MB3091.namprd07.prod.outlook.com> X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(100000700101)(100105000095)(100000701101)(100105300095)(100000702101)(100105100095)(6040450)(2401047)(8121501046)(5005006)(100000703101)(100105400095)(10201501046)(3002001)(93006095)(3231020)(6041248)(20161123564025)(20161123558100)(20161123560025)(20161123555025)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(20161123562025)(6072148)(201708071742011)(100000704101)(100105200095)(100000705101)(100105500095); SRVR:BN6PR07MB3091; BCL:0; PCL:0; RULEID:(100000800101)(100110000095)(100000801101)(100110300095)(100000802101)(100110100095)(100000803101)(100110400095)(100000804101)(100110200095)(100000805101)(100110500095); SRVR:BN6PR07MB3091; X-Forefront-PRVS: 0466CA5A45 X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(6009001)(6069001)(346002)(376002)(199003)(189002)(6116002)(106356001)(47776003)(48376002)(7736002)(5660300001)(50986999)(2906002)(478600001)(6916009)(101416001)(53936002)(2361001)(81166006)(8676002)(42882006)(105586002)(5009440100003)(68736007)(305945005)(8936002)(33646002)(81156014)(6666003)(2351001)(1076002)(16526018)(50466002)(6512007)(36756003)(6506006)(50226002)(6486002)(3846002)(66066001)(5003940100001)(16586007)(189998001)(72206003)(316002)(97736004)(4326008)(107886003)(25786009); DIR:OUT; SFP:1101; SCL:1; SRVR:BN6PR07MB3091; H:localhost.localdomain; FPR:; SPF:None; PTR:InfoNoRecords; A:1; MX:1; LANG:en; Received-SPF: None (protection.outlook.com: cavium.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; BN6PR07MB3091; 23:7AhctVNqNTZaG3p5n7szjNoMZt+fhIuPq1ihp9z3S?= suGHfJCtzDhPtdS8eXgqqKIJ7y9JCWtxYY7raMBRAMd5OSJ7sD+MXOm5W+UyV19gPtCdHhB7t+yS3lSqAVJ2H/MOSJu3Hj/27cY48vhDB8waFSNyqGY23Klm9LIQRUreKHjwldliAEtl/FTiT1coZlZswLB+blkhawYrQ2SvlGXue5pTBym7sC0KbWYHVSvuGNrerdu3oLteDylOVuaeaTpcemfeURiyLWNPHL6nam2w6F92sHzOKIbB03Jyw7RASnKf217rQ1qDkrkIcQSmPkobO7yfUha36gW5mZ9kHr3DpkfSebcziGrQwqmuYIWFmMRT6/MSC1X8BnlLzOQLEne7jaztfy4z7Xy0rfofN+sYgQqi7W9Kb/P2J40ZDVRBbF7IXLMDuXE+QXiKRYQL7SK1oHca4/0pYWUKrf7porpJotIAawEUxSI8cYBAx75BpIg6hbAIaksST0M3SZXA5xGaBWf4IefiIgSbN0lwr0IssiRzZIMNFb+M6Fg1jnJ0jlTejeDRx72JQgJxMgg20motYmJT+bVSHFLHap3sYkYPK3YSf3oqvZCg5aNeJxtTzseMckK5El3Pem+h8juAORI/9U2LuqHCXoC+ZEFn4MWXvY8qrPPHgVSr7DYiPfEPInqKDI5NXuk8e9zPNrSYQ0HDy43S8FJg4tCm7h6suTPJa7dxM/YOym/Z+ayVYl1ucz4G7+PUHyQzxqifF3+AkO5oXtyLTi5YQd7TGUM8hXvdYVw+IdR1HZ1CWnHcvQ1DOQY2e418Cgra8PfTNo6HWB+JuatYb8AKfGHV78ssuTFv1a1cpF/In0dPo3tMzzLkklmYxWjIcX5W7smIUYmCo+6xS+/5SucL3hJWAynTwkFPe0qjmkEbjSsFwgJx5XZabBhwmfvRYCEhz2+osUqbpa9tsvhdjzanEYR2kQ2XXEG3yIW6s0aeEEgbQEJ+22yz8nOmERWqyYtfN7LNgp0Bd8EwmO2q/qNw4zWvUkOEirEVf+kxvFRq5UGAO1r9DAZbJH58akOqSDwFuv6vQJEElnx6gv3fRyuHjXBrWMj8mBMJLws8k9b4kXZhg1EE8T/AjDpuDrwVTC7dq8EGvk7BE/X8abDVKI0JJ8RIfr+CbpJVg== X-Microsoft-Exchange-Diagnostics: 1; BN6PR07MB3091; 6:/5c5yu7sTu4Wb+AArtXY647pm8RTOgZ1yc7LK5jsqwh5XNSdvAnlg5lqXQEI3HCbpzUWoGrpo7XkgSG56BS1t+XCeV0cbKJHMyZXz8NvpdgoJUTcjPH+6Q0o40t0akkkSbVBdogBbIkk/qe4RBcPIjcl3ww/dSBCZJvX4LECA9VkdF7Odn1kVs0nmQakXPcaaKe8x3uhMhYN3AxWcayshtWfA2iEWvboTjhsP7rZSEbWXJudSDE9LNKMNR+Tock8Hc/Dl6YQybYD/50inMVvbkNTao979oVDoFH/3Q1lFze6CrdIhSQE37+Rghn2N0dglBD4ullHBht69ghmZNoFcA==; 5:X/rTlLihLYujVGabmcIKNveFoRfwnmwO5W5u+JNC7YzN8rtP9mJtkzXWTvZFh9yl/YQTxW0USi02Bb/HTKI7kCSPrtEYaxPjBmgs94YrS4lVS9RaOA5GN6aHbA1gh89PwtlsrivJN4DU2iCuvwoj3Q==; 24:KyWZUC73JJgClGfCEsj2vERTe9DxV80SjIg9V86SRex9Or05eH1O0nYXaXw7qHRp3d4h6iGZmbg7QC3W9aEQX1O3yWdpSBfD2u+MoxYRlNk=; 7:zLp338mhXBWt+1RpZa33ngfAIK0STHfy8DQLGBECnBBcPc7y+q4yb2tiVv2fzZnB2yDhdXtz+DXQ4bP+DyE1O77tx0RhI72yMH6kFaCaAkGRkCmW6jLUDAm1CmbBUbjD3qJe29zzU7QBuJEERpeMiEHoHXRGb1nhZjNvHjbRlBQ316gdqKgN6BbDP0gicGhePdkmRaxGUh1t9ZyfdkHSowvRMmATT9bGtgrbFT8jf38= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: caviumnetworks.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 Oct 2017 15:40:30.4049 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 711e4ccf-2e9b-4bcf-a551-4094005b6194 X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN6PR07MB3091 Subject: [dpdk-dev] [PATCH v1] mempool/octeontx: remove dead code from gpool2handle X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <http://dpdk.org/ml/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://dpdk.org/ml/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <http://dpdk.org/ml/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> Errors-To: dev-bounces@dpdk.org Sender: "dev" <dev-bounces@dpdk.org> |
Checks
| Context | Check | Description |
|---|---|---|
| ci/checkpatch | success | coding style OK |
| ci/Intel-compilation | success | Compilation OK |
Commit Message
Santosh Shukla
Oct. 20, 2017, 3:39 p.m. UTC
Coverity Issue: 195000
Fixes: 02fd6c744350 ("mempool/octeontx: support allocation")
Signed-off-by: Santosh Shukla <santosh.shukla@caviumnetworks.com>
---
drivers/mempool/octeontx/octeontx_fpavf.c | 3 ---
1 file changed, 3 deletions(-)
Comments
-----Original Message----- > Date: Fri, 20 Oct 2017 15:39:58 +0000 > From: Santosh Shukla <santosh.shukla@caviumnetworks.com> > To: dev@dpdk.org > Cc: thomas@monjalon.net, jerin.jacob@caviumnetworks.com, Santosh Shukla > <santosh.shukla@caviumnetworks.com> > Subject: [PATCH v1] mempool/octeontx: remove dead code from gpool2handle > X-Mailer: git-send-email 2.13.0 > > Coverity Issue: 195000 > Fixes: 02fd6c744350 ("mempool/octeontx: support allocation") > > Signed-off-by: Santosh Shukla <santosh.shukla@caviumnetworks.com> Acked-by: Jerin Jacob <jerin.jacob@caviumnetworks.com> > --- > drivers/mempool/octeontx/octeontx_fpavf.c | 3 --- > 1 file changed, 3 deletions(-) > > diff --git a/drivers/mempool/octeontx/octeontx_fpavf.c b/drivers/mempool/octeontx/octeontx_fpavf.c > index 6bdfc0339..cd36a195d 100644 > --- a/drivers/mempool/octeontx/octeontx_fpavf.c > +++ b/drivers/mempool/octeontx/octeontx_fpavf.c > @@ -176,9 +176,6 @@ octeontx_fpa_gpool2handle(uint16_t gpool) > RTE_ASSERT(gpool < FPA_VF_MAX); > > res = &fpadev.pool[gpool]; > - if (unlikely(res == NULL)) > - return 0; > - > return (uintptr_t)res->bar0 | gpool; > } > > -- > 2.13.0 >
> > Coverity Issue: 195000 > > Fixes: 02fd6c744350 ("mempool/octeontx: support allocation") > > > > Signed-off-by: Santosh Shukla <santosh.shukla@caviumnetworks.com> > > Acked-by: Jerin Jacob <jerin.jacob@caviumnetworks.com> Applied, thanks
diff --git a/drivers/mempool/octeontx/octeontx_fpavf.c b/drivers/mempool/octeontx/octeontx_fpavf.c index 6bdfc0339..cd36a195d 100644 --- a/drivers/mempool/octeontx/octeontx_fpavf.c +++ b/drivers/mempool/octeontx/octeontx_fpavf.c @@ -176,9 +176,6 @@ octeontx_fpa_gpool2handle(uint16_t gpool) RTE_ASSERT(gpool < FPA_VF_MAX); res = &fpadev.pool[gpool]; - if (unlikely(res == NULL)) - return 0; - return (uintptr_t)res->bar0 | gpool; }