diff mbox

[dpdk-dev,pktgen] Fix the protocol settings with the range command.

Message ID 20171024083718.22624-1-ilovethull@163.com (mailing list archive)
State Not Applicable, archived
Headers

Checks

Context Check Description
ci/checkpatch warning coding style issues
ci/Intel-compilation success Compilation OK

Commit Message

Bing Zhao Oct. 24, 2017, 8:37 a.m. UTC 
  A "%" is missing in the command line, so the parameter comparison always returns failure. And the local variable "what" points to the argv[4], it is incorrect for this command since the argc is 4 and the max should be argv[3].

Signed-off-by: bing.zhao@hxt-semitech.com
Signed-off-by: jie2.liu@hxt-semitech.com
Signed-off-by: jia.he@hxt-semitech.com

---
 app/cli-functions.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Comments

Wiles, Keith Oct. 24, 2017, 12:45 p.m. UTC | #1 
Thank you

> On Oct 24, 2017, at 3:37 AM, Bing Zhao <ilovethull@163.com> wrote:
> 
> A "%" is missing in the command line, so the parameter comparison always returns failure. And the local variable "what" points to the argv[4], it is incorrect for this command since the argc is 4 and the max should be argv[3].
> 
> Signed-off-by: bing.zhao@hxt-semitech.com
> Signed-off-by: jie2.liu@hxt-semitech.com
> Signed-off-by: jia.he@hxt-semitech.com
> 
> ---
> app/cli-functions.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/app/cli-functions.c b/app/cli-functions.c
> index 076b86e..5e58f9c 100644
> --- a/app/cli-functions.c
> +++ b/app/cli-functions.c
> @@ -150,7 +150,7 @@ static struct cli_map range_map[] = {
> 	{ 31, "range %P src ip "SMMI" %4" },
> 	{ 32, "range %P dst ip %4 %4 %4 %4" },
> 	{ 33, "range %P src ip %4 %4 %4 %4" },
> -	{ 40, "range %P proto tcp|udp" },
> +	{ 40, "range %P proto %|tcp|udp" },
> 	{ 50, "range %P dst port "SMMI" %d" },
> 	{ 51, "range %P src port "SMMI" %d" },
> 	{ 52, "range %P dst port %d %d %d %d" },
> @@ -280,7 +280,7 @@ range_cmd(int argc, char **argv)
> 			break;
> 		case 40:
> 			foreach_port(portlist,
> -				range_set_proto(info, what) );
> +				range_set_proto(info, argv[3]) );
> 			break;
> 		case 50:
> 			foreach_port(portlist,
> -- 
> 2.11.0.windows.1
> 
> 

Regards,
Keith
diff mbox

Patch

diff --git a/app/cli-functions.c b/app/cli-functions.c
index 076b86e..5e58f9c 100644
--- a/app/cli-functions.c
+++ b/app/cli-functions.c
@@ -150,7 +150,7 @@  static struct cli_map range_map[] = {
 	{ 31, "range %P src ip "SMMI" %4" },
 	{ 32, "range %P dst ip %4 %4 %4 %4" },
 	{ 33, "range %P src ip %4 %4 %4 %4" },
-	{ 40, "range %P proto tcp|udp" },
+	{ 40, "range %P proto %|tcp|udp" },
 	{ 50, "range %P dst port "SMMI" %d" },
 	{ 51, "range %P src port "SMMI" %d" },
 	{ 52, "range %P dst port %d %d %d %d" },
@@ -280,7 +280,7 @@  range_cmd(int argc, char **argv)
 			break;
 		case 40:
 			foreach_port(portlist,
-				range_set_proto(info, what) );
+				range_set_proto(info, argv[3]) );
 			break;
 		case 50:
 			foreach_port(portlist,