diff mbox

[dpdk-dev] examples/qos_sched: fix uninitialized scalar variable

Message ID 20171024090957.114392-1-jasvinder.singh@intel.com (mailing list archive)
State Accepted, archived
Headers

Checks

Context Check Description
ci/checkpatch success coding style OK
ci/Intel-compilation success Compilation OK

Commit Message

Jasvinder Singh Oct. 24, 2017, 9:09 a.m. UTC 
  Fix problem with uninitialized rx/tx deferred_start flags of the struct
rte_eth_rxconf/txconf by initializing with 0 value (deferred start of
the rx/tx queues is turned off). This setting allows device rx/tx
queues to start with rte_eth_dev_start().

Coverity issue: 194999, 195009 (Uninitialized scalar variable)
Fixes: de3cfa2c9823 ("sched: initial import")
Cc: stable@dpdk.org

Signed-off-by: Jasvinder Singh <jasvinder.singh@intel.com>
---
 examples/qos_sched/init.c | 2 ++
 1 file changed, 2 insertions(+)

Comments

Thomas Monjalon Oct. 24, 2017, 9:58 p.m. UTC | #1 
24/10/2017 11:09, Jasvinder Singh:
> Fix problem with uninitialized rx/tx deferred_start flags of the struct
> rte_eth_rxconf/txconf by initializing with 0 value (deferred start of
> the rx/tx queues is turned off). This setting allows device rx/tx
> queues to start with rte_eth_dev_start().
> 
> Coverity issue: 194999, 195009 (Uninitialized scalar variable)
> Fixes: de3cfa2c9823 ("sched: initial import")
> Cc: stable@dpdk.org
> 
> Signed-off-by: Jasvinder Singh <jasvinder.singh@intel.com>

Applied, thanks
diff mbox

Patch

diff --git a/examples/qos_sched/init.c b/examples/qos_sched/init.c
index 004ac54..038f042 100644
--- a/examples/qos_sched/init.c
+++ b/examples/qos_sched/init.c
@@ -118,6 +118,7 @@  app_init_port(uint16_t portid, struct rte_mempool *mp)
 	rx_conf.rx_thresh.wthresh = rx_thresh.wthresh;
 	rx_conf.rx_free_thresh = 32;
 	rx_conf.rx_drop_en = 0;
+	rx_conf.rx_deferred_start = 0;
 
 	tx_conf.tx_thresh.pthresh = tx_thresh.pthresh;
 	tx_conf.tx_thresh.hthresh = tx_thresh.hthresh;
@@ -125,6 +126,7 @@  app_init_port(uint16_t portid, struct rte_mempool *mp)
 	tx_conf.tx_free_thresh = 0;
 	tx_conf.tx_rs_thresh = 0;
 	tx_conf.txq_flags = ETH_TXQ_FLAGS_NOMULTSEGS | ETH_TXQ_FLAGS_NOOFFLOADS;
+	tx_conf.tx_deferred_start = 0;
 
 	/* init port */
 	RTE_LOG(INFO, APP, "Initializing port %"PRIu16"... ", portid);