diff mbox

[dpdk-dev] net/mlx5: fix device stop with multiple regions

Message ID 085e95741dd064e931ba75b4c54d8a64f81b5009.1508940093.git.nelio.laranjeiro@6wind.com (mailing list archive)
State Accepted, archived
Delegated to: Ferruh Yigit
Headers

Checks

Context Check Description
ci/checkpatch success coding style OK
ci/Intel-compilation success Compilation OK

Commit Message

Nélio Laranjeiro Oct. 25, 2017, 2:04 p.m. UTC 
  LIST macro are not safe when inside a LIST_FOREACH() a LIST_REMOVE() is
called to remove an entry, this behavior is undefined causing some entries
to disappear from the list.

Fixes: 6e78005a9b30 ("net/mlx5: add reference counter on DPDK Tx queues")

Signed-off-by: Nelio Laranjeiro <nelio.laranjeiro@6wind.com>
---
 drivers/net/mlx5/mlx5_trigger.c | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

Comments

Ferruh Yigit Oct. 25, 2017, 9:56 p.m. UTC | #1 
On 10/25/2017 7:04 AM, Nelio Laranjeiro wrote:
> LIST macro are not safe when inside a LIST_FOREACH() a LIST_REMOVE() is
> called to remove an entry, this behavior is undefined causing some entries
> to disappear from the list.
> 
> Fixes: 6e78005a9b30 ("net/mlx5: add reference counter on DPDK Tx queues")
> 
> Signed-off-by: Nelio Laranjeiro <nelio.laranjeiro@6wind.com>

Applied to dpdk-next-net/master, thanks.
diff mbox

Patch

diff --git a/drivers/net/mlx5/mlx5_trigger.c b/drivers/net/mlx5/mlx5_trigger.c
index 982d0a24d..5de2d026e 100644
--- a/drivers/net/mlx5/mlx5_trigger.c
+++ b/drivers/net/mlx5/mlx5_trigger.c
@@ -188,7 +188,7 @@  mlx5_dev_start(struct rte_eth_dev *dev)
 error:
 	/* Rollback. */
 	dev->data->dev_started = 0;
-	LIST_FOREACH(mr, &priv->mr, next)
+	for (mr = LIST_FIRST(&priv->mr); mr; mr = LIST_FIRST(&priv->mr))
 		priv_mr_release(priv, mr);
 	priv_flow_stop(priv, &priv->flows);
 	priv_dev_traffic_disable(priv, dev);
@@ -230,9 +230,8 @@  mlx5_dev_stop(struct rte_eth_dev *dev)
 	priv_dev_interrupt_handler_uninstall(priv, dev);
 	priv_txq_stop(priv);
 	priv_rxq_stop(priv);
-	LIST_FOREACH(mr, &priv->mr, next) {
+	for (mr = LIST_FIRST(&priv->mr); mr; mr = LIST_FIRST(&priv->mr))
 		priv_mr_release(priv, mr);
-	}
 	priv_flow_delete_drop_queue(priv);
 	priv_unlock(priv);
 }