diff mbox

[dpdk-dev] net/nfp: avoid unplug if multiport

Message ID 1509447892-36422-1-git-send-email-alejandro.lucero@netronome.com (mailing list archive)
State Accepted, archived
Delegated to: Ferruh Yigit
Headers

Checks

Context Check Description
ci/checkpatch success coding style OK
ci/Intel-compilation success Compilation OK

Commit Message

Alejandro Lucero Oct. 31, 2017, 11:04 a.m. UTC 
  PF multiport support has some limitations like not allowing plugging or
unplugging of single ports as they all belong to same PCI device.

A previous patch for removing detachable flag introduced a wrong check.

Fixes: 00a3d8104ac5 ("ethdev: remove detachable device flag")
Cc: gaetan.rivet@6wind.com

Signed-off-by: Alejandro Lucero <alejandro.lucero@netronome.com>
---
 drivers/net/nfp/nfp_net.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Ferruh Yigit Oct. 31, 2017, 5:23 p.m. UTC | #1 
On 10/31/2017 4:04 AM, Alejandro Lucero wrote:
> PF multiport support has some limitations like not allowing plugging or
> unplugging of single ports as they all belong to same PCI device.
> 
> A previous patch for removing detachable flag introduced a wrong check.
> 
> Fixes: 00a3d8104ac5 ("ethdev: remove detachable device flag")
> Cc: gaetan.rivet@6wind.com
> 
> Signed-off-by: Alejandro Lucero <alejandro.lucero@netronome.com>

Applied to dpdk-next-net/master, thanks.
diff mbox

Patch

diff --git a/drivers/net/nfp/nfp_net.c b/drivers/net/nfp/nfp_net.c
index 8c1c1f0..05f26bc 100644
--- a/drivers/net/nfp/nfp_net.c
+++ b/drivers/net/nfp/nfp_net.c
@@ -3029,7 +3029,7 @@  static int eth_nfp_pci_remove(struct rte_pci_device *pci_dev)
 		hw = NFP_NET_DEV_PRIVATE_TO_HW(eth_dev->data->dev_private);
 	}
 	/* hotplug is not possible with multiport PF */
-	if (!hw->pf_multiport_enabled)
+	if (hw->pf_multiport_enabled)
 		return -ENOTSUP;
 	return rte_eth_dev_pci_generic_remove(pci_dev, NULL);
 }