diff mbox

[dpdk-dev] mem: remove old function from symbol list

Message ID 20171103112455.18406-1-thomas@monjalon.net (mailing list archive)
State Accepted, archived
Headers

Checks

Context Check Description
ci/checkpatch success coding style OK
ci/Intel-compilation success Compilation OK

Commit Message

Thomas Monjalon Nov. 3, 2017, 11:24 a.m. UTC 
  The function rte_mem_phy2mch() was removed with the support
of Xen dom0.

Fixes: a7cb2e20d23c ("mem: remove API to get physical address in dom0")

Signed-off-by: Thomas Monjalon <thomas@monjalon.net>
---
 lib/librte_eal/rte_eal_version.map | 1 -
 1 file changed, 1 deletion(-)

Comments

Sergio Gonzalez Monroy Nov. 3, 2017, 11:34 a.m. UTC | #1 
Hi Thomas,

I reckon you need to bump ABI version when you remove public symbol from 
.map file.

Thanks,
Sergio

On 03/11/2017 11:24, Thomas Monjalon wrote:
> The function rte_mem_phy2mch() was removed with the support
> of Xen dom0.
>
> Fixes: a7cb2e20d23c ("mem: remove API to get physical address in dom0")
>
> Signed-off-by: Thomas Monjalon <thomas@monjalon.net>
> ---
>   lib/librte_eal/rte_eal_version.map | 1 -
>   1 file changed, 1 deletion(-)
>
> diff --git a/lib/librte_eal/rte_eal_version.map b/lib/librte_eal/rte_eal_version.map
> index d2a4ff974..7c9bdc2ae 100644
> --- a/lib/librte_eal/rte_eal_version.map
> +++ b/lib/librte_eal/rte_eal_version.map
> @@ -62,7 +62,6 @@ DPDK_2.0 {
>   	rte_malloc_validate;
>   	rte_malloc_virt2phy;
>   	rte_mem_lock_page;
> -	rte_mem_phy2mch;
>   	rte_mem_virt2phy;
>   	rte_memdump;
>   	rte_memory_get_nchannel;
Thomas Monjalon Nov. 3, 2017, 1:52 p.m. UTC | #2 
03/11/2017 12:34, Gonzalez Monroy, Sergio:
> Hi Thomas,
> 
> I reckon you need to bump ABI version when you remove public symbol from 
> .map file.

Yes, of course, unless it has already been dumped:
	http://dpdk.org/commit/f26ab687a74


> On 03/11/2017 11:24, Thomas Monjalon wrote:
> > The function rte_mem_phy2mch() was removed with the support
> > of Xen dom0.
> >
> > Fixes: a7cb2e20d23c ("mem: remove API to get physical address in dom0")
> >
> > Signed-off-by: Thomas Monjalon <thomas@monjalon.net>
> > ---
> >   lib/librte_eal/rte_eal_version.map | 1 -
> >   1 file changed, 1 deletion(-)
> >
> > diff --git a/lib/librte_eal/rte_eal_version.map b/lib/librte_eal/rte_eal_version.map
> > index d2a4ff974..7c9bdc2ae 100644
> > --- a/lib/librte_eal/rte_eal_version.map
> > +++ b/lib/librte_eal/rte_eal_version.map
> > @@ -62,7 +62,6 @@ DPDK_2.0 {
> >   	rte_malloc_validate;
> >   	rte_malloc_virt2phy;
> >   	rte_mem_lock_page;
> > -	rte_mem_phy2mch;
> >   	rte_mem_virt2phy;
> >   	rte_memdump;
> >   	rte_memory_get_nchannel;
> 
>
Thomas Monjalon Nov. 6, 2017, 9:15 p.m. UTC | #3 
03/11/2017 12:24, Thomas Monjalon:
> The function rte_mem_phy2mch() was removed with the support
> of Xen dom0.
> 
> Fixes: a7cb2e20d23c ("mem: remove API to get physical address in dom0")
> 
> Signed-off-by: Thomas Monjalon <thomas@monjalon.net>

Applied
diff mbox

Patch

diff --git a/lib/librte_eal/rte_eal_version.map b/lib/librte_eal/rte_eal_version.map
index d2a4ff974..7c9bdc2ae 100644
--- a/lib/librte_eal/rte_eal_version.map
+++ b/lib/librte_eal/rte_eal_version.map
@@ -62,7 +62,6 @@  DPDK_2.0 {
 	rte_malloc_validate;
 	rte_malloc_virt2phy;
 	rte_mem_lock_page;
-	rte_mem_phy2mch;
 	rte_mem_virt2phy;
 	rte_memdump;
 	rte_memory_get_nchannel;