Message ID | 1510062750-29091-1-git-send-email-ophirmu@mellanox.com (mailing list archive) |
---|---|
State | Accepted, archived |
Headers |
Return-Path: <dev-bounces@dpdk.org> X-Original-To: patchwork@dpdk.org Delivered-To: patchwork@dpdk.org Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id EA48A1B5E9; Tue, 7 Nov 2017 14:52:45 +0100 (CET) Received: from EUR03-VE1-obe.outbound.protection.outlook.com (mail-eopbgr50040.outbound.protection.outlook.com [40.107.5.40]) by dpdk.org (Postfix) with ESMTP id 282521B398; Tue, 7 Nov 2017 14:52:44 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=mDBxXYpc95i4l4qM3vfg57Unw9iQJgMLN+rMFmhA8Uo=; b=GoI4khfyknVqc1t2FYnYa1SQtOGcnv4gTz/xQVvvdISEWUZ+hkK9kXUN5RmdKaxGkaA3BKq9YFAtJ3OYnMUVb/dpqbg5SgvvYz/wDcDzupx23ri0RHfzuLoNlgNZYcTFBEy2k+rifG+3/Knu6n/slBcNuk2GCcCiW0X2b4U6UbI= Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=ophirmu@mellanox.com; Received: from mellanox.com (37.142.13.130) by AM3PR05MB1252.eurprd05.prod.outlook.com (2a01:111:e400:586f::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.197.13; Tue, 7 Nov 2017 13:52:40 +0000 From: Ophir Munk <ophirmu@mellanox.com> To: Jingjing Wu <jingjing.wu@intel.com> Cc: Gaetan Rivet <gaetan.rivet@6wind.com>, <Ophir Munk <ophirmu@mellanox.com>, dev@dpdk.org, Thomas Monjalon <thomas@monjalon.net>, Olga Shern <olgas@mellanox.com>, stable@dpdk.org, Raslan Darawsheh <rasland@mellanox.com> Date: Tue, 7 Nov 2017 13:52:30 +0000 Message-Id: <1510062750-29091-1-git-send-email-ophirmu@mellanox.com> X-Mailer: git-send-email 1.8.3.1 In-Reply-To: <1509977954-4333-1-git-send-email-ophirmu@mellanox.com> References: <1509977954-4333-1-git-send-email-ophirmu@mellanox.com> MIME-Version: 1.0 Content-Type: text/plain X-Originating-IP: [37.142.13.130] X-ClientProxiedBy: VI1PR0801CA0075.eurprd08.prod.outlook.com (2603:10a6:800:7d::19) To AM3PR05MB1252.eurprd05.prod.outlook.com (2a01:111:e400:586f::14) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: e1b11de0-299b-415a-ee43-08d525e6d0fa X-MS-Office365-Filtering-HT: Tenant X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(22001)(48565401081)(4534020)(4602075)(4627115)(201703031133081)(201702281549075)(2017052603199); SRVR:AM3PR05MB1252; X-Microsoft-Exchange-Diagnostics: 1; AM3PR05MB1252; 3:zc2+fG88YmyqoaZMw73ZEg5BbrIrPzgESqW2GmbhvnWRXPC6vn8H7mEUnSRwmOEJCMq9vCN1ReS7I5Grca1BhciLGX3DAKeDxmWVpjEFi4CH8KUiXBB9lmuwDrvPLkJAd/HJpkKt9nIzpTB9P0qJIJ/D/Zs4lskPkYbVZqxUlQ7pQi0MbpnYTg45LOxc3yzVV9mPwhUWZzDbaRbKdtjrArWuEJyoCz+4LSdT0d5tR5latFE10C6oZMfqWBbRsrWb; 25:U1i/EBEaS5K0vA9ihNg3AGyNAmyEe7AjgV6Yuxwr1GI3TGYqFuhyBe1UpV6SO7qz09kE9hhpqE+3Rl0maA69FvqE6246ywh8MUoe+pwdAl0Tdb2u7it4X5AkhmVHYdec00CeDPOZKfLYoKSZvPTjs/tqj7/OU+VjKWtIDnGIEgrk7G6MTtHyuI/GDaTTVfGAnEXKoHPlED/zYpNf+CYJ6v34IwZhDWJZ+xdQlqNHIgF/gZu8ZBr71rs57IJrMUoYgUrI9oosjh24FTeQMtwJe2EP7dsnp3vfwyFuOzJM9Vu4Dx7dbAmcBqNJXpycLeZ4v7oo4oki/JI1eZiEauZ8PQ==; 31:1xt2gLw7yxL2MirRsL/HCCB1/U94UrpsZmKB7QX/RHH/Q14FyXbTEEyNRMGcmL7hfFLHSHVElhkx+vBFzaVzZ/YywU7h1lAmBUhHFPYYo9MpUQjQP/DFJZOFDfaKh7qRxhHBsAuzAet6csTaJIkA65mRkP/UPFKD2W6ExGjvsPfIWKDxk5NqoK1s1zFuc7EwZGG3byuUqGFAqzFftIpitQl4HubXE5kgGiSBddBhGYw= X-MS-TrafficTypeDiagnostic: AM3PR05MB1252: X-LD-Processed: a652971c-7d2e-4d9b-a6a4-d149256f461b,ExtAddr X-Microsoft-Exchange-Diagnostics: 1; AM3PR05MB1252; 20:8f3fMwqq3WXOpsviTO21LHytNmTdfEnzKZcnwwkJNYZ4uBZ7veqZzkOWK4Uu0v7kl2ABXlv9Lrb4WTwksWHb4spvG3mQiV50VO4MSs+kzylSQ0Su15tz2ikfygy81fMgIetFp5Qhigf5GgAivblDAblyGQQTe38qx9T8C9lzVMjJWqwi/+vkuWqH+8TGlaSQ0ELjYMxQBgu7S0sBuBpjEC1knB9dtWosnEeCtDsWVT00PbvApldh4cjAW9d3KsJfmfy8G5m4Lr0tGwxHmw3UJlMtZHQprRiQGU6nLNjB81MX30VwzQvbH0RxwgQLwIT8iGOgQ65iyoHxkeSXPUmov7Dupbu7nr0aX3aS3T8D9BYUcHvkcLVtmUCkzuZJAnMcLE7GNzfdrT8nQd50qgk2Qa4Id4DzuUjls8OPMGmSN8bZK2YF4RfhURvklA1tWPNcKdeIVeQ+R9dgvIZpOht+uaJ6MI/7m2f0AgzA0NK+a8DWh1QoqvL7aGkWJ2nDuTVY; 4:ErGWDJoczf294zbx3Y6S+x/tA2b/2fRMLhI3Mzorsdit4LVcdI+ujRGUu+bOQbx11kHk7QWcmLcToFJTnJyhtqHLaauEh4MQJWof+9S8NuwfW4ZOpYV1r2oBvaNqt382ewmBq8mKPSml688wD43mQJXedVJHnyL/q1j1Z2bb6vuf3nSU5P67vZXNIgX2kfLadHVU56TInH52HSuHwB3u/LqqLFX0wOTGpzrfzQuQ5T2/4n1fDShex/HtZeL0OCDWT0vz2W4fMOvXzGh7w7ByQw== X-Exchange-Antispam-Report-Test: UriScan:; X-Microsoft-Antispam-PRVS: <AM3PR05MB1252171157545BBA99D44D7AD1510@AM3PR05MB1252.eurprd05.prod.outlook.com> X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(100000700101)(100105000095)(100000701101)(100105300095)(100000702101)(100105100095)(6040450)(2401047)(5005006)(8121501046)(3002001)(3231021)(10201501046)(93006095)(93001095)(100000703101)(100105400095)(6055026)(6041248)(20161123564025)(20161123558100)(20161123560025)(20161123562025)(20161123555025)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(6072148)(201708071742011)(100000704101)(100105200095)(100000705101)(100105500095); SRVR:AM3PR05MB1252; BCL:0; PCL:0; RULEID:(100000800101)(100110000095)(100000801101)(100110300095)(100000802101)(100110100095)(100000803101)(100110400095)(100000804101)(100110200095)(100000805101)(100110500095); SRVR:AM3PR05MB1252; X-Forefront-PRVS: 0484063412 X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(6009001)(376002)(346002)(39860400002)(199003)(189002)(3846002)(189998001)(81156014)(305945005)(50466002)(478600001)(48376002)(5003940100001)(33026002)(66066001)(7736002)(47776003)(8936002)(97736004)(33646002)(86362001)(81166006)(8676002)(68736007)(16526018)(25786009)(6116002)(5660300001)(101416001)(107886003)(54906003)(21086003)(50986999)(55016002)(50226002)(6916009)(53936002)(6666003)(316002)(106356001)(16586007)(69596002)(4720700003)(105586002)(2906002)(76176999)(4326008)(2950100002)(36756003); DIR:OUT; SFP:1101; SCL:1; SRVR:AM3PR05MB1252; H:mellanox.com; FPR:; SPF:None; PTR:InfoNoRecords; A:1; MX:1; LANG:en; Received-SPF: None (protection.outlook.com: mellanox.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; AM3PR05MB1252; 23:J17LtaVMqDaqloRAQx6QD+MOfb8fOMAORRCGmAGi+?= 9E/dB/4y/9AxNZ30e+Ksbq6zuXc2VwuH1ATVxz0M4Q1kTAnjVnqy+LZQM1ckeJqUHPANvel083z9Z74ZcErqvSYoJ0hzqE5IX57B+hSo1R/pmAwZ2IishsRKt2d0vsUv/orHQoawQQlM5j9sxXqQ4h7j2XDheF6iwH2xSLmZf1jQv4JyAxM+/KjWJLjHDHH3X99Q7O0Rk2GyaMpulDPceWKTPoFGWuG5R854cMS8+Z68WnUZyL6qwZBE/+qTcfoNV57Co4s4cP3QZv9CA3ujbi6yGd+6UkLAAjaXLfHYyVhSI+2FuF5VWThB7YzH7HSP6RKwTZAx/UA5VRGDGFeuhruyhY4w+Oj/gH0NOq8+bQuh6r9wFJ+IFuJ5T+4f2F/z7UR1ssFzi2Brxh3NzQSq6gsQ5sXg3vgMsYSrmx0D8Z2vc5j8EgODtSiCibEndO/HPtY5eTfOgGhV1PRW3ECb8hWx6H1cjtNxZAJrIsmY3DKZInTRk+Pi9qVYsJoZTU2G8PulWM0B4ki9KewcLD/WN/YMdi+CEO2qIBooBv35zHHRJGxfW6oMIFzfI+OsH0CGHJzScClCRicxuMUhYSWVwWh1JA5v/VgvTIob9EuCR1kfV5Wxmq6ke8zFagQVDysjrIloyz/uQNpCUzAdl66DnQ72NIIAyaWkYgOzJjHdGX8S54R9cRhdBdQC6akVqoDvquRmuBwmO5Fw7CAjRUP73iMIyUpacP5h0ous8YqpiEdboXhbE+qkYFIc1YruilLkmMKOd3BZBRqA+jw23l3ZkQWIDo1HPhnAZdVmvdbnsB/rUZ/+vWfIBDUCoKm9JQVImhz6enwruD9ruVdrN+5A1JQMLnJ7J1FXs821K5hLk+d0+bbNWnfDLEdYHN3t7hWx22Rgb4QS1v2iX6Vr2x7Ib09ZGkWCCYUWDwl+g910e8jUPEnuK6im13il9MRRgmKuD0vPiMh+/U+x4Hzra5hyqLlbkveQnr2Av7OZop8wS2Gob0FOJ88ykueN/UWq2tOqwwsAWck8ETBLUhCSv5LGeW8jzS91sol9KQNM7BZKKLv7tUN5vC5heMpaa1erN5V3se10jf0Y6xs5N0pJhAtGjEIdA6Dw3zYIJH3sg0oExEgpRJHwJY6Jhr6hczjXYJer0k= X-Microsoft-Exchange-Diagnostics: 1; AM3PR05MB1252; 6:D+2Mwjd28Hl6j64beNf5rzpJ3McsNRoF4r6tB14Owkt1RrBFJjkZ8zENXCz7rHedXcXt/Uoukl9EFU81atv5O1RggoAg0BkBQlpc00khIVqbtf+SaUUVfNoQrwuoUyNPpG/DJBP58/GVFy7xcXMlCU60cnLSs9pwgrESiN4OP2vIg4JGOHcpQfxWazHDhEti260abm7e5lW7SzPJb6lFE1W9XaQg6LVzsZCfTTiClYS6WnxKGx1C4H5qPYulEKKffCH4qCZ/QT62OP4IjCjysP3TXx8ryCAXLHznt6ywG81xbfMe08nYP6eUielPJoiGp9T+CqPqJALTVxSAebpEo/M4QEKVs6DALViqSUErFy4=; 5:EV6xC138HCQkXyug3+HKKDYseYGDZoqTxpeTjOgIK5J6hjxNC0dlJH1T+2Lf8KtPSUSqPbaM7jxxHzmUzJWRua8GEc4YnGUQiY8amRlWwZTRIqQGntVz4mQcDIXE8gE7hMOWFS4MWza8YtVdHvhYoOt1Ds5IbdpI0zCxLAYptz0=; 24:mPbD6YbEu45Nw9hjRUe3P7DXW30BYGTCuU3XDAr1zP/lilrpzZyFr2H6zw2KBuIkU7DnIfw5EmhX/opyZlCNCe5TDq3Z/bKTKRdtyH2WOSA=; 7:NLvjyy60Pf5LUEbPQ0L0y/FG7He/zHhJHQKCrjZqphc9anbp7VxlOuUe5V5pi81w828snMkT2arlYIuLgnLi5+nIbJWm7b1CwPTQgRqV3nVzq+67n/9xSYqJDQYXCMpzGB3+IWw3h6Rw+UlyeX0XUZ/kOCj+DWMmTyYsoEl8UqjQ2+UXDclGbqtFoMZVKGHAg/aY7yKa4YfGetp7Lx/vvEzzXncPyLE8WD8Sqmvyi6kKGao6GTtRpKwTOAngi6kK SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Nov 2017 13:52:40.8010 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: e1b11de0-299b-415a-ee43-08d525e6d0fa X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM3PR05MB1252 Subject: [dpdk-dev] [PATCH v2] app/testpmd: fix forwarding between non consecutive ports X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <http://dpdk.org/ml/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://dpdk.org/ml/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <http://dpdk.org/ml/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> Errors-To: dev-bounces@dpdk.org Sender: "dev" <dev-bounces@dpdk.org> |
Checks
Context | Check | Description |
---|---|---|
ci/checkpatch | success | coding style OK |
ci/Intel-compilation | success | Compilation OK |
Commit Message
Ophir Munk
Nov. 7, 2017, 1:52 p.m. UTC
When defining two failsafe devices in testpmd the port numbers of the failsafe devices may not be consecutive. For example: if failsafe device includes a PCI device and a TAP device then failsafe port numbers would be 0 and 3. Port 0 - failsafe #1 device Port 1 - PCI #1 device Port 2 - TAP #1 device Port 3 - failsafe #2 device Port 4 - PCI #2 device Port 5 - TAP #2 device If forwarding is defined between the failsafe devices including a peer address the forwarding should be between peer addresses of ports 0 and 3. Instead testpmd establishes forwarding between peer addresses of consecutive ports 0 and 1. This commit fixes this bug. Fixes: af75078fece3 ("first public release") Cc: stable@dpdk.org Signed-off-by: Ophir Munk <ophirmu@mellanox.com> Signed-off-by: Raslan Darawsheh <rasland@mellanox.com> --- app/test-pmd/config.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
Comments
It is a really basic bug in testpmd. Someone to review it quickly please?
> -----Original Message----- > From: stable [mailto:stable-bounces@dpdk.org] On Behalf Of Ophir Munk > Sent: Tuesday, November 7, 2017 1:53 PM > To: Wu, Jingjing <jingjing.wu@intel.com> > Cc: Gaetan Rivet <gaetan.rivet@6wind.com>; Ophir Munk > <ophirmu@mellanox.com; dev@dpdk.org; Thomas Monjalon > <thomas@monjalon.net>; Olga Shern <olgas@mellanox.com>; > stable@dpdk.org; Raslan Darawsheh <rasland@mellanox.com> > Subject: [dpdk-stable] [PATCH v2] app/testpmd: fix forwarding between > non consecutive ports > > When defining two failsafe devices in testpmd the port numbers of the > failsafe devices may not be consecutive. > For example: if failsafe device includes a PCI device and a TAP device then > failsafe port numbers would be 0 and 3. > Port 0 - failsafe #1 device > Port 1 - PCI #1 device > Port 2 - TAP #1 device > Port 3 - failsafe #2 device > Port 4 - PCI #2 device > Port 5 - TAP #2 device > > If forwarding is defined between the failsafe devices including a peer > address the forwarding should be between peer addresses of ports 0 and 3. > Instead testpmd establishes forwarding between peer addresses of > consecutive ports 0 and 1. This commit fixes this bug. > > Fixes: af75078fece3 ("first public release") > Cc: stable@dpdk.org > > Signed-off-by: Ophir Munk <ophirmu@mellanox.com> > Signed-off-by: Raslan Darawsheh <rasland@mellanox.com> Acked-by: Pablo de Lara <pablo.de.lara.guarch@intel.com>
07/11/2017 18:43, De Lara Guarch, Pablo: > From: Ophir Munk > > > > When defining two failsafe devices in testpmd the port numbers of the > > failsafe devices may not be consecutive. > > For example: if failsafe device includes a PCI device and a TAP device then > > failsafe port numbers would be 0 and 3. > > Port 0 - failsafe #1 device > > Port 1 - PCI #1 device > > Port 2 - TAP #1 device > > Port 3 - failsafe #2 device > > Port 4 - PCI #2 device > > Port 5 - TAP #2 device > > > > If forwarding is defined between the failsafe devices including a peer > > address the forwarding should be between peer addresses of ports 0 and 3. > > Instead testpmd establishes forwarding between peer addresses of > > consecutive ports 0 and 1. This commit fixes this bug. > > > > Fixes: af75078fece3 ("first public release") > > Cc: stable@dpdk.org > > > > Signed-off-by: Ophir Munk <ophirmu@mellanox.com> > > Signed-off-by: Raslan Darawsheh <rasland@mellanox.com> > > Acked-by: Pablo de Lara <pablo.de.lara.guarch@intel.com> Applied, thanks
diff --git a/app/test-pmd/config.c b/app/test-pmd/config.c index 7bc721f..cd2ac11 100644 --- a/app/test-pmd/config.c +++ b/app/test-pmd/config.c @@ -1905,7 +1905,7 @@ simple_fwd_config_setup(void) fwd_streams[i]->rx_queue = 0; fwd_streams[i]->tx_port = fwd_ports_ids[j]; fwd_streams[i]->tx_queue = 0; - fwd_streams[i]->peer_addr = j; + fwd_streams[i]->peer_addr = fwd_streams[i]->tx_port; fwd_streams[i]->retry_enabled = retry_enabled; if (port_topology == PORT_TOPOLOGY_PAIRED) { @@ -1913,7 +1913,7 @@ simple_fwd_config_setup(void) fwd_streams[j]->rx_queue = 0; fwd_streams[j]->tx_port = fwd_ports_ids[i]; fwd_streams[j]->tx_queue = 0; - fwd_streams[j]->peer_addr = i; + fwd_streams[j]->peer_addr = fwd_streams[j]->tx_port; fwd_streams[j]->retry_enabled = retry_enabled; } }