[dpdk-dev] doc: added inline crypto feature

  Signed-off-by: Radu Nicolau <radu.nicolau@intel.com>
---
 doc/guides/nics/features.rst              | 17 +++++++++++++++++
 doc/guides/nics/features/default.ini      |  1 +
 doc/guides/nics/features/ixgbe.ini        |  2 ++
 doc/guides/nics/features/ixgbe_vec.ini    |  2 ++
 doc/guides/nics/features/ixgbe_vf.ini     |  2 ++
 doc/guides/nics/features/ixgbe_vf_vec.ini |  2 ++
 6 files changed, 26 insertions(+)
  

Hi,

08/11/2017 14:26, Radu Nicolau:
> --- a/doc/guides/nics/features.rst
> +++ b/doc/guides/nics/features.rst
> @@ -900,6 +900,23 @@ Documentation describes performance values.
>  See ``dpdk.org/doc/perf/*``.
>  
>  
> +.. _nic_features_inline_crypto_doc:

This anchor seems useless.

> +
> +Inline crypto
> +-------------
> +
> +Supports inline crypto processing (eg. inline IPsec). See Security library for more details.

As there are several types of inline crypto, don't you think it deserves
several separate features?
  

On 11/8/2017 2:22 PM, Thomas Monjalon wrote:
> Hi,
>
> 08/11/2017 14:26, Radu Nicolau:
>> --- a/doc/guides/nics/features.rst
>> +++ b/doc/guides/nics/features.rst
>> @@ -900,6 +900,23 @@ Documentation describes performance values.
>>   See ``dpdk.org/doc/perf/*``.
>>   
>>   
>> +.. _nic_features_inline_crypto_doc:
> This anchor seems useless.
It is, I will remove it.
>
>> +
>> +Inline crypto
>> +-------------
>> +
>> +Supports inline crypto processing (eg. inline IPsec). See Security library for more details.
> As there are several types of inline crypto, don't you think it deserves
> several separate features?
We don't differentiate in the offload, net, mbuf APIs; it's all 
"security offload".
rte_security is the one that deals with different kinds of inline 
crypto, but in the NIC section it's all the same.
  

08/11/2017 15:31, Radu Nicolau:
> On 11/8/2017 2:22 PM, Thomas Monjalon wrote:
> > 08/11/2017 14:26, Radu Nicolau:
> >> +
> >> +Inline crypto
> >> +-------------
> >> +
> >> +Supports inline crypto processing (eg. inline IPsec). See Security library for more details.
> > 
> > As there are several types of inline crypto, don't you think it deserves
> > several separate features?
> 
> We don't differentiate in the offload, net, mbuf APIs; it's all 
> "security offload".
> rte_security is the one that deals with different kinds of inline 
> crypto, but in the NIC section it's all the same.

OK
How can we document which kind of inline crypto is supported with which device?
  

On 11/8/2017 3:13 PM, Thomas Monjalon wrote:
> 08/11/2017 15:31, Radu Nicolau:
>> On 11/8/2017 2:22 PM, Thomas Monjalon wrote:
>>> 08/11/2017 14:26, Radu Nicolau:
>>>> +
>>>> +Inline crypto
>>>> +-------------
>>>> +
>>>> +Supports inline crypto processing (eg. inline IPsec). See Security library for more details.
>>> As there are several types of inline crypto, don't you think it deserves
>>> several separate features?
>> We don't differentiate in the offload, net, mbuf APIs; it's all
>> "security offload".
>> rte_security is the one that deals with different kinds of inline
>> crypto, but in the NIC section it's all the same.
> OK
> How can we document which kind of inline crypto is supported with which device?
I propose to change "See Security library for more details" to "See 
Security library and PMD documentation for more details" and update 
ixgbe.rst with an "inline crypto" section.