diff mbox

[dpdk-dev,36/53] net/sfc/base: run mkconfig.py to add a new sensors

Message ID 1510819481-6809-37-git-send-email-arybchenko@solarflare.com (mailing list archive)
State Accepted, archived
Delegated to: Ferruh Yigit
Headers

Checks

Context Check Description
ci/checkpatch success coding style OK
ci/Intel-compilation success Compilation OK

Commit Message

Andrew Rybchenko Nov. 16, 2017, 8:04 a.m. UTC 
  From: Andy Moreton <amoreton@solarflare.com>

Signed-off-by: Andy Moreton <amoreton@solarflare.com>
Signed-off-by: Andrew Rybchenko <arybchenko@solarflare.com>
---
 drivers/net/sfc/base/efx.h     | 4 +++-
 drivers/net/sfc/base/efx_mon.c | 4 +++-
 2 files changed, 6 insertions(+), 2 deletions(-)

Comments

Ferruh Yigit Nov. 27, 2017, 7:58 p.m. UTC | #1 
On 11/16/2017 12:04 AM, Andrew Rybchenko wrote:
> From: Andy Moreton <amoreton@solarflare.com>

We don't know what mkconfig.py is and most probably not interested in :) This
looks like your internal detail, more interesting is the effect of this change,
like "add new sensors".

btw, just out of curiosity, what sensors are they?

> 
> Signed-off-by: Andy Moreton <amoreton@solarflare.com>
> Signed-off-by: Andrew Rybchenko <arybchenko@solarflare.com>
> ---
>  drivers/net/sfc/base/efx.h     | 4 +++-
>  drivers/net/sfc/base/efx_mon.c | 4 +++-
>  2 files changed, 6 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/net/sfc/base/efx.h b/drivers/net/sfc/base/efx.h
> index df1594e..b809819 100644
> --- a/drivers/net/sfc/base/efx.h
> +++ b/drivers/net/sfc/base/efx.h
> @@ -627,7 +627,7 @@ efx_mon_init(
>  #define	EFX_MON_STATS_PAGE_SIZE 0x100
>  #define	EFX_MON_MASK_ELEMENT_SIZE 32
>  
> -/* START MKCONFIG GENERATED MonitorHeaderStatsBlock 5d4ee5185e419abe */
> +/* START MKCONFIG GENERATED MonitorHeaderStatsBlock aa0233c80156308e */
>  typedef enum efx_mon_stat_e {
>  	EFX_MON_STAT_2_5V,
>  	EFX_MON_STAT_VCCP1,
> @@ -706,6 +706,8 @@ typedef enum efx_mon_stat_e {
>  	EFX_MON_STAT_CONTROLLER_TDIODE_TEMP,
>  	EFX_MON_STAT_BOARD_FRONT_TEMP,
>  	EFX_MON_STAT_BOARD_BACK_TEMP,
> +	EFX_MON_STAT_I1V8,
> +	EFX_MON_STAT_I2V5,
>  	EFX_MON_NSTATS
>  } efx_mon_stat_t;
>  
> diff --git a/drivers/net/sfc/base/efx_mon.c b/drivers/net/sfc/base/efx_mon.c
> index c2f1e97..6074760 100644
> --- a/drivers/net/sfc/base/efx_mon.c
> +++ b/drivers/net/sfc/base/efx_mon.c
> @@ -123,7 +123,7 @@ efx_mon_init(
>  
>  #if EFSYS_OPT_NAMES
>  
> -/* START MKCONFIG GENERATED MonitorStatNamesBlock 5daa2a5725ba734b */
> +/* START MKCONFIG GENERATED MonitorStatNamesBlock d92af1538001301f */
>  static const char * const __mon_stat_name[] = {
>  	"value_2_5v",
>  	"value_vccp1",
> @@ -202,6 +202,8 @@ static const char * const __mon_stat_name[] = {
>  	"controller_tdiode_temp",
>  	"board_front_temp",
>  	"board_back_temp",
> +	"i1v8",
> +	"i2v5",
>  };
>  
>  /* END MKCONFIG GENERATED MonitorStatNamesBlock */
>
Andrew Rybchenko Nov. 28, 2017, 12:01 p.m. UTC | #2 
On 11/27/2017 10:58 PM, Ferruh Yigit wrote:
> On 11/16/2017 12:04 AM, Andrew Rybchenko wrote:
>> From: Andy Moreton <amoreton@solarflare.com>
> We don't know what mkconfig.py is and most probably not interested in :) This
> looks like your internal detail, more interesting is the effect of this change,
> like "add new sensors".

Yes. I'll adjust similar patches in the future.

> btw, just out of curiosity, what sensors are they?

It is current (mA) sensors for 1.8 V and 2.5 V power supplies used on
some boards.

Andrew.

>> Signed-off-by: Andy Moreton <amoreton@solarflare.com>
>> Signed-off-by: Andrew Rybchenko <arybchenko@solarflare.com>
>> ---
>>   drivers/net/sfc/base/efx.h     | 4 +++-
>>   drivers/net/sfc/base/efx_mon.c | 4 +++-
>>   2 files changed, 6 insertions(+), 2 deletions(-)
>>
>> diff --git a/drivers/net/sfc/base/efx.h b/drivers/net/sfc/base/efx.h
>> index df1594e..b809819 100644
>> --- a/drivers/net/sfc/base/efx.h
>> +++ b/drivers/net/sfc/base/efx.h
>> @@ -627,7 +627,7 @@ efx_mon_init(
>>   #define	EFX_MON_STATS_PAGE_SIZE 0x100
>>   #define	EFX_MON_MASK_ELEMENT_SIZE 32
>>   
>> -/* START MKCONFIG GENERATED MonitorHeaderStatsBlock 5d4ee5185e419abe */
>> +/* START MKCONFIG GENERATED MonitorHeaderStatsBlock aa0233c80156308e */
>>   typedef enum efx_mon_stat_e {
>>   	EFX_MON_STAT_2_5V,
>>   	EFX_MON_STAT_VCCP1,
>> @@ -706,6 +706,8 @@ typedef enum efx_mon_stat_e {
>>   	EFX_MON_STAT_CONTROLLER_TDIODE_TEMP,
>>   	EFX_MON_STAT_BOARD_FRONT_TEMP,
>>   	EFX_MON_STAT_BOARD_BACK_TEMP,
>> +	EFX_MON_STAT_I1V8,
>> +	EFX_MON_STAT_I2V5,
>>   	EFX_MON_NSTATS
>>   } efx_mon_stat_t;
>>   
>> diff --git a/drivers/net/sfc/base/efx_mon.c b/drivers/net/sfc/base/efx_mon.c
>> index c2f1e97..6074760 100644
>> --- a/drivers/net/sfc/base/efx_mon.c
>> +++ b/drivers/net/sfc/base/efx_mon.c
>> @@ -123,7 +123,7 @@ efx_mon_init(
>>   
>>   #if EFSYS_OPT_NAMES
>>   
>> -/* START MKCONFIG GENERATED MonitorStatNamesBlock 5daa2a5725ba734b */
>> +/* START MKCONFIG GENERATED MonitorStatNamesBlock d92af1538001301f */
>>   static const char * const __mon_stat_name[] = {
>>   	"value_2_5v",
>>   	"value_vccp1",
>> @@ -202,6 +202,8 @@ static const char * const __mon_stat_name[] = {
>>   	"controller_tdiode_temp",
>>   	"board_front_temp",
>>   	"board_back_temp",
>> +	"i1v8",
>> +	"i2v5",
>>   };
>>   
>>   /* END MKCONFIG GENERATED MonitorStatNamesBlock */
>>
diff mbox

Patch

diff --git a/drivers/net/sfc/base/efx.h b/drivers/net/sfc/base/efx.h
index df1594e..b809819 100644
--- a/drivers/net/sfc/base/efx.h
+++ b/drivers/net/sfc/base/efx.h
@@ -627,7 +627,7 @@  efx_mon_init(
 #define	EFX_MON_STATS_PAGE_SIZE 0x100
 #define	EFX_MON_MASK_ELEMENT_SIZE 32
 
-/* START MKCONFIG GENERATED MonitorHeaderStatsBlock 5d4ee5185e419abe */
+/* START MKCONFIG GENERATED MonitorHeaderStatsBlock aa0233c80156308e */
 typedef enum efx_mon_stat_e {
 	EFX_MON_STAT_2_5V,
 	EFX_MON_STAT_VCCP1,
@@ -706,6 +706,8 @@  typedef enum efx_mon_stat_e {
 	EFX_MON_STAT_CONTROLLER_TDIODE_TEMP,
 	EFX_MON_STAT_BOARD_FRONT_TEMP,
 	EFX_MON_STAT_BOARD_BACK_TEMP,
+	EFX_MON_STAT_I1V8,
+	EFX_MON_STAT_I2V5,
 	EFX_MON_NSTATS
 } efx_mon_stat_t;
 
diff --git a/drivers/net/sfc/base/efx_mon.c b/drivers/net/sfc/base/efx_mon.c
index c2f1e97..6074760 100644
--- a/drivers/net/sfc/base/efx_mon.c
+++ b/drivers/net/sfc/base/efx_mon.c
@@ -123,7 +123,7 @@  efx_mon_init(
 
 #if EFSYS_OPT_NAMES
 
-/* START MKCONFIG GENERATED MonitorStatNamesBlock 5daa2a5725ba734b */
+/* START MKCONFIG GENERATED MonitorStatNamesBlock d92af1538001301f */
 static const char * const __mon_stat_name[] = {
 	"value_2_5v",
 	"value_vccp1",
@@ -202,6 +202,8 @@  static const char * const __mon_stat_name[] = {
 	"controller_tdiode_temp",
 	"board_front_temp",
 	"board_back_temp",
+	"i1v8",
+	"i2v5",
 };
 
 /* END MKCONFIG GENERATED MonitorStatNamesBlock */