diff mbox

[dpdk-dev] app/testpmd: Remove xenvirt again

Message ID 36c7fe6e58f1999a16950bfbf6911163957b46af.1510929617.git.tredaelli@redhat.com (mailing list archive)
State Accepted, archived
Delegated to: Thomas Monjalon
Headers

Checks

Context Check Description
ci/checkpatch success coding style OK
ci/Intel-compilation success Compilation OK

Commit Message

Timothy Redaelli Nov. 17, 2017, 2:40 p.m. UTC 
  Fixes: 5b590fbe09b6 ("app/testpmd: add traffic management forwarding mode")

Signed-off-by: Timothy Redaelli <tredaelli@redhat.com>
---
 app/test-pmd/Makefile | 4 ----
 1 file changed, 4 deletions(-)

Comments

Luca Boccassi Nov. 17, 2017, 4:44 p.m. UTC | #1 
On Fri, 2017-11-17 at 15:40 +0100, Timothy Redaelli wrote:
> Fixes: 5b590fbe09b6 ("app/testpmd: add traffic management forwarding
> mode")
> 
> Signed-off-by: Timothy Redaelli <tredaelli@redhat.com>
> ---
>  app/test-pmd/Makefile | 4 ----
>  1 file changed, 4 deletions(-)
> 
> diff --git a/app/test-pmd/Makefile b/app/test-pmd/Makefile
> index d21308fcd..4993c9184 100644
> --- a/app/test-pmd/Makefile
> +++ b/app/test-pmd/Makefile
> @@ -83,10 +83,6 @@ ifeq ($(CONFIG_RTE_LIBRTE_BNXT_PMD),y)
>  LDLIBS += -lrte_pmd_bnxt
>  endif
>  
> -ifeq ($(CONFIG_RTE_LIBRTE_PMD_XENVIRT),y)
> -LDLIBS += -lrte_pmd_xenvirt
> -endif
> -
>  ifeq ($(CONFIG_RTE_LIBRTE_PMD_SOFTNIC),y)
>  LDLIBS += -lrte_pmd_softnic
>  endif

Acked-by: <bluca@debian.org>
Eelco Chaudron Nov. 20, 2017, 10:27 a.m. UTC | #2 
On 17/11/17 15:40, Timothy Redaelli wrote:
> Fixes: 5b590fbe09b6 ("app/testpmd: add traffic management forwarding mode")
>
> Signed-off-by: Timothy Redaelli <tredaelli@redhat.com>
> ---
>   app/test-pmd/Makefile | 4 ----
>   1 file changed, 4 deletions(-)
>
> diff --git a/app/test-pmd/Makefile b/app/test-pmd/Makefile
> index d21308fcd..4993c9184 100644
> --- a/app/test-pmd/Makefile
> +++ b/app/test-pmd/Makefile
> @@ -83,10 +83,6 @@ ifeq ($(CONFIG_RTE_LIBRTE_BNXT_PMD),y)
>   LDLIBS += -lrte_pmd_bnxt
>   endif
>   
> -ifeq ($(CONFIG_RTE_LIBRTE_PMD_XENVIRT),y)
> -LDLIBS += -lrte_pmd_xenvirt
> -endif
> -
>   ifeq ($(CONFIG_RTE_LIBRTE_PMD_SOFTNIC),y)
>   LDLIBS += -lrte_pmd_softnic
>   endif


Acked-by: Eelco Chaudron <echaudro@redhat.com>
Thomas Monjalon Dec. 15, 2017, 2:13 p.m. UTC | #3 
17/11/2017 17:44, Luca Boccassi:
> On Fri, 2017-11-17 at 15:40 +0100, Timothy Redaelli wrote:
> > Fixes: 5b590fbe09b6 ("app/testpmd: add traffic management forwarding
> > mode")
> > 
> > Signed-off-by: Timothy Redaelli <tredaelli@redhat.com>
> 
> Acked-by: <bluca@debian.org>

Applied with this explanation:
	The xenvirt PMD was removed from 17.11
	while this link parameter was added.
diff mbox

Patch

diff --git a/app/test-pmd/Makefile b/app/test-pmd/Makefile
index d21308fcd..4993c9184 100644
--- a/app/test-pmd/Makefile
+++ b/app/test-pmd/Makefile
@@ -83,10 +83,6 @@  ifeq ($(CONFIG_RTE_LIBRTE_BNXT_PMD),y)
 LDLIBS += -lrte_pmd_bnxt
 endif
 
-ifeq ($(CONFIG_RTE_LIBRTE_PMD_XENVIRT),y)
-LDLIBS += -lrte_pmd_xenvirt
-endif
-
 ifeq ($(CONFIG_RTE_LIBRTE_PMD_SOFTNIC),y)
 LDLIBS += -lrte_pmd_softnic
 endif