[dpdk-dev,2/6] doc: add mbuf reorg to PMD todo list
Checks
Commit Message
To track modification:
8f094a9ac5d7 ("mbuf: set mbuf fields while in pool")
Proposed deadline for PMDs is v18.02
Signed-off-by: Ferruh Yigit <ferruh.yigit@intel.com>
---
doc/guides/nics/todo.rst | 19 ++++++++++++++-----
1 file changed, 14 insertions(+), 5 deletions(-)
Comments
On 21/11/2017 01:42, Ferruh Yigit wrote:
> To track modification:
> 8f094a9ac5d7 ("mbuf: set mbuf fields while in pool")
>
> Proposed deadline for PMDs is v18.02
>
> Signed-off-by: Ferruh Yigit <ferruh.yigit@intel.com>
>
Acked-by:Marko Kovacevic<marko.kovacevic@intel.com>
> -----Original Message-----
> From: Yigit, Ferruh
> Sent: Tuesday, November 21, 2017 1:43 AM
> To: Thomas Monjalon <thomas@monjalon.net>; Mcnamara, John
> <john.mcnamara@intel.com>
> Cc: dev@dpdk.org; Yigit, Ferruh <ferruh.yigit@intel.com>
> Subject: [PATCH 2/6] doc: add mbuf reorg to PMD todo list
>
> To track modification:
> 8f094a9ac5d7 ("mbuf: set mbuf fields while in pool")
>
> Proposed deadline for PMDs is v18.02
>
> Signed-off-by: Ferruh Yigit <ferruh.yigit@intel.com>
Acked-by: John McNamara <john.mcnamara@intel.com>
On 11/21/2017 04:42 AM, Ferruh Yigit wrote:
> To track modification:
> 8f094a9ac5d7 ("mbuf: set mbuf fields while in pool")
>
> Proposed deadline for PMDs is v18.02
>
> Signed-off-by: Ferruh Yigit <ferruh.yigit@intel.com>
> ---
> doc/guides/nics/todo.rst | 19 ++++++++++++++-----
> 1 file changed, 14 insertions(+), 5 deletions(-)
>
> diff --git a/doc/guides/nics/todo.rst b/doc/guides/nics/todo.rst
> index 874811ad5..b408fc691 100644
> --- a/doc/guides/nics/todo.rst
> +++ b/doc/guides/nics/todo.rst
> @@ -36,8 +36,17 @@ This is the list for tracking required PMD changes triggered by library modifica
>
> .. table:: PMDs internal TODO list
>
> - +------+------+----------+----------------+------+
> - | TODO | PMDs | Deadline | Related Commit | Note |
> - +======+======+==========+================+======+
> - | | | | | |
> - +------+------+----------+----------------+------+
> + +-------------------+--------------------------------+----------+----------------+-----------------------------------+
> + | TODO | PMDs | Deadline | Related Commit | Note |
> + +===================+================================+==========+================+===================================+
> + | mbuf organisation | | af_packet, ark, avp, bnx2x, | v18.02 | 8f094a9ac5d7 | Remove unnecessary mbuf field |
> + | | | bnxt, bonding, cxgbe, dpaa, | | | initialization. |
> + | | | dpaa2, e1000, ena, | | | |
> + | | | failsafe, fm10k, | | | |
> + | | | kni, mlx4, | | | |
> + | | | mrvl, nfp, octeontx, | | | |
> + | | | pcap, qede, ring, sfc, | | | |
> + | | | softnic, szedata2, tap, | | | |
> + | | | thunderx, vhost, | | | |
> + | | | vmxnet3 | | | |
> + +-------------------+--------------------------------+----------+----------------+-----------------------------------+
sfc may be removed from the list since it has already been done.
Reference counter and number of segments are still set as part
of 64-bit rearm data, but I think it is rather a question of separate
performance investigation and optimization.
Of course, we can send a patch to remove from todo list with
explanations why.
On Tue, 21 Nov 2017 01:42:37 +0000
Ferruh Yigit <ferruh.yigit@intel.com> wrote:
> To track modification:
> 8f094a9ac5d7 ("mbuf: set mbuf fields while in pool")
>
> Proposed deadline for PMDs is v18.02
>
> Signed-off-by: Ferruh Yigit <ferruh.yigit@intel.com>
> ---
> doc/guides/nics/todo.rst | 19 ++++++++++++++-----
> 1 file changed, 14 insertions(+), 5 deletions(-)
>
> diff --git a/doc/guides/nics/todo.rst b/doc/guides/nics/todo.rst
> index 874811ad5..b408fc691 100644
> --- a/doc/guides/nics/todo.rst
> +++ b/doc/guides/nics/todo.rst
> @@ -36,8 +36,17 @@ This is the list for tracking required PMD changes triggered by library modifica
>
> .. table:: PMDs internal TODO list
>
> - +------+------+----------+----------------+------+
> - | TODO | PMDs | Deadline | Related Commit | Note |
> - +======+======+==========+================+======+
> - | | | | | |
> - +------+------+----------+----------------+------+
> + +-------------------+--------------------------------+----------+----------------+-----------------------------------+
> + | TODO | PMDs | Deadline | Related Commit | Note |
> + +===================+================================+==========+================+===================================+
> + | mbuf organisation | | af_packet, ark, avp, bnx2x, | v18.02 | 8f094a9ac5d7 | Remove unnecessary mbuf field |
> + | | | bnxt, bonding, cxgbe, dpaa, | | | initialization. |
> + | | | dpaa2, e1000, ena, | | | |
> + | | | failsafe, fm10k, | | | |
> + | | | kni, mlx4, | | | |
> + | | | mrvl, nfp, octeontx, | | | |
> + | | | pcap, qede, ring, sfc, | | | |
> + | | | softnic, szedata2, tap, | | | |
> + | | | thunderx, vhost, | | | |
> + | | | vmxnet3 | | | |
> + +-------------------+--------------------------------+----------+----------------+-----------------------------------+
NAK
This open source, if the fix is trivial please just fix all the drivers directly now.
These TODO lists never get done.
Hi,
On Fri, Dec 29, 2017 at 09:07:49AM -0800, Stephen Hemminger wrote:
> On Tue, 21 Nov 2017 01:42:37 +0000
> Ferruh Yigit <ferruh.yigit@intel.com> wrote:
>
> > To track modification:
> > 8f094a9ac5d7 ("mbuf: set mbuf fields while in pool")
> >
> > Proposed deadline for PMDs is v18.02
> >
> > Signed-off-by: Ferruh Yigit <ferruh.yigit@intel.com>
> > ---
> > doc/guides/nics/todo.rst | 19 ++++++++++++++-----
> > 1 file changed, 14 insertions(+), 5 deletions(-)
> >
> > diff --git a/doc/guides/nics/todo.rst b/doc/guides/nics/todo.rst
> > index 874811ad5..b408fc691 100644
> > --- a/doc/guides/nics/todo.rst
> > +++ b/doc/guides/nics/todo.rst
> > @@ -36,8 +36,17 @@ This is the list for tracking required PMD changes triggered by library modifica
> >
> > .. table:: PMDs internal TODO list
> >
> > - +------+------+----------+----------------+------+
> > - | TODO | PMDs | Deadline | Related Commit | Note |
> > - +======+======+==========+================+======+
> > - | | | | | |
> > - +------+------+----------+----------------+------+
> > + +-------------------+--------------------------------+----------+----------------+-----------------------------------+
> > + | TODO | PMDs | Deadline | Related Commit | Note |
> > + +===================+================================+==========+================+===================================+
> > + | mbuf organisation | | af_packet, ark, avp, bnx2x, | v18.02 | 8f094a9ac5d7 | Remove unnecessary mbuf field |
> > + | | | bnxt, bonding, cxgbe, dpaa, | | | initialization. |
> > + | | | dpaa2, e1000, ena, | | | |
> > + | | | failsafe, fm10k, | | | |
> > + | | | kni, mlx4, | | | |
> > + | | | mrvl, nfp, octeontx, | | | |
> > + | | | pcap, qede, ring, sfc, | | | |
> > + | | | softnic, szedata2, tap, | | | |
> > + | | | thunderx, vhost, | | | |
> > + | | | vmxnet3 | | | |
> > + +-------------------+--------------------------------+----------+----------------+-----------------------------------+
>
> NAK
>
> This open source, if the fix is trivial please just fix all the drivers directly now.
> These TODO lists never get done.
The fix is not that trivial, especially for vector PMDs.
It can also impact performance.
It looks dangerous for me to blindly do a patch without any hardware to
do the test.
@@ -36,8 +36,17 @@ This is the list for tracking required PMD changes triggered by library modifica
.. table:: PMDs internal TODO list
- +------+------+----------+----------------+------+
- | TODO | PMDs | Deadline | Related Commit | Note |
- +======+======+==========+================+======+
- | | | | | |
- +------+------+----------+----------------+------+
+ +-------------------+--------------------------------+----------+----------------+-----------------------------------+
+ | TODO | PMDs | Deadline | Related Commit | Note |
+ +===================+================================+==========+================+===================================+
+ | mbuf organisation | | af_packet, ark, avp, bnx2x, | v18.02 | 8f094a9ac5d7 | Remove unnecessary mbuf field |
+ | | | bnxt, bonding, cxgbe, dpaa, | | | initialization. |
+ | | | dpaa2, e1000, ena, | | | |
+ | | | failsafe, fm10k, | | | |
+ | | | kni, mlx4, | | | |
+ | | | mrvl, nfp, octeontx, | | | |
+ | | | pcap, qede, ring, sfc, | | | |
+ | | | softnic, szedata2, tap, | | | |
+ | | | thunderx, vhost, | | | |
+ | | | vmxnet3 | | | |
+ +-------------------+--------------------------------+----------+----------------+-----------------------------------+