diff mbox

[dpdk-dev,2/6] doc: add mbuf reorg to PMD todo list

Message ID 20171121014241.61050-2-ferruh.yigit@intel.com (mailing list archive)
State Rejected, archived
Delegated to: Ferruh Yigit
Headers

Checks

Context Check Description
ci/checkpatch warning coding style issues
ci/Intel-compilation success Compilation OK

Commit Message

Ferruh Yigit Nov. 21, 2017, 1:42 a.m. UTC 
  To track modification:
8f094a9ac5d7 ("mbuf: set mbuf fields while in pool")

Proposed deadline for PMDs is v18.02

Signed-off-by: Ferruh Yigit <ferruh.yigit@intel.com>
---
 doc/guides/nics/todo.rst | 19 ++++++++++++++-----
 1 file changed, 14 insertions(+), 5 deletions(-)

Comments

Kovacevic, Marko Dec. 11, 2017, 2 p.m. UTC | #1 
On 21/11/2017 01:42, Ferruh Yigit wrote:
> To track modification:
> 8f094a9ac5d7 ("mbuf: set mbuf fields while in pool")
>
> Proposed deadline for PMDs is v18.02
>
> Signed-off-by: Ferruh Yigit <ferruh.yigit@intel.com>
>
Acked-by:Marko Kovacevic<marko.kovacevic@intel.com>
John McNamara Dec. 11, 2017, 2:09 p.m. UTC | #2 
> -----Original Message-----
> From: Yigit, Ferruh
> Sent: Tuesday, November 21, 2017 1:43 AM
> To: Thomas Monjalon <thomas@monjalon.net>; Mcnamara, John
> <john.mcnamara@intel.com>
> Cc: dev@dpdk.org; Yigit, Ferruh <ferruh.yigit@intel.com>
> Subject: [PATCH 2/6] doc: add mbuf reorg to PMD todo list
> 
> To track modification:
> 8f094a9ac5d7 ("mbuf: set mbuf fields while in pool")
> 
> Proposed deadline for PMDs is v18.02
> 
> Signed-off-by: Ferruh Yigit <ferruh.yigit@intel.com>

Acked-by: John McNamara <john.mcnamara@intel.com>
Andrew Rybchenko Dec. 29, 2017, 11:58 a.m. UTC | #3 
On 11/21/2017 04:42 AM, Ferruh Yigit wrote:
> To track modification:
> 8f094a9ac5d7 ("mbuf: set mbuf fields while in pool")
>
> Proposed deadline for PMDs is v18.02
>
> Signed-off-by: Ferruh Yigit <ferruh.yigit@intel.com>
> ---
>   doc/guides/nics/todo.rst | 19 ++++++++++++++-----
>   1 file changed, 14 insertions(+), 5 deletions(-)
>
> diff --git a/doc/guides/nics/todo.rst b/doc/guides/nics/todo.rst
> index 874811ad5..b408fc691 100644
> --- a/doc/guides/nics/todo.rst
> +++ b/doc/guides/nics/todo.rst
> @@ -36,8 +36,17 @@ This is the list for tracking required PMD changes triggered by library modifica
>   
>   .. table:: PMDs internal TODO list
>   
> - +------+------+----------+----------------+------+
> - | TODO | PMDs | Deadline | Related Commit | Note |
> - +======+======+==========+================+======+
> - |      |      |          |                |      |
> - +------+------+----------+----------------+------+
> + +-------------------+--------------------------------+----------+----------------+-----------------------------------+
> + | TODO              | PMDs                           | Deadline | Related Commit | Note                              |
> + +===================+================================+==========+================+===================================+
> + | mbuf organisation | | af_packet, ark, avp, bnx2x,  | v18.02   | 8f094a9ac5d7   | Remove unnecessary mbuf field     |
> + |                   | | bnxt, bonding, cxgbe, dpaa,  |          |                | initialization.                   |
> + |                   | | dpaa2, e1000, ena,           |          |                |                                   |
> + |                   | | failsafe, fm10k,             |          |                |                                   |
> + |                   | | kni, mlx4,                   |          |                |                                   |
> + |                   | | mrvl, nfp, octeontx,         |          |                |                                   |
> + |                   | | pcap, qede, ring, sfc,       |          |                |                                   |
> + |                   | | softnic, szedata2, tap,      |          |                |                                   |
> + |                   | | thunderx, vhost,             |          |                |                                   |
> + |                   | | vmxnet3                      |          |                |                                   |
> + +-------------------+--------------------------------+----------+----------------+-----------------------------------+

sfc may be removed from the list since it has already been done.
Reference counter and number of segments are still set as part
of 64-bit rearm data, but I think it is rather a question of separate
performance investigation and optimization.
Of course, we can send a patch to remove from todo list with
explanations why.
Stephen Hemminger Dec. 29, 2017, 5:07 p.m. UTC | #4 
On Tue, 21 Nov 2017 01:42:37 +0000
Ferruh Yigit <ferruh.yigit@intel.com> wrote:

> To track modification:
> 8f094a9ac5d7 ("mbuf: set mbuf fields while in pool")
> 
> Proposed deadline for PMDs is v18.02
> 
> Signed-off-by: Ferruh Yigit <ferruh.yigit@intel.com>
> ---
>  doc/guides/nics/todo.rst | 19 ++++++++++++++-----
>  1 file changed, 14 insertions(+), 5 deletions(-)
> 
> diff --git a/doc/guides/nics/todo.rst b/doc/guides/nics/todo.rst
> index 874811ad5..b408fc691 100644
> --- a/doc/guides/nics/todo.rst
> +++ b/doc/guides/nics/todo.rst
> @@ -36,8 +36,17 @@ This is the list for tracking required PMD changes triggered by library modifica
>  
>  .. table:: PMDs internal TODO list
>  
> - +------+------+----------+----------------+------+
> - | TODO | PMDs | Deadline | Related Commit | Note |
> - +======+======+==========+================+======+
> - |      |      |          |                |      |
> - +------+------+----------+----------------+------+
> + +-------------------+--------------------------------+----------+----------------+-----------------------------------+
> + | TODO              | PMDs                           | Deadline | Related Commit | Note                              |
> + +===================+================================+==========+================+===================================+
> + | mbuf organisation | | af_packet, ark, avp, bnx2x,  | v18.02   | 8f094a9ac5d7   | Remove unnecessary mbuf field     |
> + |                   | | bnxt, bonding, cxgbe, dpaa,  |          |                | initialization.                   |
> + |                   | | dpaa2, e1000, ena,           |          |                |                                   |
> + |                   | | failsafe, fm10k,             |          |                |                                   |
> + |                   | | kni, mlx4,                   |          |                |                                   |
> + |                   | | mrvl, nfp, octeontx,         |          |                |                                   |
> + |                   | | pcap, qede, ring, sfc,       |          |                |                                   |
> + |                   | | softnic, szedata2, tap,      |          |                |                                   |
> + |                   | | thunderx, vhost,             |          |                |                                   |
> + |                   | | vmxnet3                      |          |                |                                   |
> + +-------------------+--------------------------------+----------+----------------+-----------------------------------+

NAK

This open source, if the fix is trivial please just fix all the drivers directly now.
These TODO lists never get done.
Olivier Matz Jan. 3, 2018, 2 p.m. UTC | #5 
Hi,

On Fri, Dec 29, 2017 at 09:07:49AM -0800, Stephen Hemminger wrote:
> On Tue, 21 Nov 2017 01:42:37 +0000
> Ferruh Yigit <ferruh.yigit@intel.com> wrote:
> 
> > To track modification:
> > 8f094a9ac5d7 ("mbuf: set mbuf fields while in pool")
> > 
> > Proposed deadline for PMDs is v18.02
> > 
> > Signed-off-by: Ferruh Yigit <ferruh.yigit@intel.com>
> > ---
> >  doc/guides/nics/todo.rst | 19 ++++++++++++++-----
> >  1 file changed, 14 insertions(+), 5 deletions(-)
> > 
> > diff --git a/doc/guides/nics/todo.rst b/doc/guides/nics/todo.rst
> > index 874811ad5..b408fc691 100644
> > --- a/doc/guides/nics/todo.rst
> > +++ b/doc/guides/nics/todo.rst
> > @@ -36,8 +36,17 @@ This is the list for tracking required PMD changes triggered by library modifica
> >  
> >  .. table:: PMDs internal TODO list
> >  
> > - +------+------+----------+----------------+------+
> > - | TODO | PMDs | Deadline | Related Commit | Note |
> > - +======+======+==========+================+======+
> > - |      |      |          |                |      |
> > - +------+------+----------+----------------+------+
> > + +-------------------+--------------------------------+----------+----------------+-----------------------------------+
> > + | TODO              | PMDs                           | Deadline | Related Commit | Note                              |
> > + +===================+================================+==========+================+===================================+
> > + | mbuf organisation | | af_packet, ark, avp, bnx2x,  | v18.02   | 8f094a9ac5d7   | Remove unnecessary mbuf field     |
> > + |                   | | bnxt, bonding, cxgbe, dpaa,  |          |                | initialization.                   |
> > + |                   | | dpaa2, e1000, ena,           |          |                |                                   |
> > + |                   | | failsafe, fm10k,             |          |                |                                   |
> > + |                   | | kni, mlx4,                   |          |                |                                   |
> > + |                   | | mrvl, nfp, octeontx,         |          |                |                                   |
> > + |                   | | pcap, qede, ring, sfc,       |          |                |                                   |
> > + |                   | | softnic, szedata2, tap,      |          |                |                                   |
> > + |                   | | thunderx, vhost,             |          |                |                                   |
> > + |                   | | vmxnet3                      |          |                |                                   |
> > + +-------------------+--------------------------------+----------+----------------+-----------------------------------+
> 
> NAK
> 
> This open source, if the fix is trivial please just fix all the drivers directly now.
> These TODO lists never get done.

The fix is not that trivial, especially for vector PMDs.
It can also impact performance.

It looks dangerous for me to blindly do a patch without any hardware to
do the test.
diff mbox

Patch

diff --git a/doc/guides/nics/todo.rst b/doc/guides/nics/todo.rst
index 874811ad5..b408fc691 100644
--- a/doc/guides/nics/todo.rst
+++ b/doc/guides/nics/todo.rst
@@ -36,8 +36,17 @@  This is the list for tracking required PMD changes triggered by library modifica
 
 .. table:: PMDs internal TODO list
 
- +------+------+----------+----------------+------+
- | TODO | PMDs | Deadline | Related Commit | Note |
- +======+======+==========+================+======+
- |      |      |          |                |      |
- +------+------+----------+----------------+------+
+ +-------------------+--------------------------------+----------+----------------+-----------------------------------+
+ | TODO              | PMDs                           | Deadline | Related Commit | Note                              |
+ +===================+================================+==========+================+===================================+
+ | mbuf organisation | | af_packet, ark, avp, bnx2x,  | v18.02   | 8f094a9ac5d7   | Remove unnecessary mbuf field     |
+ |                   | | bnxt, bonding, cxgbe, dpaa,  |          |                | initialization.                   |
+ |                   | | dpaa2, e1000, ena,           |          |                |                                   |
+ |                   | | failsafe, fm10k,             |          |                |                                   |
+ |                   | | kni, mlx4,                   |          |                |                                   |
+ |                   | | mrvl, nfp, octeontx,         |          |                |                                   |
+ |                   | | pcap, qede, ring, sfc,       |          |                |                                   |
+ |                   | | softnic, szedata2, tap,      |          |                |                                   |
+ |                   | | thunderx, vhost,             |          |                |                                   |
+ |                   | | vmxnet3                      |          |                |                                   |
+ +-------------------+--------------------------------+----------+----------------+-----------------------------------+