[dpdk-dev,5/6] doc: add offload flag to PMD todo list

Message ID 20171121014241.61050-5-ferruh.yigit@intel.com (mailing list archive)
State Rejected, archived
Delegated to: Ferruh Yigit
Headers

Checks

Context Check Description
ci/checkpatch warning coding style issues
ci/Intel-compilation success Compilation OK

Commit Message

Ferruh Yigit Nov. 21, 2017, 1:42 a.m. UTC
  To track modification:
ce17eddefc20 ("ethdev: introduce Rx queue offloads API")
cba7f53b717d ("ethdev: introduce Tx queue offloads API")

Proposed deadline for PMDs is v18.05

Signed-off-by: Ferruh Yigit <ferruh.yigit@intel.com>
---
 doc/guides/nics/todo.rst | 11 +++++++++++
 1 file changed, 11 insertions(+)
  

Comments

Shahaf Shuler Nov. 21, 2017, 8:32 a.m. UTC | #1
Hi Ferruh,

Tuesday, November 21, 2017 3:43 AM, Ferruh Yigit:
> To track modification:
> ce17eddefc20 ("ethdev: introduce Rx queue offloads API") cba7f53b717d
> ("ethdev: introduce Tx queue offloads API")
> 
> Proposed deadline for PMDs is v18.05

The deprecation of the old offloads API is set to 18.05 [1]. my understanding was that we agreed to convert all PMDs on 18.02.
If the PMD deadline is going to be postponed I think the ethdev deprecation should be updated. 

[1] http://dpdk.org/doc/guides/rel_notes/deprecation.html

> 
> Signed-off-by: Ferruh Yigit <ferruh.yigit@intel.com>
> ---
>  doc/guides/nics/todo.rst | 11 +++++++++++
>  1 file changed, 11 insertions(+)
> 
> diff --git a/doc/guides/nics/todo.rst b/doc/guides/nics/todo.rst index
> 9ace19716..61dd9cbc9 100644
> --- a/doc/guides/nics/todo.rst
> +++ b/doc/guides/nics/todo.rst
> @@ -72,3 +72,14 @@ This is the list for tracking required PMD changes
> triggered by library modifica
>   |                   | | thunderx, vhost, virtio,     |          |                |                                   |
>   |                   | | vmxnet3                      |          |                |                                   |
>   +-------------------+--------------------------------+----------+----------------+-------
> ----------------------------+
> + | new offload flags | | af_packet, ark, avp, bnx2x,  | v18.05   |
> ce17eddefc20   | Use new ethdev offloads filed     |
> + |                   | | bnxt, bonding, cxgbe, dpaa,  |          | cba7f53b717d   | to get
> requested offload list     |
> + |                   | | dpaa2, e1000, ena, enic,     |          |                | instead of bitfield
> values.       |
> + |                   | | failsafe, fm10k, i40e, ixgbe,|          |                |
> |
> + |                   | | kni, liquidio, mlx4, mlx5,   |          |                |                                   |
> + |                   | | mrvl, nfp, null, octeontx,   |          |                |                                   |
> + |                   | | pcap, qede, ring, sfc,       |          |                |                                   |
> + |                   | | softnic, szedata2, tap,      |          |                |                                   |
> + |                   | | thunderx, vhost, virtio,     |          |                |                                   |
> + |                   | | vmxnet3                      |          |                |                                   |
> + +-------------------+--------------------------------+----------+----------------+------
> -----------------------------+
> --
> 2.13.6
  
Ferruh Yigit Nov. 21, 2017, 6:02 p.m. UTC | #2
On 11/21/2017 12:32 AM, Shahaf Shuler wrote:
> Hi Ferruh,
> 
> Tuesday, November 21, 2017 3:43 AM, Ferruh Yigit:
>> To track modification:
>> ce17eddefc20 ("ethdev: introduce Rx queue offloads API") cba7f53b717d
>> ("ethdev: introduce Tx queue offloads API")
>>
>> Proposed deadline for PMDs is v18.05
> 
> The deprecation of the old offloads API is set to 18.05 [1]. my understanding was that we agreed to convert all PMDs on 18.02.
> If the PMD deadline is going to be postponed I think the ethdev deprecation should be updated. 

Hi Shahaf,

I put deadlines roughly and they need to be discussed here.

But 18.02 deadline is not far away.
I think it is not realistic to expect all relevant PMDs do this conversion on
time, what do you think?

My concern is if there can be some PMD maintainers just learned that an update
is required. I put these docs for that synchronization, but not sure how
efficient or noisy it will be.

Thanks,
ferruh

> 
> [1] http://dpdk.org/doc/guides/rel_notes/deprecation.html
> 
>>
>> Signed-off-by: Ferruh Yigit <ferruh.yigit@intel.com>
>> ---
>>  doc/guides/nics/todo.rst | 11 +++++++++++
>>  1 file changed, 11 insertions(+)
>>
>> diff --git a/doc/guides/nics/todo.rst b/doc/guides/nics/todo.rst index
>> 9ace19716..61dd9cbc9 100644
>> --- a/doc/guides/nics/todo.rst
>> +++ b/doc/guides/nics/todo.rst
>> @@ -72,3 +72,14 @@ This is the list for tracking required PMD changes
>> triggered by library modifica
>>   |                   | | thunderx, vhost, virtio,     |          |                |                                   |
>>   |                   | | vmxnet3                      |          |                |                                   |
>>   +-------------------+--------------------------------+----------+----------------+-------
>> ----------------------------+
>> + | new offload flags | | af_packet, ark, avp, bnx2x,  | v18.05   |
>> ce17eddefc20   | Use new ethdev offloads filed     |
>> + |                   | | bnxt, bonding, cxgbe, dpaa,  |          | cba7f53b717d   | to get
>> requested offload list     |
>> + |                   | | dpaa2, e1000, ena, enic,     |          |                | instead of bitfield
>> values.       |
>> + |                   | | failsafe, fm10k, i40e, ixgbe,|          |                |
>> |
>> + |                   | | kni, liquidio, mlx4, mlx5,   |          |                |                                   |
>> + |                   | | mrvl, nfp, null, octeontx,   |          |                |                                   |
>> + |                   | | pcap, qede, ring, sfc,       |          |                |                                   |
>> + |                   | | softnic, szedata2, tap,      |          |                |                                   |
>> + |                   | | thunderx, vhost, virtio,     |          |                |                                   |
>> + |                   | | vmxnet3                      |          |                |                                   |
>> + +-------------------+--------------------------------+----------+----------------+------
>> -----------------------------+
>> --
>> 2.13.6
>
  
Shahaf Shuler Nov. 22, 2017, 8:43 a.m. UTC | #3
Tuesday, November 21, 2017 8:03 PM, Ferruh Yigit:
> On 11/21/2017 12:32 AM, Shahaf Shuler wrote:

> >

> > The deprecation of the old offloads API is set to 18.05 [1]. my

> understanding was that we agreed to convert all PMDs on 18.02.

> > If the PMD deadline is going to be postponed I think the ethdev

> deprecation should be updated.

> 

> Hi Shahaf,

> 

> I put deadlines roughly and they need to be discussed here.

> 

> But 18.02 deadline is not far away.

> I think it is not realistic to expect all relevant PMDs do this conversion on

> time, what do you think?


I cannot tell about other vendors plans. For mlx4 and mlx5 I plan to convert on 18.02.
From the discussion we had on 17.11 for this feature we agreed to split it into 2, and the PMD part will be on 18.02. no one objected. 

Maybe on the next Tech-board you can have a sync between some of the vendors to see the plans.
If not all can make it, we should postpone the deprecation of the old API.  

> 

> My concern is if there can be some PMD maintainers just learned that an

> update is required. I put these docs for that synchronization, but not sure

> how efficient or noisy it will be.

> 

> Thanks,

> ferruh

> 

> >

> > [1]

> >

> https://emea01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fdpd

> k

> >

> .org%2Fdoc%2Fguides%2Frel_notes%2Fdeprecation.html&data=02%7C01%7

> Cshah

> >

> afs%40mellanox.com%7Cd356ec7687fb4ef96d8608d5310a0c27%7Ca652971c7

> d2e4d

> >

> 9ba6a4d149256f461b%7C0%7C0%7C636468841603090882&sdata=cXeLzqmlly

> nIg7xS

> > zCIUJsHGFLHfA0LBdCWLv0%2B3Ko0%3D&reserved=0

> >

> >>

> >> Signed-off-by: Ferruh Yigit <ferruh.yigit@intel.com>

> >> ---

> >>  doc/guides/nics/todo.rst | 11 +++++++++++

> >>  1 file changed, 11 insertions(+)

> >>

> >> diff --git a/doc/guides/nics/todo.rst b/doc/guides/nics/todo.rst

> >> index

> >> 9ace19716..61dd9cbc9 100644

> >> --- a/doc/guides/nics/todo.rst

> >> +++ b/doc/guides/nics/todo.rst

> >> @@ -72,3 +72,14 @@ This is the list for tracking required PMD changes

> >> triggered by library modifica

> >>   |                   | | thunderx, vhost, virtio,     |          |                |

> |

> >>   |                   | | vmxnet3                      |          |                |                                   |

> >>

> >> +-------------------+--------------------------------+----------+----

> >> ------------+-------

> >> ----------------------------+

> >> + | new offload flags | | af_packet, ark, avp, bnx2x,  | v18.05   |

> >> ce17eddefc20   | Use new ethdev offloads filed     |

> >> + |                   | | bnxt, bonding, cxgbe, dpaa,  |          | cba7f53b717d   | to

> get

> >> requested offload list     |

> >> + |                   | | dpaa2, e1000, ena, enic,     |          |                | instead of

> bitfield

> >> values.       |

> >> + |                   | | failsafe, fm10k, i40e, ixgbe,|          |                |

> >> |

> >> + |                   | | kni, liquidio, mlx4, mlx5,   |          |                |

> |

> >> + |                   | | mrvl, nfp, null, octeontx,   |          |                |

> |

> >> + |                   | | pcap, qede, ring, sfc,       |          |                |

> |

> >> + |                   | | softnic, szedata2, tap,      |          |                |

> |

> >> + |                   | | thunderx, vhost, virtio,     |          |                |

> |

> >> + |                   | | vmxnet3                      |          |                |                                   |

> >> + +-------------------+--------------------------------+----------+----------------+---

> ---

> >> -----------------------------+

> >> --

> >> 2.13.6

> >
  
Thomas Monjalon Nov. 22, 2017, 8:54 a.m. UTC | #4
22/11/2017 09:43, Shahaf Shuler:
> Tuesday, November 21, 2017 8:03 PM, Ferruh Yigit:
> > On 11/21/2017 12:32 AM, Shahaf Shuler wrote:
> > >
> > > The deprecation of the old offloads API is set to 18.05 [1]. my
> > understanding was that we agreed to convert all PMDs on 18.02.
> > > If the PMD deadline is going to be postponed I think the ethdev
> > deprecation should be updated.
> > 
> > Hi Shahaf,
> > 
> > I put deadlines roughly and they need to be discussed here.
> > 
> > But 18.02 deadline is not far away.
> > I think it is not realistic to expect all relevant PMDs do this conversion on
> > time, what do you think?
> 
> I cannot tell about other vendors plans. For mlx4 and mlx5 I plan to convert on 18.02.
> From the discussion we had on 17.11 for this feature we agreed to split it into 2, and the PMD part will be on 18.02. no one objected. 
> 
> Maybe on the next Tech-board you can have a sync between some of the vendors to see the plans.
> If not all can make it, we should postpone the deprecation of the old API.  

The current plan looks good to me.
We try to migrate to the new API in 18.02.
If some drivers are not migrated in 18.02, we urge them to do so in 18.05.
And we remove the old API in 18.05.
  
John McNamara Dec. 11, 2017, 2:11 p.m. UTC | #5
> -----Original Message-----
> From: Yigit, Ferruh
> Sent: Tuesday, November 21, 2017 1:43 AM
> To: Thomas Monjalon <thomas@monjalon.net>; Mcnamara, John
> <john.mcnamara@intel.com>
> Cc: dev@dpdk.org; Yigit, Ferruh <ferruh.yigit@intel.com>
> Subject: [PATCH 5/6] doc: add offload flag to PMD todo list
> 
> To track modification:
> ce17eddefc20 ("ethdev: introduce Rx queue offloads API") cba7f53b717d
> ("ethdev: introduce Tx queue offloads API")
> 
> Proposed deadline for PMDs is v18.05
> 
> Signed-off-by: Ferruh Yigit <ferruh.yigit@intel.com>

Acked-by: John McNamara <john.mcnamara@intel.com>
  

Patch

diff --git a/doc/guides/nics/todo.rst b/doc/guides/nics/todo.rst
index 9ace19716..61dd9cbc9 100644
--- a/doc/guides/nics/todo.rst
+++ b/doc/guides/nics/todo.rst
@@ -72,3 +72,14 @@  This is the list for tracking required PMD changes triggered by library modifica
  |                   | | thunderx, vhost, virtio,     |          |                |                                   |
  |                   | | vmxnet3                      |          |                |                                   |
  +-------------------+--------------------------------+----------+----------------+-----------------------------------+
+ | new offload flags | | af_packet, ark, avp, bnx2x,  | v18.05   | ce17eddefc20   | Use new ethdev offloads filed     |
+ |                   | | bnxt, bonding, cxgbe, dpaa,  |          | cba7f53b717d   | to get requested offload list     |
+ |                   | | dpaa2, e1000, ena, enic,     |          |                | instead of bitfield values.       |
+ |                   | | failsafe, fm10k, i40e, ixgbe,|          |                |                                   |
+ |                   | | kni, liquidio, mlx4, mlx5,   |          |                |                                   |
+ |                   | | mrvl, nfp, null, octeontx,   |          |                |                                   |
+ |                   | | pcap, qede, ring, sfc,       |          |                |                                   |
+ |                   | | softnic, szedata2, tap,      |          |                |                                   |
+ |                   | | thunderx, vhost, virtio,     |          |                |                                   |
+ |                   | | vmxnet3                      |          |                |                                   |
+ +-------------------+--------------------------------+----------+----------------+-----------------------------------+