diff mbox

[dpdk-dev] app/testpmd: fix port_id alloction issue

Message ID 20171123012630.50477-1-yanglong.wu@intel.com (mailing list archive)
State Superseded, archived
Delegated to: Thomas Monjalon
Headers

Checks

Context Check Description
ci/checkpatch success coding style OK
ci/Intel-compilation success Compilation OK

Commit Message

Yanglong Wu Nov. 23, 2017, 1:26 a.m. UTC 
  the port_id was allocated as a inccrete number,
for init function was passthroughed a wrong
size of parameter

Fixes:28caa76aea71 ("app/testpmd: fix port id type")

Signed-off-by: Yanglong Wu <yanglong.wu@intel.com>
---
 app/test-pmd/cmdline.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Yang, Zhiyong Nov. 23, 2017, 1:57 a.m. UTC | #1 
Hi Yanglong,

Good catch!  Thanks for your patch.

Thanks
Zhiyong
> -----Original Message-----
> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Yanglong Wu
> Sent: Thursday, November 23, 2017 9:27 AM
> To: dev@dpdk.org
> Cc: Wu, Yanglong <yanglong.wu@intel.com>
> Subject: [dpdk-dev] [PATCH] app/testpmd: fix port_id alloction issue
> 
> the port_id was allocated as a inccrete number, for init function was
> passthroughed a wrong size of parameter

The commit log is not clear enough.

> 
> Fixes:28caa76aea71 ("app/testpmd: fix port id type")
> 
> Signed-off-by: Yanglong Wu <yanglong.wu@intel.com>
> ---
>  app/test-pmd/cmdline.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/app/test-pmd/cmdline.c b/app/test-pmd/cmdline.c index
> f71d96301..8990ebf6b 100644
> --- a/app/test-pmd/cmdline.c
> +++ b/app/test-pmd/cmdline.c
> @@ -3352,7 +3352,7 @@ cmdline_parse_token_num_t cmd_vlan_tpid_tpid =
>  			      tp_id, UINT16);
>  cmdline_parse_token_num_t cmd_vlan_tpid_portid =
>  	TOKEN_NUM_INITIALIZER(struct cmd_vlan_tpid_result,
> -			      port_id, UINT8);
> +			      port_id, UINT16);
> 
>  cmdline_parse_inst_t cmd_vlan_tpid = {
>  	.f = cmd_vlan_tpid_parsed,
> --
> 2.11.0
Yang, Zhiyong Nov. 23, 2017, 2:05 a.m. UTC | #2 
> -----Original Message-----
> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Yang, Zhiyong
> Sent: Thursday, November 23, 2017 9:57 AM
> To: Wu, Yanglong <yanglong.wu@intel.com>; dev@dpdk.org
> Cc: Wu, Yanglong <yanglong.wu@intel.com>
> Subject: Re: [dpdk-dev] [PATCH] app/testpmd: fix port_id alloction issue
> 
> Hi Yanglong,
> 
> Good catch!  Thanks for your patch.
> 
> Thanks
> Zhiyong
> > -----Original Message-----
> > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Yanglong Wu
> > Sent: Thursday, November 23, 2017 9:27 AM
> > To: dev@dpdk.org
> > Cc: Wu, Yanglong <yanglong.wu@intel.com>
> > Subject: [dpdk-dev] [PATCH] app/testpmd: fix port_id alloction issue
> >
> > the port_id was allocated as a inccrete number, for init function was
> > passthroughed a wrong size of parameter
> 
> The commit log is not clear enough.
> 

Except that,  you can add
Reviewed-by: Zhiyong Yang <zhiyong.yang@intel.com>

> >
> > Fixes:28caa76aea71 ("app/testpmd: fix port id type")
> >
> > Signed-off-by: Yanglong Wu <yanglong.wu@intel.com>
> > ---
> >  app/test-pmd/cmdline.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/app/test-pmd/cmdline.c b/app/test-pmd/cmdline.c index
> > f71d96301..8990ebf6b 100644
> > --- a/app/test-pmd/cmdline.c
> > +++ b/app/test-pmd/cmdline.c
> > @@ -3352,7 +3352,7 @@ cmdline_parse_token_num_t cmd_vlan_tpid_tpid =
> >  			      tp_id, UINT16);
> >  cmdline_parse_token_num_t cmd_vlan_tpid_portid =
> >  	TOKEN_NUM_INITIALIZER(struct cmd_vlan_tpid_result,
> > -			      port_id, UINT8);
> > +			      port_id, UINT16);
> >
> >  cmdline_parse_inst_t cmd_vlan_tpid = {
> >  	.f = cmd_vlan_tpid_parsed,
> > --
> > 2.11.0
diff mbox

Patch

diff --git a/app/test-pmd/cmdline.c b/app/test-pmd/cmdline.c
index f71d96301..8990ebf6b 100644
--- a/app/test-pmd/cmdline.c
+++ b/app/test-pmd/cmdline.c
@@ -3352,7 +3352,7 @@  cmdline_parse_token_num_t cmd_vlan_tpid_tpid =
 			      tp_id, UINT16);
 cmdline_parse_token_num_t cmd_vlan_tpid_portid =
 	TOKEN_NUM_INITIALIZER(struct cmd_vlan_tpid_result,
-			      port_id, UINT8);
+			      port_id, UINT16);
 
 cmdline_parse_inst_t cmd_vlan_tpid = {
 	.f = cmd_vlan_tpid_parsed,