[dpdk-dev] net/nfp: fix CRC strip check behaviour
Checks
Commit Message
NFP does CRC strip by default and it is not configurable. But, even
if an app requests not to do it, that should not be a reason for PMD
configuration failure.
Fixes: defb9a5dd156 ("nfp: introduce driver initialization")
Signed-off-by: Alejandro Lucero <alejandro.lucero@netronome.com>
---
drivers/net/nfp/nfp_net.c | 6 ++----
1 file changed, 2 insertions(+), 4 deletions(-)
Comments
On 11/24/2017 6:26 AM, Alejandro Lucero wrote:
> NFP does CRC strip by default and it is not configurable. But, even
> if an app requests not to do it, that should not be a reason for PMD
> configuration failure.
>
> Fixes: defb9a5dd156 ("nfp: introduce driver initialization")
>
> Signed-off-by: Alejandro Lucero <alejandro.lucero@netronome.com>
Applied to dpdk-next-net/master, thanks.
@@ -491,10 +491,8 @@ enum nfp_qcp_ptr {
if (rxmode->jumbo_frame)
hw->mtu = rxmode->max_rx_pkt_len;
- if (rxmode->hw_strip_crc) {
- PMD_INIT_LOG(INFO, "strip CRC not supported");
- return -EINVAL;
- }
+ if (!rxmode->hw_strip_crc)
+ PMD_INIT_LOG(INFO, "HW does strip CRC and it is not configurable");
if (rxmode->enable_scatter) {
PMD_INIT_LOG(INFO, "Scatter not supported");