[dpdk-dev] cryptodev: Add useful comment to _sym_session

Message ID 1511782828-19964-1-git-send-email-billy.o.mahony@intel.com (mailing list archive)
State Accepted, archived
Delegated to: Pablo de Lara Guarch
Headers

Checks

Context Check Description
ci/checkpatch success coding style OK
ci/Intel-compilation success Compilation OK

Commit Message

Billy O'Mahony Nov. 27, 2017, 11:40 a.m. UTC
  Signed-off-by: Billy O'Mahony <billy.o.mahony@intel.com>
---
 lib/librte_cryptodev/rte_cryptodev.h | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)
  

Comments

Fiona Trahe Nov. 27, 2017, 11:44 a.m. UTC | #1
> -----Original Message-----
> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Billy O'Mahony
> Sent: Monday, November 27, 2017 11:40 AM
> To: De Lara Guarch, Pablo <pablo.de.lara.guarch@intel.com>; dev@dpdk.org
> Cc: O Mahony, Billy <billy.o.mahony@intel.com>
> Subject: [dpdk-dev] [PATCH] cryptodev: Add useful comment to _sym_session
> 
> Signed-off-by: Billy O'Mahony <billy.o.mahony@intel.com>
Acked-by: Fiona Trahe <fiona.trahe@intel.com>
  
De Lara Guarch, Pablo Dec. 11, 2017, 10:43 a.m. UTC | #2
> -----Original Message-----
> From: Trahe, Fiona
> Sent: Monday, November 27, 2017 11:45 AM
> To: O Mahony, Billy <billy.o.mahony@intel.com>; De Lara Guarch, Pablo
> <pablo.de.lara.guarch@intel.com>; dev@dpdk.org
> Cc: O Mahony, Billy <billy.o.mahony@intel.com>
> Subject: RE: [dpdk-dev] [PATCH] cryptodev: Add useful comment to
> _sym_session
> 
> 
> 
> > -----Original Message-----
> > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Billy O'Mahony
> > Sent: Monday, November 27, 2017 11:40 AM
> > To: De Lara Guarch, Pablo <pablo.de.lara.guarch@intel.com>;
> dev@dpdk.org
> > Cc: O Mahony, Billy <billy.o.mahony@intel.com>
> > Subject: [dpdk-dev] [PATCH] cryptodev: Add useful comment to
> _sym_session
> >
> > Signed-off-by: Billy O'Mahony <billy.o.mahony@intel.com>
> Acked-by: Fiona Trahe <fiona.trahe@intel.com>

Applied to dpdk-next-crypto.
Thanks,

Pablo
  

Patch

diff --git a/lib/librte_cryptodev/rte_cryptodev.h b/lib/librte_cryptodev/rte_cryptodev.h
index dade554..879bd71 100644
--- a/lib/librte_cryptodev/rte_cryptodev.h
+++ b/lib/librte_cryptodev/rte_cryptodev.h
@@ -890,7 +890,10 @@  rte_cryptodev_enqueue_burst(uint8_t dev_id, uint16_t qp_id,
 }
 
 
-/** Cryptodev symmetric crypto session */
+/** Cryptodev symmetric crypto session
+ * Each session is derived from a fixed xform chain. Therefore each session
+ * has a fixed algo, key, op-type, digest_len etc.
+ */
 struct rte_cryptodev_sym_session {
 	__extension__ void *sess_private_data[0];
 	/**< Private session material */