[dpdk-dev] igb: fix Tx queue number

Message ID d3e3049c-f86b-402e-9e07-73c07cc4812c@zyc-PC.local (mailing list archive)
State Accepted, archived
Delegated to: Helin Zhang
Headers

Checks

Context Check Description
ci/checkpatch success coding style OK
ci/Intel-compilation success Compilation OK

Commit Message

Matt Nov. 29, 2017, 2:50 a.m. UTC
  Internal variable containing the number of TX queues for a device,
was being incorrectly assigned the number of RX queues, instead of TX.

Fixes: 27b609cbd1c6 ("ethdev: move the multi-queue mode check to specific drivers")

Signed-off-by: Yangchao Zhou <zhouyates@gmail.com>
---
 drivers/net/e1000/igb_ethdev.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
  

Comments

Zhang, Helin Dec. 19, 2017, 7:18 a.m. UTC | #1
> -----Original Message-----
> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of zhouyangchao
> Sent: Wednesday, November 29, 2017 10:50 AM
> To: dev@dpdk.org
> Cc: Lu, Wenzhuo
> Subject: [dpdk-dev] [PATCH] igb: fix Tx queue number
Basically please follow the style of 'net/igb:', thanks!

/Helin
> 
> Internal variable containing the number of TX queues for a device, was being
> incorrectly assigned the number of RX queues, instead of TX.
> 
> Fixes: 27b609cbd1c6 ("ethdev: move the multi-queue mode check to specific
> drivers")
> 
> Signed-off-by: Yangchao Zhou <zhouyates@gmail.com>
> ---
>  drivers/net/e1000/igb_ethdev.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/net/e1000/igb_ethdev.c b/drivers/net/e1000/igb_ethdev.c
> index fdc139f..a600fba 100644
> --- a/drivers/net/e1000/igb_ethdev.c
> +++ b/drivers/net/e1000/igb_ethdev.c
> @@ -1212,7 +1212,7 @@ igb_check_mq_mode(struct rte_eth_dev *dev)
>  	enum rte_eth_rx_mq_mode rx_mq_mode = dev->data-
> >dev_conf.rxmode.mq_mode;
>  	enum rte_eth_tx_mq_mode tx_mq_mode = dev->data-
> >dev_conf.txmode.mq_mode;
>  	uint16_t nb_rx_q = dev->data->nb_rx_queues;
> -	uint16_t nb_tx_q = dev->data->nb_rx_queues;
> +	uint16_t nb_tx_q = dev->data->nb_tx_queues;
> 
>  	if ((rx_mq_mode & ETH_MQ_RX_DCB_FLAG) ||
>  	    tx_mq_mode == ETH_MQ_TX_DCB ||
> --
> 2.9.0.windows.1
> 
>
  
Wei Dai Dec. 19, 2017, 12:22 p.m. UTC | #2
> -----Original Message-----
> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of zhouyangchao
> Sent: Wednesday, November 29, 2017 10:50 AM
> To: dev@dpdk.org
> Cc: Lu, Wenzhuo <wenzhuo.lu@intel.com>
> Subject: [dpdk-dev] [PATCH] igb: fix Tx queue number
> 
> Internal variable containing the number of TX queues for a device, was being
> incorrectly assigned the number of RX queues, instead of TX.
> 
> Fixes: 27b609cbd1c6 ("ethdev: move the multi-queue mode check to specific
> drivers")
> 
> Signed-off-by: Yangchao Zhou <zhouyates@gmail.com>
Acked-by: Wei Dai <wei.dai@intel.com>
> ---
>  drivers/net/e1000/igb_ethdev.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/net/e1000/igb_ethdev.c
> b/drivers/net/e1000/igb_ethdev.c index fdc139f..a600fba 100644
> --- a/drivers/net/e1000/igb_ethdev.c
> +++ b/drivers/net/e1000/igb_ethdev.c
> @@ -1212,7 +1212,7 @@ igb_check_mq_mode(struct rte_eth_dev *dev)
>  	enum rte_eth_rx_mq_mode rx_mq_mode =
> dev->data->dev_conf.rxmode.mq_mode;
>  	enum rte_eth_tx_mq_mode tx_mq_mode =
> dev->data->dev_conf.txmode.mq_mode;
>  	uint16_t nb_rx_q = dev->data->nb_rx_queues;
> -	uint16_t nb_tx_q = dev->data->nb_rx_queues;
> +	uint16_t nb_tx_q = dev->data->nb_tx_queues;
> 
>  	if ((rx_mq_mode & ETH_MQ_RX_DCB_FLAG) ||
>  	    tx_mq_mode == ETH_MQ_TX_DCB ||
> --
> 2.9.0.windows.1
> 
>
  
Zhang, Helin Dec. 20, 2017, 6:26 a.m. UTC | #3
> -----Original Message-----
> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Dai, Wei
> Sent: Tuesday, December 19, 2017 8:22 PM
> To: zhouyangchao; dev@dpdk.org
> Cc: Lu, Wenzhuo
> Subject: Re: [dpdk-dev] [PATCH] igb: fix Tx queue number
> 
> > -----Original Message-----
> > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of zhouyangchao
> > Sent: Wednesday, November 29, 2017 10:50 AM
> > To: dev@dpdk.org
> > Cc: Lu, Wenzhuo <wenzhuo.lu@intel.com>
> > Subject: [dpdk-dev] [PATCH] igb: fix Tx queue number
> >
> > Internal variable containing the number of TX queues for a device, was
> > being incorrectly assigned the number of RX queues, instead of TX.
> >
> > Fixes: 27b609cbd1c6 ("ethdev: move the multi-queue mode check to
> > specific
> > drivers")
> >
> > Signed-off-by: Yangchao Zhou <zhouyates@gmail.com>
> Acked-by: Wei Dai <wei.dai@intel.com>

Applied to next-net-intel with minor format fix. Thanks! /Helin
  

Patch

diff --git a/drivers/net/e1000/igb_ethdev.c b/drivers/net/e1000/igb_ethdev.c
index fdc139f..a600fba 100644
--- a/drivers/net/e1000/igb_ethdev.c
+++ b/drivers/net/e1000/igb_ethdev.c
@@ -1212,7 +1212,7 @@  igb_check_mq_mode(struct rte_eth_dev *dev)
 	enum rte_eth_rx_mq_mode rx_mq_mode = dev->data->dev_conf.rxmode.mq_mode;
 	enum rte_eth_tx_mq_mode tx_mq_mode = dev->data->dev_conf.txmode.mq_mode;
 	uint16_t nb_rx_q = dev->data->nb_rx_queues;
-	uint16_t nb_tx_q = dev->data->nb_rx_queues;
+	uint16_t nb_tx_q = dev->data->nb_tx_queues;
 
 	if ((rx_mq_mode & ETH_MQ_RX_DCB_FLAG) ||
 	    tx_mq_mode == ETH_MQ_TX_DCB ||