diff mbox

[dpdk-dev] test/eventdev: use CPU event type

Message ID 20171204081118.15537-1-jerin.jacob@caviumnetworks.com (mailing list archive)
State Accepted, archived
Delegated to: Jerin Jacob
Headers

Checks

Context Check Description
ci/checkpatch success coding style OK
ci/Intel-compilation success Compilation OK

Commit Message

Jerin Jacob Dec. 4, 2017, 8:11 a.m. UTC 
  octeontx test application was using non RTE_EVENT_TYPE_CPU
event type to generate the event from CPU.  Upon the introduction
of ethdev Rx adapter, RTE_EVENT_TYPE_ETHDEV has special
meaning. So avoid using non RTE_EVENT_TYPE_CPU event types
to inject events from CPU.

Fixes: d0d654986018 ("net/octeontx: support event Rx adapter")
Cc: stable@dpdk.org

Signed-off-by: Jerin Jacob <jerin.jacob@caviumnetworks.com>
---
 test/test/test_eventdev_octeontx.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

Comments

Pavan Nikhilesh Dec. 4, 2017, 8:44 a.m. UTC | #1 
On Mon, Dec 04, 2017 at 01:41:18PM +0530, Jerin Jacob wrote:
> octeontx test application was using non RTE_EVENT_TYPE_CPU
> event type to generate the event from CPU.  Upon the introduction
> of ethdev Rx adapter, RTE_EVENT_TYPE_ETHDEV has special
> meaning. So avoid using non RTE_EVENT_TYPE_CPU event types
> to inject events from CPU.
>
> Fixes: d0d654986018 ("net/octeontx: support event Rx adapter")
> Cc: stable@dpdk.org
>
> Signed-off-by: Jerin Jacob <jerin.jacob@caviumnetworks.com>
> ---
>  test/test/test_eventdev_octeontx.c | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/test/test/test_eventdev_octeontx.c b/test/test/test_eventdev_octeontx.c
> index dbc36d948..8fddb4fd2 100644
> --- a/test/test/test_eventdev_octeontx.c
> +++ b/test/test/test_eventdev_octeontx.c
> @@ -355,7 +355,7 @@ generate_random_events(const unsigned int total_events)
>  	for (i = 0; i < total_events; i++) {
>  		ret = inject_events(
>  			rte_rand() % info.max_event_queue_flows /*flow_id */,
> -			rte_rand() % (RTE_EVENT_TYPE_CPU + 1) /* event_type */,
> +			RTE_EVENT_TYPE_CPU /* event_type */,
>  			rte_rand() % 256 /* sub_event_type */,
>  			rte_rand() % (RTE_SCHED_TYPE_PARALLEL + 1),
>  			rte_rand() % queue_count /* queue */,
> @@ -745,7 +745,7 @@ test_queue_to_port_single_link(void)
>
>  		ret = inject_events(
>  			0x100 /*flow_id */,
> -			rte_rand() % (RTE_EVENT_TYPE_CPU + 1) /* event_type */,
> +			RTE_EVENT_TYPE_CPU /* event_type */,
>  			rte_rand() % 256 /* sub_event_type */,
>  			rte_rand() % (RTE_SCHED_TYPE_PARALLEL + 1),
>  			queue /* queue */,
> @@ -824,7 +824,7 @@ test_queue_to_port_multi_link(void)
>
>  		ret = inject_events(
>  			0x100 /*flow_id */,
> -			rte_rand() % (RTE_EVENT_TYPE_CPU + 1) /* event_type */,
> +			RTE_EVENT_TYPE_CPU /* event_type */,
>  			rte_rand() % 256 /* sub_event_type */,
>  			rte_rand() % (RTE_SCHED_TYPE_PARALLEL + 1),
>  			queue /* queue */,
> --
> 2.15.1
>

Reviewed-by: Pavan Nikhilesh <pbhagavatula@caviumnetworks.com>
Jerin Jacob Dec. 9, 2017, 9:27 a.m. UTC | #2 
-----Original Message-----
> Date: Mon, 4 Dec 2017 14:14:45 +0530
> From: Pavan Nikhilesh Bhagavatula <pbhagavatula@caviumnetworks.com>
> To: Jerin Jacob <jerin.jacob@caviumnetworks.com>
> Cc: dev@dpdk.org
> Subject: Re: [dpdk-dev] [PATCH] test/eventdev: use CPU event type
> User-Agent: NeoMutt/20170609 (1.8.3)
> 
> On Mon, Dec 04, 2017 at 01:41:18PM +0530, Jerin Jacob wrote:
> > octeontx test application was using non RTE_EVENT_TYPE_CPU
> > event type to generate the event from CPU.  Upon the introduction
> > of ethdev Rx adapter, RTE_EVENT_TYPE_ETHDEV has special
> > meaning. So avoid using non RTE_EVENT_TYPE_CPU event types
> > to inject events from CPU.
> >
> > Fixes: d0d654986018 ("net/octeontx: support event Rx adapter")
> > Cc: stable@dpdk.org
> >
> > Signed-off-by: Jerin Jacob <jerin.jacob@caviumnetworks.com>
> > ---
> >  test/test/test_eventdev_octeontx.c | 6 +++---
> Reviewed-by: Pavan Nikhilesh <pbhagavatula@caviumnetworks.com>

Applied to dpdk-next-eventdev/master. Thanks.
diff mbox

Patch

diff --git a/test/test/test_eventdev_octeontx.c b/test/test/test_eventdev_octeontx.c
index dbc36d948..8fddb4fd2 100644
--- a/test/test/test_eventdev_octeontx.c
+++ b/test/test/test_eventdev_octeontx.c
@@ -355,7 +355,7 @@  generate_random_events(const unsigned int total_events)
 	for (i = 0; i < total_events; i++) {
 		ret = inject_events(
 			rte_rand() % info.max_event_queue_flows /*flow_id */,
-			rte_rand() % (RTE_EVENT_TYPE_CPU + 1) /* event_type */,
+			RTE_EVENT_TYPE_CPU /* event_type */,
 			rte_rand() % 256 /* sub_event_type */,
 			rte_rand() % (RTE_SCHED_TYPE_PARALLEL + 1),
 			rte_rand() % queue_count /* queue */,
@@ -745,7 +745,7 @@  test_queue_to_port_single_link(void)
 
 		ret = inject_events(
 			0x100 /*flow_id */,
-			rte_rand() % (RTE_EVENT_TYPE_CPU + 1) /* event_type */,
+			RTE_EVENT_TYPE_CPU /* event_type */,
 			rte_rand() % 256 /* sub_event_type */,
 			rte_rand() % (RTE_SCHED_TYPE_PARALLEL + 1),
 			queue /* queue */,
@@ -824,7 +824,7 @@  test_queue_to_port_multi_link(void)
 
 		ret = inject_events(
 			0x100 /*flow_id */,
-			rte_rand() % (RTE_EVENT_TYPE_CPU + 1) /* event_type */,
+			RTE_EVENT_TYPE_CPU /* event_type */,
 			rte_rand() % 256 /* sub_event_type */,
 			rte_rand() % (RTE_SCHED_TYPE_PARALLEL + 1),
 			queue /* queue */,