[dpdk-dev,4/5] net/virtio: remove redundant macro definitions for vector Rx
Checks
Commit Message
RTE_VIRTIO_VPMD_RX_BURST and RTE_VIRTIO_VPMD_RX_REARM_THRESH
have been defined and used in virtio_rxtx_simple.h, but are
defined agained in virtio_rxtx_simple_*.c. It just happens to
work. So remove the redundant definitions from the *.c files.
Signed-off-by: Tiwei Bie <tiwei.bie@intel.com>
---
drivers/net/virtio/virtio_rxtx_simple_neon.c | 2 --
drivers/net/virtio/virtio_rxtx_simple_sse.c | 2 --
2 files changed, 4 deletions(-)
Comments
On 12/07/2017 06:30 AM, Tiwei Bie wrote:
> RTE_VIRTIO_VPMD_RX_BURST and RTE_VIRTIO_VPMD_RX_REARM_THRESH
> have been defined and used in virtio_rxtx_simple.h, but are
> defined agained in virtio_rxtx_simple_*.c. It just happens to
s/agained/again/
> work. So remove the redundant definitions from the *.c files.
>
> Signed-off-by: Tiwei Bie <tiwei.bie@intel.com>
> ---
> drivers/net/virtio/virtio_rxtx_simple_neon.c | 2 --
> drivers/net/virtio/virtio_rxtx_simple_sse.c | 2 --
> 2 files changed, 4 deletions(-)
Apart from above typo:
Reviewed-by: Maxime Coquelin <maxime.coquelin@redhat.com>
Thanks,
Maxime
On Thu, Dec 07, 2017 at 10:18:14AM +0100, Maxime Coquelin wrote:
> On 12/07/2017 06:30 AM, Tiwei Bie wrote:
> > RTE_VIRTIO_VPMD_RX_BURST and RTE_VIRTIO_VPMD_RX_REARM_THRESH
> > have been defined and used in virtio_rxtx_simple.h, but are
> > defined agained in virtio_rxtx_simple_*.c. It just happens to
> s/agained/again/
>
Thanks!
Best regards,
Tiwei Bie
> > work. So remove the redundant definitions from the *.c files.
> >
> > Signed-off-by: Tiwei Bie <tiwei.bie@intel.com>
> > ---
> > drivers/net/virtio/virtio_rxtx_simple_neon.c | 2 --
> > drivers/net/virtio/virtio_rxtx_simple_sse.c | 2 --
> > 2 files changed, 4 deletions(-)
>
> Apart from above typo:
>
> Reviewed-by: Maxime Coquelin <maxime.coquelin@redhat.com>
>
> Thanks,
> Maxime
@@ -52,9 +52,7 @@
#include "virtio_rxtx_simple.h"
-#define RTE_VIRTIO_VPMD_RX_BURST 32
#define RTE_VIRTIO_DESC_PER_LOOP 8
-#define RTE_VIRTIO_VPMD_RX_REARM_THRESH RTE_VIRTIO_VPMD_RX_BURST
/* virtio vPMD receive routine, only accept(nb_pkts >= RTE_VIRTIO_DESC_PER_LOOP)
*
@@ -54,9 +54,7 @@
#include "virtio_rxtx_simple.h"
-#define RTE_VIRTIO_VPMD_RX_BURST 32
#define RTE_VIRTIO_DESC_PER_LOOP 8
-#define RTE_VIRTIO_VPMD_RX_REARM_THRESH RTE_VIRTIO_VPMD_RX_BURST
/* virtio vPMD receive routine, only accept(nb_pkts >= RTE_VIRTIO_DESC_PER_LOOP)
*