diff mbox

[dpdk-dev] kni: fix build dependency

Message ID 20171212183956.52341-1-ferruh.yigit@intel.com (mailing list archive)
State Accepted, archived
Delegated to: Thomas Monjalon
Headers

Checks

Context Check Description
ci/checkpatch success coding style OK

Commit Message

Ferruh Yigit Dec. 12, 2017, 6:39 p.m. UTC 
  kni library has a dependency to new PCI library, adding that dependency.

build error:
  CC rte_kni.o
In file included from dpdk/lib/librte_kni/rte_kni.c:48:0:
  dpdk/build/include/rte_kni.h:49:21:
  fatal error: rte_pci.h: No such file or directory
    #include <rte_pci.h>
                       ^

Fixes: c752998b5e2e ("pci: introduce library and driver")
Cc: stable@dpdk.org

Reported-by: Bernard Iremonger <bernard.iremonger@intel.com>
Signed-off-by: Ferruh Yigit <ferruh.yigit@intel.com>
---
 lib/Makefile | 1 +
 1 file changed, 1 insertion(+)

Comments

Iremonger, Bernard Dec. 19, 2017, 12:35 p.m. UTC | #1 
Hi Ferruh,

> -----Original Message-----
> From: Yigit, Ferruh
> Sent: Tuesday, December 12, 2017 6:40 PM
> To: Yigit, Ferruh <ferruh.yigit@intel.com>
> Cc: dev@dpdk.org; Iremonger, Bernard <bernard.iremonger@intel.com>;
> stable@dpdk.org
> Subject: [PATCH] kni: fix build dependency
> 
> kni library has a dependency to new PCI library, adding that dependency.
> 
> build error:
>   CC rte_kni.o
> In file included from dpdk/lib/librte_kni/rte_kni.c:48:0:
>   dpdk/build/include/rte_kni.h:49:21:
>   fatal error: rte_pci.h: No such file or directory
>     #include <rte_pci.h>
>                        ^
> 
> Fixes: c752998b5e2e ("pci: introduce library and driver")
> Cc: stable@dpdk.org
> 
> Reported-by: Bernard Iremonger <bernard.iremonger@intel.com>
> Signed-off-by: Ferruh Yigit <ferruh.yigit@intel.com>

Acked-by: Bernard Iremonger <Bernard.iremonger@intel.com>
Thomas Monjalon Jan. 11, 2018, 5:45 p.m. UTC | #2 
> > kni library has a dependency to new PCI library, adding that dependency.
> > 
> > build error:
> >   CC rte_kni.o
> > In file included from dpdk/lib/librte_kni/rte_kni.c:48:0:
> >   dpdk/build/include/rte_kni.h:49:21:
> >   fatal error: rte_pci.h: No such file or directory
> >     #include <rte_pci.h>
> >                        ^
> > 
> > Fixes: c752998b5e2e ("pci: introduce library and driver")
> > Cc: stable@dpdk.org
> > 
> > Reported-by: Bernard Iremonger <bernard.iremonger@intel.com>
> > Signed-off-by: Ferruh Yigit <ferruh.yigit@intel.com>
> 
> Acked-by: Bernard Iremonger <Bernard.iremonger@intel.com>

Applied, thanks
diff mbox

Patch

diff --git a/lib/Makefile b/lib/Makefile
index dc4e8df70..26113cda7 100644
--- a/lib/Makefile
+++ b/lib/Makefile
@@ -125,5 +125,6 @@  ifeq ($(CONFIG_RTE_EXEC_ENV_LINUXAPP),y)
 DIRS-$(CONFIG_RTE_LIBRTE_KNI) += librte_kni
 endif
 DEPDIRS-librte_kni := librte_eal librte_mempool librte_mbuf librte_ether
+DEPDIRS-librte_kni += librte_pci
 
 include $(RTE_SDK)/mk/rte.subdir.mk