diff mbox

[dpdk-dev] ethdev: fix missing imissed counter in xstats

Message ID 20171214142300.25205-1-olivier.matz@6wind.com (mailing list archive)
State Accepted, archived
Delegated to: Ferruh Yigit
Headers

Checks

Context Check Description
ci/checkpatch success coding style OK
ci/Intel-compilation success Compilation OK

Commit Message

Olivier Matz Dec. 14, 2017, 2:23 p.m. UTC 
  imissed counter has been set as deprecated in commit 49f386542af4
("ethdev: remove driver specific stats") and removed from the
rte_eth_xstats_name_off structure.

The imissed counter has been restored few commits later but has not been
restored in the rte_eth_stats structure. Add it back.

Fixes: 4eadb8ba11b7 ("ethdev: do not deprecate imissed counter")
Cc: stable@dpdk.org

Signed-off-by: Thibaut Collet <thibaut.collet@6wind.com>
Signed-off-by: Olivier Matz <olivier.matz@6wind.com>
---
 lib/librte_ether/rte_ethdev.c | 1 +
 1 file changed, 1 insertion(+)

Comments

Ferruh Yigit Dec. 14, 2017, 5:41 p.m. UTC | #1 
On 12/14/2017 6:23 AM, Olivier Matz wrote:
> imissed counter has been set as deprecated in commit 49f386542af4
> ("ethdev: remove driver specific stats") and removed from the
> rte_eth_xstats_name_off structure.
> 
> The imissed counter has been restored few commits later but has not been
> restored in the rte_eth_stats structure. Add it back.
> 
> Fixes: 4eadb8ba11b7 ("ethdev: do not deprecate imissed counter")
> Cc: stable@dpdk.org
> 
> Signed-off-by: Thibaut Collet <thibaut.collet@6wind.com>
> Signed-off-by: Olivier Matz <olivier.matz@6wind.com>

Reviewed-by: Ferruh Yigit <ferruh.yigit@intel.com>
Ferruh Yigit Dec. 16, 2017, 2:12 a.m. UTC | #2 
On 12/14/2017 9:41 AM, Ferruh Yigit wrote:
> On 12/14/2017 6:23 AM, Olivier Matz wrote:
>> imissed counter has been set as deprecated in commit 49f386542af4
>> ("ethdev: remove driver specific stats") and removed from the
>> rte_eth_xstats_name_off structure.
>>
>> The imissed counter has been restored few commits later but has not been
>> restored in the rte_eth_stats structure. Add it back.
>>
>> Fixes: 4eadb8ba11b7 ("ethdev: do not deprecate imissed counter")
>> Cc: stable@dpdk.org
>>
>> Signed-off-by: Thibaut Collet <thibaut.collet@6wind.com>
>> Signed-off-by: Olivier Matz <olivier.matz@6wind.com>
> 
> Reviewed-by: Ferruh Yigit <ferruh.yigit@intel.com>

Applied to dpdk-next-net/master, thanks.
diff mbox

Patch

diff --git a/lib/librte_ether/rte_ethdev.c b/lib/librte_ether/rte_ethdev.c
index 318af2869..4f492e3db 100644
--- a/lib/librte_ether/rte_ethdev.c
+++ b/lib/librte_ether/rte_ethdev.c
@@ -93,6 +93,7 @@  static const struct rte_eth_xstats_name_off rte_stats_strings[] = {
 	{"tx_good_packets", offsetof(struct rte_eth_stats, opackets)},
 	{"rx_good_bytes", offsetof(struct rte_eth_stats, ibytes)},
 	{"tx_good_bytes", offsetof(struct rte_eth_stats, obytes)},
+	{"rx_missed_errors", offsetof(struct rte_eth_stats, imissed)},
 	{"rx_errors", offsetof(struct rte_eth_stats, ierrors)},
 	{"tx_errors", offsetof(struct rte_eth_stats, oerrors)},
 	{"rx_mbuf_allocation_errors", offsetof(struct rte_eth_stats,