[dpdk-dev] meson: add tests to build

Message ID 20171219173131.25125-1-kevin.laatz@intel.com (mailing list archive)
State Superseded, archived
Delegated to: Bruce Richardson
Headers

Checks

Context Check Description
ci/checkpatch success coding style OK
ci/Intel-compilation success Compilation OK

Commit Message

Kevin Laatz Dec. 19, 2017, 5:31 p.m. UTC
  This commit adds most of the remaining tests to the meson build.
They can be run using test binary as normal.

Signed-off-by: Kevin Laatz <kevin.laatz@intel.com>
---
 test/test/meson.build | 17 +++++++++++++++++
 1 file changed, 17 insertions(+)
  

Comments

Kevin Laatz Dec. 19, 2017, 5:36 p.m. UTC | #1
> From: Laatz, Kevin
> Sent: Tuesday, December 19, 2017 5:32 PM
> To: dev@dpdk.org
> Cc: Richardson, Bruce <bruce.richardson@intel.com>; Laatz, Kevin
> <kevin.laatz@intel.com>
> Subject: [PATCH] meson: add tests to build
> 
> This commit adds most of the remaining tests to the meson build.
> They can be run using test binary as normal.
> 

Just a side note that this patch applies on top of the previous meson test patch, see here http://dpdk.org/dev/patchwork/patch/32357/ 

<snip>
  
Van Haaren, Harry Dec. 20, 2017, 10:14 a.m. UTC | #2
> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Kevin Laatz
> Sent: Tuesday, December 19, 2017 5:32 PM
> To: dev@dpdk.org
> Cc: Richardson, Bruce <bruce.richardson@intel.com>; Laatz, Kevin
> <kevin.laatz@intel.com>
> Subject: [dpdk-dev] [PATCH] meson: add tests to build
> 
> This commit adds most of the remaining tests to the meson build.
> They can be run using test binary as normal.


Cool, thanks for adding more tests!


> Signed-off-by: Kevin Laatz <kevin.laatz@intel.com>
> ---
>  test/test/meson.build | 17 +++++++++++++++++
>  1 file changed, 17 insertions(+)
> 
> diff --git a/test/test/meson.build b/test/test/meson.build
> index 1a4f894..a9bc2f6 100644
> --- a/test/test/meson.build
> +++ b/test/test/meson.build
> @@ -47,6 +47,8 @@ test_sources = files('commands.c',
>  	'test_common.c',
>  	'test_cpuflags.c',
>  	'test_crc.c',
> +	'test_cryptodev.c',
> +	'test_cryptodev_blockcipher.c',


Each of the test files here exports a number of actual test cases, eg:
RTE>> cryptodev_null_autotest  and similar. These test cases should be
added to the list called "test_names" in the same file - so Meson knows
about the tests.

There was talk of refactoring away this list totally - and that would
be good - but for now we're best to keep it in sync with the available
tests.

Apart from the above, the patch looks good to me! Will Review/Ack a v2.

<snip>
  

Patch

diff --git a/test/test/meson.build b/test/test/meson.build
index 1a4f894..a9bc2f6 100644
--- a/test/test/meson.build
+++ b/test/test/meson.build
@@ -47,6 +47,8 @@  test_sources = files('commands.c',
 	'test_common.c',
 	'test_cpuflags.c',
 	'test_crc.c',
+	'test_cryptodev.c',
+	'test_cryptodev_blockcipher.c',
 	'test_cycles.c',
 	'test_debug.c',
 	'test_devargs.c',
@@ -62,6 +64,7 @@  test_sources = files('commands.c',
 	'test_eventdev_octeontx.c',
 	'test_eventdev_sw.c',
 	'test_func_reentrancy.c',
+	'test_flow_classify.c',
 	'test_hash.c',
 	'test_hash_functions.c',
 	'test_hash_multiwriter.c',
@@ -70,6 +73,8 @@  test_sources = files('commands.c',
 	'test_interrupts.c',
 	'test_kni.c',
 	'test_kvargs.c',
+	'test_link_bonding.c',
+	'test_link_bonding_mode4.c',
 	'test_logs.c',
 	'test_lpm.c',
 	'test_lpm6.c',
@@ -77,6 +82,8 @@  test_sources = files('commands.c',
 	'test_lpm_perf.c',
 	'test_malloc.c',
 	'test_mbuf.c',
+	'test_member.c',
+	'test_member_perf.c',
 	'test_memcpy.c',
 	'test_memcpy_perf.c',
 	'test_memory.c',
@@ -87,6 +94,8 @@  test_sources = files('commands.c',
 	'test_mp_secondary.c',
 	'test_per_lcore.c',
 	'test_pmd_perf.c',
+	'test_pmd_ring.c',
+	'test_pmd_ring_perf.c',
 	'test_power.c',
 	'test_power_acpi_cpufreq.c',
 	'test_power_kvm_vm.c',
@@ -123,8 +132,10 @@  test_deps = ['acl',
 	'efd',
 	'ethdev',
 	'eventdev',
+	'flow_classify',
 	'hash',
 	'lpm',
+	'member',
 	'pipeline',
 	'port',
 	'power',
@@ -215,6 +226,12 @@  endif
 if dpdk_conf.has('RTE_LIBRTE_IXGBE_PMD')
 	test_deps += 'pmd_ixgbe'
 endif
+if dpdk_conf.has('RTE_LIBRTE_BOND_PMD')
+	test_deps += 'pmd_bond'
+endif
+if dpdk_conf.has('RTE_LIBRTE_RING_PMD')
+	test_deps += 'pmd_ring'
+endif
 
 test_dep_objs = []
 foreach d:test_deps