[dpdk-dev] doc: add queue region feature info to release notes
Checks
Commit Message
This patch add inforation about i40e queue region
realted to release notes, it has been missed before.
Signed-off-by: Wei Zhao <wei.zhao1@intel.com>
---
doc/guides/rel_notes/release_17_11.rst | 17 +++++++++++++++++
1 file changed, 17 insertions(+)
Comments
On 12/20/2017 7:52 PM, Wei Zhao wrote:
> This patch add inforation about i40e queue region
> realted to release notes, it has been missed before.
>
> Signed-off-by: Wei Zhao <wei.zhao1@intel.com>
> ---
> doc/guides/rel_notes/release_17_11.rst | 17 +++++++++++++++++
I think we shouldn't update release notes once it has been released.
Perhaps it can be an option to mention from this in latest release notes with a
note that says actual support added in v17.11?
Ok, this will be updating in release notes for v18.02,
and have a mention that this feature has been implemented in v17.11?
> -----Original Message-----
> From: Yigit, Ferruh
> Sent: Friday, December 22, 2017 2:10 AM
> To: Zhao1, Wei <wei.zhao1@intel.com>; dev@dpdk.org
> Cc: Mcnamara, John <john.mcnamara@intel.com>
> Subject: Re: [dpdk-dev] [PATCH] doc: add queue region feature info to
> release notes
>
> On 12/20/2017 7:52 PM, Wei Zhao wrote:
> > This patch add inforation about i40e queue region realted to release
> > notes, it has been missed before.
> >
> > Signed-off-by: Wei Zhao <wei.zhao1@intel.com>
> > ---
> > doc/guides/rel_notes/release_17_11.rst | 17 +++++++++++++++++
>
> I think we shouldn't update release notes once it has been released.
>
> Perhaps it can be an option to mention from this in latest release notes with
> a note that says actual support added in v17.11?
On 12/21/2017 5:36 PM, Zhao1, Wei wrote:
> Ok, this will be updating in release notes for v18.02,
> and have a mention that this feature has been implemented in v17.11?
I think mentioning from first implemented release helps to reduce confusion, in
case users interested in implementation details etc... But no strong opinion.
>
>
>
>> -----Original Message-----
>> From: Yigit, Ferruh
>> Sent: Friday, December 22, 2017 2:10 AM
>> To: Zhao1, Wei <wei.zhao1@intel.com>; dev@dpdk.org
>> Cc: Mcnamara, John <john.mcnamara@intel.com>
>> Subject: Re: [dpdk-dev] [PATCH] doc: add queue region feature info to
>> release notes
>>
>> On 12/20/2017 7:52 PM, Wei Zhao wrote:
>>> This patch add inforation about i40e queue region realted to release
>>> notes, it has been missed before.
>>>
>>> Signed-off-by: Wei Zhao <wei.zhao1@intel.com>
>>> ---
>>> doc/guides/rel_notes/release_17_11.rst | 17 +++++++++++++++++
>>
>> I think we shouldn't update release notes once it has been released.
>>
>> Perhaps it can be an option to mention from this in latest release notes with
>> a note that says actual support added in v17.11?
Ok， I will commit a new patch as this way.
> -----Original Message-----
> From: Yigit, Ferruh
> Sent: Friday, December 22, 2017 11:26 AM
> To: Zhao1, Wei <wei.zhao1@intel.com>; dev@dpdk.org
> Cc: Mcnamara, John <john.mcnamara@intel.com>; Zhang, Helin
> <helin.zhang@intel.com>
> Subject: Re: [dpdk-dev] [PATCH] doc: add queue region feature info to
> release notes
>
> On 12/21/2017 5:36 PM, Zhao1, Wei wrote:
> > Ok, this will be updating in release notes for v18.02, and have a
> > mention that this feature has been implemented in v17.11?
>
> I think mentioning from first implemented release helps to reduce confusion,
> in case users interested in implementation details etc... But no strong opinion.
>
> >
> >
> >
> >> -----Original Message-----
> >> From: Yigit, Ferruh
> >> Sent: Friday, December 22, 2017 2:10 AM
> >> To: Zhao1, Wei <wei.zhao1@intel.com>; dev@dpdk.org
> >> Cc: Mcnamara, John <john.mcnamara@intel.com>
> >> Subject: Re: [dpdk-dev] [PATCH] doc: add queue region feature info to
> >> release notes
> >>
> >> On 12/20/2017 7:52 PM, Wei Zhao wrote:
> >>> This patch add inforation about i40e queue region realted to release
> >>> notes, it has been missed before.
> >>>
> >>> Signed-off-by: Wei Zhao <wei.zhao1@intel.com>
> >>> ---
> >>> doc/guides/rel_notes/release_17_11.rst | 17 +++++++++++++++++
> >>
> >> I think we shouldn't update release notes once it has been released.
> >>
> >> Perhaps it can be an option to mention from this in latest release
> >> notes with a note that says actual support added in v17.11?
21/12/2017 19:10, Ferruh Yigit:
> On 12/20/2017 7:52 PM, Wei Zhao wrote:
> > This patch add inforation about i40e queue region
> > realted to release notes, it has been missed before.
> >
> > Signed-off-by: Wei Zhao <wei.zhao1@intel.com>
> > ---
> > doc/guides/rel_notes/release_17_11.rst | 17 +++++++++++++++++
>
> I think we shouldn't update release notes once it has been released.
>
> Perhaps it can be an option to mention from this in latest release notes with a
> note that says actual support added in v17.11?
I disagree.
It is really confusing to add 17.11 feature in 18.02 release notes.
It is better to add it in 17.11 release notes and backport it.
Please Ferruh, could you remove the patch v2 updating release_18_02.rst
from next-net?
On 1/16/2018 11:27 AM, Thomas Monjalon wrote:
> 21/12/2017 19:10, Ferruh Yigit:
>> On 12/20/2017 7:52 PM, Wei Zhao wrote:
>>> This patch add inforation about i40e queue region
>>> realted to release notes, it has been missed before.
>>>
>>> Signed-off-by: Wei Zhao <wei.zhao1@intel.com>
>>> ---
>>> doc/guides/rel_notes/release_17_11.rst | 17 +++++++++++++++++
>>
>> I think we shouldn't update release notes once it has been released.
>>
>> Perhaps it can be an option to mention from this in latest release notes with a
>> note that says actual support added in v17.11?
>
> I disagree.
> It is really confusing to add 17.11 feature in 18.02 release notes.
> It is better to add it in 17.11 release notes and backport it.
>
> Please Ferruh, could you remove the patch v2 updating release_18_02.rst
> from next-net?
Updating a release notes after release looks wrong to me. But I will update the
repo to move this into 17.11 release notes, no patch required.
And there is one more similar update, I guess that should be updated too, I will
check it as well.
On 1/16/2018 11:49 AM, Ferruh Yigit wrote:
> On 1/16/2018 11:27 AM, Thomas Monjalon wrote:
>> 21/12/2017 19:10, Ferruh Yigit:
>>> On 12/20/2017 7:52 PM, Wei Zhao wrote:
>>>> This patch add inforation about i40e queue region
>>>> realted to release notes, it has been missed before.
>>>>
>>>> Signed-off-by: Wei Zhao <wei.zhao1@intel.com>
>>>> ---
>>>> doc/guides/rel_notes/release_17_11.rst | 17 +++++++++++++++++
>>>
>>> I think we shouldn't update release notes once it has been released.
>>>
>>> Perhaps it can be an option to mention from this in latest release notes with a
>>> note that says actual support added in v17.11?
>>
>> I disagree.
>> It is really confusing to add 17.11 feature in 18.02 release notes.
>> It is better to add it in 17.11 release notes and backport it.
>>
>> Please Ferruh, could you remove the patch v2 updating release_18_02.rst
>> from next-net?
>
> Updating a release notes after release looks wrong to me. But I will update the
> repo to move this into 17.11 release notes, no patch required.
>
> And there is one more similar update, I guess that should be updated too, I will
> check it as well.
Other one is following:
https://dpdk.org/dev/patchwork/patch/33283/
Updated those two commits to edit v17.11 release notes instead of v18.02.
16/01/2018 17:01, Ferruh Yigit:
> On 1/16/2018 11:49 AM, Ferruh Yigit wrote:
> > On 1/16/2018 11:27 AM, Thomas Monjalon wrote:
> >> 21/12/2017 19:10, Ferruh Yigit:
> >>> On 12/20/2017 7:52 PM, Wei Zhao wrote:
> >>>> This patch add inforation about i40e queue region
> >>>> realted to release notes, it has been missed before.
> >>>>
> >>>> Signed-off-by: Wei Zhao <wei.zhao1@intel.com>
> >>>> ---
> >>>> doc/guides/rel_notes/release_17_11.rst | 17 +++++++++++++++++
> >>>
> >>> I think we shouldn't update release notes once it has been released.
> >>>
> >>> Perhaps it can be an option to mention from this in latest release notes with a
> >>> note that says actual support added in v17.11?
> >>
> >> I disagree.
> >> It is really confusing to add 17.11 feature in 18.02 release notes.
> >> It is better to add it in 17.11 release notes and backport it.
> >>
> >> Please Ferruh, could you remove the patch v2 updating release_18_02.rst
> >> from next-net?
> >
> > Updating a release notes after release looks wrong to me. But I will update the
> > repo to move this into 17.11 release notes, no patch required.
> >
> > And there is one more similar update, I guess that should be updated too, I will
> > check it as well.
>
> Other one is following:
> https://dpdk.org/dev/patchwork/patch/33283/
>
> Updated those two commits to edit v17.11 release notes instead of v18.02.
Thanks
@@ -210,6 +210,23 @@ New Features
Updated ixgbe ethernet PMD to support ``rte_security`` inline IPSec offload.
+* **Added the i40e ethernet driver to support queue region feature.**
+
+ This feature enable queue regions configuration for RSS in PF,
+ so that different traffic classes or different packet
+ classification types can be separated to different queues in
+ different queue regions.
+
+* **Added the testpmd app to support queue region configuration with CLI.**
+
+ This patch add a API configuration of queue region in rss with command line.
+ It can parse the parameters of region index, queue number,
+ queue start index, user priority, traffic classes and so on.
+ According to commands from command line, it will call i40e
+ private API and start the process of set or flush queue region
+ configure. As this feature is specific for i40e, so private API
+ will be used. Aslo add a document for these new commands.
+
* **Updated ipsec-secgw application to support rte_security.**
Updated the ``ipsec-secgw`` sample application to support ``rte_security``