diff mbox

[dpdk-dev,v2] tap: remove unused KERNEL_VERSION definitions

Message ID 20171227182836.29136-1-stephen@networkplumber.org (mailing list archive)
State Accepted, archived
Delegated to: Ferruh Yigit
Headers

Checks

Context Check Description
ci/checkpatch success coding style OK
ci/Intel-compilation success Compilation OK

Commit Message

Stephen Hemminger Dec. 27, 2017, 6:28 p.m. UTC 
  The TAP device does not use these definitions in current version.
And kernel version is not the correct way to detect features.

Signed-off-by: Stephen Hemminger <sthemmin@microsoft.com>
---
 drivers/net/tap/rte_eth_tap.c | 4 ----
 1 file changed, 4 deletions(-)

Comments

Ferruh Yigit Jan. 12, 2018, 6:14 p.m. UTC | #1 
On 12/27/2017 6:28 PM, Stephen Hemminger wrote:
> The TAP device does not use these definitions in current version.
> And kernel version is not the correct way to detect features.
> 
> Signed-off-by: Stephen Hemminger <sthemmin@microsoft.com>

    Fixes: 7c2d03d65f5e ("net/tap: remove Linux version check")
    Cc: stable@dpdk.org

Reviewed-by: Ferruh Yigit <ferruh.yigit@intel.com>
Ferruh Yigit Jan. 12, 2018, 6:16 p.m. UTC | #2 
On 1/12/2018 6:14 PM, Ferruh Yigit wrote:
> On 12/27/2017 6:28 PM, Stephen Hemminger wrote:
>> The TAP device does not use these definitions in current version.
>> And kernel version is not the correct way to detect features.
>>
>> Signed-off-by: Stephen Hemminger <sthemmin@microsoft.com>
> 
>     Fixes: 7c2d03d65f5e ("net/tap: remove Linux version check")
>     Cc: stable@dpdk.org
> 
> Reviewed-by: Ferruh Yigit <ferruh.yigit@intel.com>

Applied to dpdk-next-net/master, thanks.
diff mbox

Patch

diff --git a/drivers/net/tap/rte_eth_tap.c b/drivers/net/tap/rte_eth_tap.c
index 6b27679a8ea3..340ebe59b6ad 100644
--- a/drivers/net/tap/rte_eth_tap.c
+++ b/drivers/net/tap/rte_eth_tap.c
@@ -60,7 +60,6 @@ 
 #include <net/if.h>
 #include <linux/if_tun.h>
 #include <linux/if_ether.h>
-#include <linux/version.h>
 #include <fcntl.h>
 
 #include <rte_eth_tap.h>
@@ -78,9 +77,6 @@ 
 #define ETH_TAP_MAC_ARG         "mac"
 #define ETH_TAP_MAC_FIXED       "fixed"
 
-#define FLOWER_KERNEL_VERSION KERNEL_VERSION(4, 2, 0)
-#define FLOWER_VLAN_KERNEL_VERSION KERNEL_VERSION(4, 9, 0)
-
 static struct rte_vdev_driver pmd_tap_drv;
 
 static const char *valid_arguments[] = {