[dpdk-dev,v3] app/testpmd: fix port_id alloction issue
Checks
Commit Message
In the feature of increasing port_id range from 8 bits to 16 bits,
vlan port_id allocation function was forget to substitute UINT8 with
UINT16, so the vlan port_id was allocated as a inccrete number.
Fixes:28caa76aea71 ("app/testpmd: fix port id type")
Signed-off-by: Yanglong Wu <yanglong.wu@intel.com>
Reviewed-by: Zhiyong Yang <zhiyong.yang@intel.com>
---
v2:
modified commit message
---
v3:
add review tag
---
app/test-pmd/cmdline.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
Comments
Hi,
> -----Original Message-----
> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Yanglong Wu
> Sent: Tuesday, January 2, 2018 1:36 PM
> To: dev@dpdk.org
> Cc: Yang, Zhiyong <zhiyong.yang@intel.com>; Wu, Yanglong
> <yanglong.wu@intel.com>
> Subject: [dpdk-dev] [PATCH v3] app/testpmd: fix port_id alloction issue
>
> In the feature of increasing port_id range from 8 bits to 16 bits, vlan port_id
> allocation function was forget to substitute UINT8 with UINT16, so the vlan
> port_id was allocated as a inccrete number.
>
> Fixes:28caa76aea71 ("app/testpmd: fix port id type")
>
> Signed-off-by: Yanglong Wu <yanglong.wu@intel.com>
> Reviewed-by: Zhiyong Yang <zhiyong.yang@intel.com>
Acked-by: Wenzhuo Lu <wenzhuo.lu@intel.com>
> > In the feature of increasing port_id range from 8 bits to 16 bits, vlan port_id
> > allocation function was forget to substitute UINT8 with UINT16, so the vlan
> > port_id was allocated as a inccrete number.
> >
> > Fixes:28caa76aea71 ("app/testpmd: fix port id type")
Cc: stable@dpdk.org
> > Signed-off-by: Yanglong Wu <yanglong.wu@intel.com>
> > Reviewed-by: Zhiyong Yang <zhiyong.yang@intel.com>
> Acked-by: Wenzhuo Lu <wenzhuo.lu@intel.com>
Applied, thanks
@@ -3352,7 +3352,7 @@ cmdline_parse_token_num_t cmd_vlan_tpid_tpid =
tp_id, UINT16);
cmdline_parse_token_num_t cmd_vlan_tpid_portid =
TOKEN_NUM_INITIALIZER(struct cmd_vlan_tpid_result,
- port_id, UINT8);
+ port_id, UINT16);
cmdline_parse_inst_t cmd_vlan_tpid = {
.f = cmd_vlan_tpid_parsed,