[dpdk-dev] bus/fslmc: change the eqcr stashing threshold to 1

Message ID 1514993944-11940-1-git-send-email-nipun.gupta@nxp.com (mailing list archive)
State Accepted, archived
Delegated to: Thomas Monjalon
Headers

Checks

Context Check Description
ci/checkpatch success coding style OK
ci/Intel-compilation success Compilation OK

Commit Message

Nipun Gupta Jan. 3, 2018, 3:39 p.m. UTC
  Changing the EQCR stashing threshold boosts the performance
of l3fwd application on LS2088 by more than 20% as it helps
in burst packet processing at the Tx side. CPU is immediately
informed about the empty EQCR entries once consumed by the
hardware.

Signed-off-by: Nipun Gupta <nipun.gupta@nxp.com>
---
 drivers/bus/fslmc/qbman/qbman_sys.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
  

Comments

Shreyansh Jain Jan. 5, 2018, 11:23 a.m. UTC | #1
On Wednesday 03 January 2018 09:09 PM, Nipun Gupta wrote:
> Changing the EQCR stashing threshold boosts the performance
> of l3fwd application on LS2088 by more than 20% as it helps
> in burst packet processing at the Tx side. CPU is immediately
> informed about the empty EQCR entries once consumed by the
> hardware.
> 
> Signed-off-by: Nipun Gupta <nipun.gupta@nxp.com>
> ---
>   drivers/bus/fslmc/qbman/qbman_sys.h | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)

Acked-by: Shreyansh Jain <shreyansh.jain@nxp.com>
  
Thomas Monjalon Jan. 12, 2018, 11:47 a.m. UTC | #2
05/01/2018 12:23, Shreyansh Jain:
> On Wednesday 03 January 2018 09:09 PM, Nipun Gupta wrote:
> > Changing the EQCR stashing threshold boosts the performance
> > of l3fwd application on LS2088 by more than 20% as it helps
> > in burst packet processing at the Tx side. CPU is immediately
> > informed about the empty EQCR entries once consumed by the
> > hardware.
> > 
> > Signed-off-by: Nipun Gupta <nipun.gupta@nxp.com>
> 
> Acked-by: Shreyansh Jain <shreyansh.jain@nxp.com>

Applied, thanks
  

Patch

diff --git a/drivers/bus/fslmc/qbman/qbman_sys.h b/drivers/bus/fslmc/qbman/qbman_sys.h
index c216e9c..d2253bd 100644
--- a/drivers/bus/fslmc/qbman/qbman_sys.h
+++ b/drivers/bus/fslmc/qbman/qbman_sys.h
@@ -358,7 +358,7 @@  static inline int qbman_swp_sys_init(struct qbman_swp_sys *s,
 		reg = qbman_set_swp_cfg(dqrr_size, 0, 0, 3, 2, 3, 1, 1, 1, 1,
 					1, 1);
 	else
-		reg = qbman_set_swp_cfg(dqrr_size, 0, 2, 3, 2, 2, 1, 1, 1, 1,
+		reg = qbman_set_swp_cfg(dqrr_size, 0, 1, 3, 2, 2, 1, 1, 1, 1,
 					1, 1);
 	qbman_cinh_write(s, QBMAN_CINH_SWP_CFG, reg);
 	reg = qbman_cinh_read(s, QBMAN_CINH_SWP_CFG);