diff mbox

[dpdk-dev] devtools: ignore checkpatch warning for maintainers file

Message ID 20180105114302.21635-1-thomas@monjalon.net (mailing list archive)
State Accepted, archived
Delegated to: Thomas Monjalon
Headers

Checks

Context Check Description
ci/checkpatch warning coding style issues
ci/Intel-compilation success Compilation OK

Commit Message

Thomas Monjalon Jan. 5, 2018, 11:43 a.m. UTC 
  The script checkpatch.pl from Linux is enforcing a tab
in the MAINTAINERS file (Linux commit 628f91a28649).
It can be ignored in our wrapper checkpatches.sh.

Suggested-by: Remy Horton <remy.horton@intel.com>
Signed-off-by: Thomas Monjalon <thomas@monjalon.net>
---
 devtools/checkpatches.sh | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

Comments

Remy Horton Jan. 5, 2018, 3:30 p.m. UTC | #1 
On 05/01/2018 11:43, Thomas Monjalon wrote:
> The script checkpatch.pl from Linux is enforcing a tab
> in the MAINTAINERS file (Linux commit 628f91a28649).
> It can be ignored in our wrapper checkpatches.sh.
>
> Suggested-by: Remy Horton <remy.horton@intel.com>
> Signed-off-by: Thomas Monjalon <thomas@monjalon.net>
> ---
>  devtools/checkpatches.sh | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)

Acked-by: Remy Horton <remy.horton@intel.com>
Stephen Hemminger Jan. 5, 2018, 10:33 p.m. UTC | #2 
On Fri,  5 Jan 2018 12:43:02 +0100
Thomas Monjalon <thomas@monjalon.net> wrote:

> The script checkpatch.pl from Linux is enforcing a tab
> in the MAINTAINERS file (Linux commit 628f91a28649).
> It can be ignored in our wrapper checkpatches.sh.
> 
> Suggested-by: Remy Horton <remy.horton@intel.com>
> Signed-off-by: Thomas Monjalon <thomas@monjalon.net>
> ---
>  devtools/checkpatches.sh | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/devtools/checkpatches.sh b/devtools/checkpatches.sh
> index a56c41a30..7676a6b50 100755
> --- a/devtools/checkpatches.sh
> +++ b/devtools/checkpatches.sh
> @@ -41,7 +41,8 @@ length=${DPDK_CHECKPATCH_LINE_LENGTH:-80}
>  options="--no-tree"
>  options="$options --max-line-length=$length"
>  options="$options --show-types"
> -options="$options --ignore=LINUX_VERSION_CODE,FILE_PATH_CHANGES,\
> +options="$options --ignore=LINUX_VERSION_CODE,\
> +FILE_PATH_CHANGES,MAINTAINERS_STYLE,\
>  VOLATILE,PREFER_PACKED,PREFER_ALIGNED,PREFER_PRINTF,\
>  PREFER_KERNEL_TYPES,BIT_MACRO,CONST_STRUCT,\
>  SPLIT_STRING,LONG_LINE_STRING,\


Sure that is fine, just make it go away...

Acked-by: Stephen Hemminger <stephen@networkplumber.org>
Thomas Monjalon Jan. 9, 2018, 12:44 a.m. UTC | #3 
05/01/2018 23:33, Stephen Hemminger:
> On Fri,  5 Jan 2018 12:43:02 +0100
> Thomas Monjalon <thomas@monjalon.net> wrote:
> 
> > The script checkpatch.pl from Linux is enforcing a tab
> > in the MAINTAINERS file (Linux commit 628f91a28649).
> > It can be ignored in our wrapper checkpatches.sh.
> > 
> > Suggested-by: Remy Horton <remy.horton@intel.com>
> > Signed-off-by: Thomas Monjalon <thomas@monjalon.net>
> 
> Sure that is fine, just make it go away...
> 
> Acked-by: Stephen Hemminger <stephen@networkplumber.org>

Applie
diff mbox

Patch

diff --git a/devtools/checkpatches.sh b/devtools/checkpatches.sh
index a56c41a30..7676a6b50 100755
--- a/devtools/checkpatches.sh
+++ b/devtools/checkpatches.sh
@@ -41,7 +41,8 @@  length=${DPDK_CHECKPATCH_LINE_LENGTH:-80}
 options="--no-tree"
 options="$options --max-line-length=$length"
 options="$options --show-types"
-options="$options --ignore=LINUX_VERSION_CODE,FILE_PATH_CHANGES,\
+options="$options --ignore=LINUX_VERSION_CODE,\
+FILE_PATH_CHANGES,MAINTAINERS_STYLE,\
 VOLATILE,PREFER_PACKED,PREFER_ALIGNED,PREFER_PRINTF,\
 PREFER_KERNEL_TYPES,BIT_MACRO,CONST_STRUCT,\
 SPLIT_STRING,LONG_LINE_STRING,\