Message ID | 1515318351-4756-2-git-send-email-matan@mellanox.com (mailing list archive) |
---|---|
State | Superseded, archived |
Delegated to: | Ferruh Yigit |
Headers |
Return-Path: <dev-bounces@dpdk.org> X-Original-To: patchwork@dpdk.org Delivered-To: patchwork@dpdk.org Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 4ABE41B1A2; Sun, 7 Jan 2018 10:46:30 +0100 (CET) Received: from EUR01-HE1-obe.outbound.protection.outlook.com (mail-he1eur01on0043.outbound.protection.outlook.com [104.47.0.43]) by dpdk.org (Postfix) with ESMTP id 5CC9E1B04C; Sun, 7 Jan 2018 10:46:27 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=a6ZiDIrYY9p9b+bqZa/24E6Fwubkb5c0cUH+tGfPrWA=; b=tFo+b2PcGDb0nKPmoUHBEL+CGTQKcj99QMyMqywzzmKMeTgb+GDYtdLq3O+x+TnLJUwRoB61x/bQhx4RfGKNm3uo1JdI9Yrx9ix7z6EAePKHJ19WPmBVI8RLRixG6EpIkHAgqYz/ozWqaO94iReWj36Pi6yER7w2bStKUMviUL8= Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=matan@mellanox.com; Received: from mellanox.com (37.142.13.130) by AM0PR0502MB3793.eurprd05.prod.outlook.com (2603:10a6:208:1e::27) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.386.5; Sun, 7 Jan 2018 09:46:24 +0000 From: Matan Azrad <matan@mellanox.com> To: Thomas Monjalon <thomas@monjalon.net>, Gaetan Rivet <gaetan.rivet@6wind.com>, Jingjing Wu <jingjing.wu@intel.com> Cc: dev@dpdk.org, Neil Horman <nhorman@tuxdriver.com>, Bruce Richardson <bruce.richardson@intel.com>, Konstantin Ananyev <konstantin.ananyev@intel.com>, stable@dpdk.org Date: Sun, 7 Jan 2018 09:45:46 +0000 Message-Id: <1515318351-4756-2-git-send-email-matan@mellanox.com> X-Mailer: git-send-email 1.8.3.1 In-Reply-To: <1515318351-4756-1-git-send-email-matan@mellanox.com> References: <1511870281-15282-1-git-send-email-matan@mellanox.com> <1515318351-4756-1-git-send-email-matan@mellanox.com> MIME-Version: 1.0 Content-Type: text/plain X-Originating-IP: [37.142.13.130] X-ClientProxiedBy: DB3PR0202CA0016.eurprd02.prod.outlook.com (2603:10a6:8:1::29) To AM0PR0502MB3793.eurprd05.prod.outlook.com (2603:10a6:208:1e::27) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-HT: Tenant X-MS-Office365-Filtering-Correlation-Id: 6d131598-1cf5-41c0-c96b-08d555b384ad X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(48565401081)(4534020)(4602075)(4627115)(201703031133081)(201702281549075)(5600026)(4604075)(2017052603307)(7153060)(7193020); SRVR:AM0PR0502MB3793; X-Microsoft-Exchange-Diagnostics: 1; AM0PR0502MB3793; 3:BuwO5dxwIVT0FBGeFD0/qY3RfNoiyarTyNstPWzfs+veiV+1icYTBVvlO4Z/0hBBilEKEA7iJxll+OD8EhThk60qWqX42zpN8UH76hngfE4phXBz6sgKtJwoQ+wTAKxN+kjbFLPurKbBDKOcrQN5btGrjmdNIiCFfv3hl1Htr2SDGiOYSRDo+WGBpfIxWr9pdEisNOFMbyOL6A3+XV/cD77ZiWfEL28WltCFL2D9uvAMdAMb0NpYhoSgNi6JktuA; 25:W+uiz53w+jo/RJs4ySlh0uDIVpd/LXXSJE9+DdVDGMdQyhQtFsVHhmhISNaYH/FG7G6o7wAW5fKjwc1grLQEGZSxj1XHfyL4zRqwjWi26ym8TcwFCcPYn5ycbXbSJO1kQLUltKOgVBsioyB3vlLv7ceRSwb0RZgpRRVbH7JzjbpT/GoNpKqvI83rp/o4b55HZMLZOJF8Mhx4fyXtC57GP81xCfP06oHdQKqskEdFbGLPrL3ipAUNMLkXa9010eBfMMk2Cqi5CamAkETGmMptVLJIuAUGuchJLFVJvQ+Jdv+r3EVJkT2vrHbJz4qVefZotJmaH27kox8jSvkPzZXc4w==; 31:ZzC8kj/vweGHK1t4D0jqt3uYR3BZc0vvZfiO4qQTRFQcmM8ekkX4hsF6aafKLpfaSA3XX+hI662vEJ4iuDqymWvJLHhBLWGtndCQfCtpvpifItDcs0GmMnn6ighGtdPVmcE3/aztDFTCXywZcDwdqytn/rzVpWXaW962gk7l5RKAYxUPberMecH907ZUOXpjOpzv2LCvTS5Ov0UFjF4rTpbUT1jqyeL/okVIQGZILd4= X-MS-TrafficTypeDiagnostic: AM0PR0502MB3793: X-LD-Processed: a652971c-7d2e-4d9b-a6a4-d149256f461b,ExtAddr X-Microsoft-Exchange-Diagnostics: 1; AM0PR0502MB3793; 20:g5bJuh5MzxdxaL8O+pyibVbBV9Wmp+nUR0dv36DznF+WxjCvq5hoTSFroULosiEcy638V5Op2qF3lVws4zLizomLcDiQDn4kES4fAz5q5p6LvQHQm6Xi915dp2oj3F5SXeCAaxV2reRoDOG69Qklm+wUZavSbLw3jLibg1nNj7lObG1RmZyMo8dCxg5z35lgZ33O6Hxuj+CNuzr+xJODTiFqdrvS5mttT69S12hzmEOda/vXWooz50kCOrMtVAXp455+paxrwhQoec7yb7xv8KkTdjvEpVVu+fJ1OH8LYjj0tiVK/UA5Xc9zNR6Da9qbpj4BHB0XvyAokZyVCxd/xtXfbmBB8zQxnXsEN9vrzv7UhJ3+LqEVXLXrJPCvC6XoJIAvTNUxsHpAmPJTxom8oGOkPiqKbVsUnN3GYNQDfb9ATFQNN+2fdSyZACo4swlgu68m0O/F25HNMuJYI/YeepUtngl2AHFeKoKwS7abONBsyiIZodymFKUXJycetATe; 4:i1UqeNyu6XEALZl0/rxsC6LP6fnFDOfczdCQgm6l4yZEabRrPV4MSAFcMWlFrQu17hoVFyC0Y5jJazZPwp5znJoAcptuhCRAJ+UoosFgtPMyOXKgNZx8c7ZjNnQXRe7znN4nT6fQZm+HqLWTGlflfcTUuBj/1Jas1VWWV//v5SRRfHh6VeM3sUMR628FpjP1vxjCX02XeFJLY5OlEkcbwcXJYWC7UfD5rbcj1enbWreot2PGKpkE7n+eatVgr0B5OboxEp9b39wSS27YgD3c1Q== X-Microsoft-Antispam-PRVS: <AM0PR0502MB379376BD817D4FE2CF140947D2120@AM0PR0502MB3793.eurprd05.prod.outlook.com> X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(6040470)(2401047)(8121501046)(5005006)(3231023)(944501075)(3002001)(10201501046)(93006095)(93001095)(6055026)(6041268)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123560045)(20161123558120)(20161123562045)(20161123564045)(6072148)(201708071742011); SRVR:AM0PR0502MB3793; BCL:0; PCL:0; RULEID:(100000803101)(100110400095); SRVR:AM0PR0502MB3793; X-Forefront-PRVS: 0545EFAC9A X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(346002)(396003)(366004)(39860400002)(39380400002)(376002)(199004)(189003)(105586002)(66066001)(8676002)(305945005)(52116002)(47776003)(68736007)(7696005)(76176011)(7736002)(5890100001)(2950100002)(25786009)(81156014)(478600001)(69596002)(55016002)(106356001)(51416003)(48376002)(2906002)(4720700003)(6666003)(6116002)(81166006)(97736004)(59450400001)(50226002)(16586007)(54906003)(53936002)(33026002)(36756003)(50466002)(16526018)(5660300001)(4326008)(386003)(316002)(3846002)(21086003)(86362001)(110136005)(8936002); DIR:OUT; SFP:1101; SCL:1; SRVR:AM0PR0502MB3793; H:mellanox.com; FPR:; SPF:None; PTR:InfoNoRecords; A:1; MX:1; LANG:en; Received-SPF: None (protection.outlook.com: mellanox.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; AM0PR0502MB3793; 23:LWpV+a2Q5Hihfvi85hrIOBv1FRm/D5YhYfeWXlW?= z95yTWrfPVnDIzQ+BPT20Iew38AH8wp94YkdKuL0xdFB+s6UWTIKeAiCJ2ZhOGtE9+7sW2fzKSp4Y7LNW/wKK1E4Zem+KjZc2jHSzsa2ERUxJheHFB3F3aKF20oqPNIjJmI5zq+MqhAo8FBqanEZtnMQaB/lqh0EGsEfqFkAszf6PLfTCFMIvAEsMyYOpwQXiyl8XTiqXokcoAoS3ZLDSUhYjnu1VyJl+Oz+UCQFER3IDQLJcNjTyx2uyONLjYgte/kVBbTkgrO9b4AP9pAs9ewY6xS6LrN4Sz1Zz6V3rTLpgYx9sXSb4R82LXMI+Ca5u+NeEf0tpELc63GSuc59yckvRYOBTf/MalOdS2pE2sKhbcBWP2KZCN/DC5z7gnxLpFOlrFvoeP8fH1IyqSePldL9+RYI/+fnDQ/PxaV5Xwv/x0q4kWzXkw1qufl5rRuBf4mJoGhSWreKaR9zkMoNFn7k0LDzbNozKpGUKzk75ESRrgp3PYqFMyuxr1kKz2Y2i7dX0RStKhUblu9v0KdrW5cnghvybpkVS5/kEGMYNX+8MirV7QjLXiqm7dSoweo5utyqZa2cGlyEvlFaSCYY2s5Ye9IOdLAA4zngNI07hXn3iw7O8C+24Im2lHP8TaRmZ/IRouLdJqONG94CfHLL0GL7Ciw0BCCZxb61TN+KClKDqSmBZagacCCHdZmO0jniupLi8JRYB6vXGUIxOVsz6OnbuIL8/n1uK+RbVJyyEb/qm68Syu1yoMBUzRfSrrVwGolg4kKFhJ3FUArHeyLNSJTVOeRMs+qlGkK8Yn3Rfl3umU+VsAM4e2XVbZ6Q4AMBLACImv3YwrWKwlNoQcib74EtKNWjLUpZNzJhM2ExXtQyi5R6YWqIx02Ag1AvJ/HEZTz0/MTKHw0NQ5NI/JPCHabiZ+H36U9LAfdj8NAQdWZiJJUC/HWa1IymvbkJlRe2UwTmmNepgzRIZhC/RODZUJ4zKRRs7I5MYUm0WYvH/QLL5Hm2XGLFHy8vDJztdmjWulNcqm9vK7A172yAu/w3kKWbqLiszLGkCCNTNjfEbEKdLzQr9C/9mBOJeSmPOtGLfm/rl9sAFgeuqPAQ5Fc2hL1ZraD8X+Wp3gFbuKmIri177JgejU1BDBDHaKA7hQR9BMuYvohuQ69P7+VRciDArdY8xj8s2iFj4nwkZVf64VGEI6A== X-Microsoft-Exchange-Diagnostics: 1; AM0PR0502MB3793; 6:y+SqUEyLbvmgxxijt0UXf0TG2UcXIfCzbjlT3HsCjYhzb4Vx9q44E/ycZHJ/5m7xmbXf6QhBxDBtBemp8xsvyW+wfCII7JOAzrVwTo1sv3shriDGHxjhbYZ8ooZW9APRMFuWvfY2b5CbY35ESNVRYNObtDRa6V1qHOJsFzaOho5ZE+UddBUM+ySII+VJqhKHwkdb657S2HTwJhIRnqTGDHIvGk32z00QpkVTDRJHc2fwoeoshfYOglK+ZxbVIbQX8pIMPcUrS6Afwz5usYkSBHxK4g3cnAwcEDltxmCxnkhIwgnSj0bXpa6JSlB8FBZNsocOTgyjvVf8tnngutvEyi3+HtN/J5zKcpU7zp6k4qM=; 5:DyT957K9+bGq68edZt8BHyw6QEUGulivLhgE7K667S76dw+dhGZiBKGsu9o6Rfa/Z2wUvOW9ElLDpD+NdjiPC4t5F2RnwjU7YQgFYbkRYy4YuI2Pff4ImJa8JAZy1bwvrpgO4gaw0Oe+WD83yJInP2jKOULJzOIklZILSDQeWng=; 24:fSLHrvCUvF+sFBwlECdUFr8uTnc+yalH+FYkNjWXkrNsUGOg6bR4XEIPC+hqcoCE0rTl5ZxaTddNIzrFLEeX7XfYBjG84HOwTB80xK/ziIw=; 7:/89jwJJw3neMamaz6dz2OtoxsWQ42qX/Cz/f3I7x6xR65UQPbUV6MJjo5U899p+PTL2n0+pyhTle15ecLEMFlAlN5Rz36dwd4tQGhxXnl+qaITx/hCLAysRMPOGbe+1f9ivcdQq2kZYkgjj7IEdyLi0uKEII1ks7r4tO5GYwCk9Efs6Gbgl6eTlZnPoBSkrDpAlmC9cBKdytqbg23vTm2XEeMGcxQ+Rpm3dU6jgBIFFDEUWdOoVXH+WeL7FMBTT+ SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Jan 2018 09:46:24.5188 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 6d131598-1cf5-41c0-c96b-08d555b384ad X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR0502MB3793 Subject: [dpdk-dev] [PATCH v2 1/6] ethdev: fix port data reset timing X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://dpdk.org/ml/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://dpdk.org/ml/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://dpdk.org/ml/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> Errors-To: dev-bounces@dpdk.org Sender: "dev" <dev-bounces@dpdk.org> |
Checks
Context | Check | Description |
---|---|---|
ci/checkpatch | success | coding style OK |
ci/Intel-compilation | success | Compilation OK |
Commit Message
Matan Azrad
Jan. 7, 2018, 9:45 a.m. UTC
rte_eth_dev_data structure is allocated per ethdev port and can be
used to get a data of the port internally.
rte_eth_dev_attach_secondary tries to find the port identifier using
rte_eth_dev_data name field comparison and may get an identifier of
invalid port in case of this port was released by the primary process
because the port release API doesn't reset the port data.
So, it will be better to reset the port data in release time instead of
allocation time.
Move the port data reset to the port release API.
Fixes: d948f596fee2 ("ethdev: fix port data mismatched in multiple process model")
Cc: stable@dpdk.org
Signed-off-by: Matan Azrad <matan@mellanox.com>
---
lib/librte_ether/rte_ethdev.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/lib/librte_ether/rte_ethdev.c b/lib/librte_ether/rte_ethdev.c index d1385df..684e3e8 100644 --- a/lib/librte_ether/rte_ethdev.c +++ b/lib/librte_ether/rte_ethdev.c @@ -233,7 +233,6 @@ struct rte_eth_dev * return NULL; } - memset(&rte_eth_dev_data[port_id], 0, sizeof(struct rte_eth_dev_data)); eth_dev = eth_dev_get(port_id); snprintf(eth_dev->data->name, sizeof(eth_dev->data->name), "%s", name); eth_dev->data->port_id = port_id; @@ -279,6 +278,7 @@ struct rte_eth_dev * if (eth_dev == NULL) return -EINVAL; + memset(eth_dev->data, 0, sizeof(struct rte_eth_dev_data)); eth_dev->state = RTE_ETH_DEV_UNUSED; return 0; }