diff mbox

[dpdk-dev,v1] eal: remove use of 'register' keyword

Message ID 20180109161108.32533-1-avi@scylladb.com (mailing list archive)
State Accepted, archived
Headers

Checks

Context Check Description
ci/checkpatch success coding style OK
ci/Intel-compilation success Compilation OK

Commit Message

Avi Kivity Jan. 9, 2018, 4:11 p.m. UTC 
  The 'register' keyword does nothing, and has been removed in C++17.

Remove it for compatibility.

Signed-off-by: Avi Kivity <avi@scylladb.com>
---
 lib/librte_eal/common/include/arch/arm/rte_byteorder.h | 2 +-
 lib/librte_eal/common/include/arch/x86/rte_byteorder.h | 4 ++--
 2 files changed, 3 insertions(+), 3 deletions(-)

Comments

Thomas Monjalon Jan. 11, 2018, 10:57 p.m. UTC | #1 
09/01/2018 17:11, Avi Kivity:
> The 'register' keyword does nothing, and has been removed in C++17.
> 
> Remove it for compatibility.
> 
> Signed-off-by: Avi Kivity <avi@scylladb.com>

Applied, thanks
diff mbox

Patch

diff --git a/lib/librte_eal/common/include/arch/arm/rte_byteorder.h b/lib/librte_eal/common/include/arch/arm/rte_byteorder.h
index 0a29f4bb4..8af0a39ad 100644
--- a/lib/librte_eal/common/include/arch/arm/rte_byteorder.h
+++ b/lib/librte_eal/common/include/arch/arm/rte_byteorder.h
@@ -48,11 +48,11 @@  extern "C" {
 /* fix missing __builtin_bswap16 for gcc older then 4.8 */
 #if !(__GNUC__ > 4 || (__GNUC__ == 4 && __GNUC_MINOR__ >= 8))
 
 static inline uint16_t rte_arch_bswap16(uint16_t _x)
 {
-	register uint16_t x = _x;
+	uint16_t x = _x;
 
 	asm volatile ("rev16 %w0,%w1"
 		      : "=r" (x)
 		      : "r" (x)
 		      );
diff --git a/lib/librte_eal/common/include/arch/x86/rte_byteorder.h b/lib/librte_eal/common/include/arch/x86/rte_byteorder.h
index 1b8ed5f99..56b0a31e2 100644
--- a/lib/librte_eal/common/include/arch/x86/rte_byteorder.h
+++ b/lib/librte_eal/common/include/arch/x86/rte_byteorder.h
@@ -22,11 +22,11 @@  extern "C" {
  *
  * Do not use this function directly. The preferred function is rte_bswap16().
  */
 static inline uint16_t rte_arch_bswap16(uint16_t _x)
 {
-	register uint16_t x = _x;
+	uint16_t x = _x;
 	asm volatile ("xchgb %b[x1],%h[x2]"
 		      : [x1] "=Q" (x)
 		      : [x2] "0" (x)
 		      );
 	return x;
@@ -37,11 +37,11 @@  static inline uint16_t rte_arch_bswap16(uint16_t _x)
  *
  * Do not use this function directly. The preferred function is rte_bswap32().
  */
 static inline uint32_t rte_arch_bswap32(uint32_t _x)
 {
-	register uint32_t x = _x;
+	uint32_t x = _x;
 	asm volatile ("bswap %[x]"
 		      : [x] "+r" (x)
 		      );
 	return x;
 }