diff mbox

[dpdk-dev,v3] doc: ethdev ABI change deprecation notice

Message ID 1515752986-88775-1-git-send-email-kirill.rybalchenko@intel.com (mailing list archive)
State Accepted, archived
Delegated to: Thomas Monjalon
Headers

Checks

Context Check Description
ci/checkpatch success coding style OK
ci/Intel-compilation success Compilation OK

Commit Message

Rybalchenko, Kirill Jan. 12, 2018, 10:29 a.m. UTC 
  Signed-off-by: Kirill Rybalchenko <kirill.rybalchenko@intel.com>

Acked-by: Marko Kovacevic <marko.kovacevic@intel.com>
---
 doc/guides/rel_notes/deprecation.rst | 6 ++++++
 1 file changed, 6 insertions(+)

Comments

Neil Horman Jan. 12, 2018, 2:38 p.m. UTC | #1 
On Fri, Jan 12, 2018 at 10:29:46AM +0000, Kirill Rybalchenko wrote:
> Signed-off-by: Kirill Rybalchenko <kirill.rybalchenko@intel.com>
> 
> Acked-by: Marko Kovacevic <marko.kovacevic@intel.com>
> ---
>  doc/guides/rel_notes/deprecation.rst | 6 ++++++
>  1 file changed, 6 insertions(+)
> 
> diff --git a/doc/guides/rel_notes/deprecation.rst b/doc/guides/rel_notes/deprecation.rst
> index 13e8543..aaf306a 100644
> --- a/doc/guides/rel_notes/deprecation.rst
> +++ b/doc/guides/rel_notes/deprecation.rst
> @@ -45,6 +45,12 @@ Deprecation Notices
>    Target release for removal of the legacy API will be defined once most
>    PMDs have switched to rte_flow.
>  
> +* ethdev: announce ABI change
> +  The size of variables flow_types_mask in rte_eth_fdir_info structure,
> +  sym_hash_enable_mask and valid_bit_mask in rte_eth_hash_global_conf structure
> +  will be increased from 32 to 64 bits to fulfill hardware requirements.
> +  This change will break existing ABI as size of the structures will increase.
> +
>  * i40e: The default flexible payload configuration which extracts the first 16
>    bytes of the payload for RSS will be deprecated starting from 18.02. If
>    required the previous behavior can be configured using existing flow
> -- 
> 2.5.5
> 
> 
Acked-by: Neil Horman <nhorman@tuxdriver.com>
Ferruh Yigit Feb. 13, 2018, 12:09 p.m. UTC | #2 
On 1/12/2018 2:38 PM, Neil Horman wrote:
> On Fri, Jan 12, 2018 at 10:29:46AM +0000, Kirill Rybalchenko wrote:
>> Signed-off-by: Kirill Rybalchenko <kirill.rybalchenko@intel.com>
>>
>> Acked-by: Marko Kovacevic <marko.kovacevic@intel.com>
>> ---
>>  doc/guides/rel_notes/deprecation.rst | 6 ++++++
>>  1 file changed, 6 insertions(+)
>>
>> diff --git a/doc/guides/rel_notes/deprecation.rst b/doc/guides/rel_notes/deprecation.rst
>> index 13e8543..aaf306a 100644
>> --- a/doc/guides/rel_notes/deprecation.rst
>> +++ b/doc/guides/rel_notes/deprecation.rst
>> @@ -45,6 +45,12 @@ Deprecation Notices
>>    Target release for removal of the legacy API will be defined once most
>>    PMDs have switched to rte_flow.
>>  
>> +* ethdev: announce ABI change
>> +  The size of variables flow_types_mask in rte_eth_fdir_info structure,
>> +  sym_hash_enable_mask and valid_bit_mask in rte_eth_hash_global_conf structure
>> +  will be increased from 32 to 64 bits to fulfill hardware requirements.
>> +  This change will break existing ABI as size of the structures will increase.
>> +
>>  * i40e: The default flexible payload configuration which extracts the first 16
>>    bytes of the payload for RSS will be deprecated starting from 18.02. If
>>    required the previous behavior can be configured using existing flow
>> -- 
>> 2.5.5
>>
>>
> Acked-by: Neil Horman <nhorman@tuxdriver.com>

Acked-by: Ferruh Yigit <ferruh.yigit@intel.com>
Olivier Matz Feb. 13, 2018, 1:21 p.m. UTC | #3 
On Tue, Feb 13, 2018 at 12:09:19PM +0000, Ferruh Yigit wrote:
> On 1/12/2018 2:38 PM, Neil Horman wrote:
> > On Fri, Jan 12, 2018 at 10:29:46AM +0000, Kirill Rybalchenko wrote:
> >> Signed-off-by: Kirill Rybalchenko <kirill.rybalchenko@intel.com>
> >>
> >> Acked-by: Marko Kovacevic <marko.kovacevic@intel.com>
> >> ---
> >>  doc/guides/rel_notes/deprecation.rst | 6 ++++++
> >>  1 file changed, 6 insertions(+)
> >>
> >> diff --git a/doc/guides/rel_notes/deprecation.rst b/doc/guides/rel_notes/deprecation.rst
> >> index 13e8543..aaf306a 100644
> >> --- a/doc/guides/rel_notes/deprecation.rst
> >> +++ b/doc/guides/rel_notes/deprecation.rst
> >> @@ -45,6 +45,12 @@ Deprecation Notices
> >>    Target release for removal of the legacy API will be defined once most
> >>    PMDs have switched to rte_flow.
> >>  
> >> +* ethdev: announce ABI change
> >> +  The size of variables flow_types_mask in rte_eth_fdir_info structure,
> >> +  sym_hash_enable_mask and valid_bit_mask in rte_eth_hash_global_conf structure
> >> +  will be increased from 32 to 64 bits to fulfill hardware requirements.
> >> +  This change will break existing ABI as size of the structures will increase.
> >> +
> >>  * i40e: The default flexible payload configuration which extracts the first 16
> >>    bytes of the payload for RSS will be deprecated starting from 18.02. If
> >>    required the previous behavior can be configured using existing flow
> >> -- 
> >> 2.5.5
> >>
> >>
> > Acked-by: Neil Horman <nhorman@tuxdriver.com>
> 
> Acked-by: Ferruh Yigit <ferruh.yigit@intel.com>

Acked-by: Olivier Matz <olivier.matz@6wind.com>
Thomas Monjalon Feb. 14, 2018, 12:14 a.m. UTC | #4 
> > >> Signed-off-by: Kirill Rybalchenko <kirill.rybalchenko@intel.com>
> > >>
> > >> Acked-by: Marko Kovacevic <marko.kovacevic@intel.com>
> > >> ---
> > >> +* ethdev: announce ABI change
> > >> +  The size of variables flow_types_mask in rte_eth_fdir_info structure,
> > >> +  sym_hash_enable_mask and valid_bit_mask in rte_eth_hash_global_conf structure
> > >> +  will be increased from 32 to 64 bits to fulfill hardware requirements.
> > >> +  This change will break existing ABI as size of the structures will increase.
> > >> +
> > > Acked-by: Neil Horman <nhorman@tuxdriver.com>
> > 
> > Acked-by: Ferruh Yigit <ferruh.yigit@intel.com>
> 
> Acked-by: Olivier Matz <olivier.matz@6wind.com>

Acked-by: Thomas Monjalon <thomas@monjalon.net>

I would prefer you drop the legacy code to keep only rte_flow.
Thomas Monjalon Feb. 14, 2018, 5:18 p.m. UTC | #5 
14/02/2018 01:14, Thomas Monjalon:
> > > >> Signed-off-by: Kirill Rybalchenko <kirill.rybalchenko@intel.com>
> > > >>
> > > >> Acked-by: Marko Kovacevic <marko.kovacevic@intel.com>
> > > >> ---
> > > >> +* ethdev: announce ABI change
> > > >> +  The size of variables flow_types_mask in rte_eth_fdir_info structure,
> > > >> +  sym_hash_enable_mask and valid_bit_mask in rte_eth_hash_global_conf structure
> > > >> +  will be increased from 32 to 64 bits to fulfill hardware requirements.
> > > >> +  This change will break existing ABI as size of the structures will increase.
> > > >> +
> > > > Acked-by: Neil Horman <nhorman@tuxdriver.com>
> > > 
> > > Acked-by: Ferruh Yigit <ferruh.yigit@intel.com>
> > 
> > Acked-by: Olivier Matz <olivier.matz@6wind.com>
> 
> Acked-by: Thomas Monjalon <thomas@monjalon.net>
> 
> I would prefer you drop the legacy code to keep only rte_flow.

Applied
diff mbox

Patch

diff --git a/doc/guides/rel_notes/deprecation.rst b/doc/guides/rel_notes/deprecation.rst
index 13e8543..aaf306a 100644
--- a/doc/guides/rel_notes/deprecation.rst
+++ b/doc/guides/rel_notes/deprecation.rst
@@ -45,6 +45,12 @@  Deprecation Notices
   Target release for removal of the legacy API will be defined once most
   PMDs have switched to rte_flow.
 
+* ethdev: announce ABI change
+  The size of variables flow_types_mask in rte_eth_fdir_info structure,
+  sym_hash_enable_mask and valid_bit_mask in rte_eth_hash_global_conf structure
+  will be increased from 32 to 64 bits to fulfill hardware requirements.
+  This change will break existing ABI as size of the structures will increase.
+
 * i40e: The default flexible payload configuration which extracts the first 16
   bytes of the payload for RSS will be deprecated starting from 18.02. If
   required the previous behavior can be configured using existing flow