diff mbox

[dpdk-dev,v2] app/procinfo: add compilation option in config file

Message ID 4a54e295890a75b513176c62f83f87b67817baa4.1515777134.git.anatoly.burakov@intel.com (mailing list archive)
State Superseded, archived
Delegated to: Thomas Monjalon
Headers

Checks

Context Check Description
ci/checkpatch success coding style OK
ci/Intel-compilation success Compilation OK

Commit Message

Anatoly Burakov Jan. 12, 2018, 5:49 p.m. UTC 
  Unlike every other DPDK application's compilation, proc_info's
compilation cannot be turned off on Linux. Fix it by adding a
config option to base linuxapp config.

Fixes: 22561383ea17 ("app: replace dump_cfg by proc_info")
Cc: maryam.tahhan@intel.com
Cc: stable@dpdk.org
Signed-off-by: Anatoly Burakov <anatoly.burakov@intel.com>
---
 app/Makefile           | 2 +-
 config/common_linuxapp | 1 +
 2 files changed, 2 insertions(+), 1 deletion(-)

Comments

Thomas Monjalon Jan. 12, 2018, 6:02 p.m. UTC | #1 
12/01/2018 18:49, Anatoly Burakov:
> Unlike every other DPDK application's compilation, proc_info's
> compilation cannot be turned off on Linux. Fix it by adding a
> config option to base linuxapp config.
> 
> Fixes: 22561383ea17 ("app: replace dump_cfg by proc_info")
> Cc: maryam.tahhan@intel.com
> Cc: stable@dpdk.org
> Signed-off-by: Anatoly Burakov <anatoly.burakov@intel.com>
> ---
>  app/Makefile           | 2 +-
>  config/common_linuxapp | 1 +

You should also add the option in common_base (as disabled),
so we keep the list of almost every options in one place.
Anatoly Burakov Jan. 12, 2018, 6:05 p.m. UTC | #2 
On 12-Jan-18 6:02 PM, Thomas Monjalon wrote:
> 12/01/2018 18:49, Anatoly Burakov:
>> Unlike every other DPDK application's compilation, proc_info's
>> compilation cannot be turned off on Linux. Fix it by adding a
>> config option to base linuxapp config.
>>
>> Fixes: 22561383ea17 ("app: replace dump_cfg by proc_info")
>> Cc: maryam.tahhan@intel.com
>> Cc: stable@dpdk.org
>> Signed-off-by: Anatoly Burakov <anatoly.burakov@intel.com>
>> ---
>>   app/Makefile           | 2 +-
>>   config/common_linuxapp | 1 +
> 
> You should also add the option in common_base (as disabled),
> so we keep the list of almost every options in one place.
> 

Right, will fix.
diff mbox

Patch

diff --git a/app/Makefile b/app/Makefile
index 24c9067..aa44827 100644
--- a/app/Makefile
+++ b/app/Makefile
@@ -4,7 +4,7 @@ 
 include $(RTE_SDK)/mk/rte.vars.mk
 
 DIRS-$(CONFIG_RTE_TEST_PMD) += test-pmd
-DIRS-$(CONFIG_RTE_EXEC_ENV_LINUXAPP) += proc_info
+DIRS-$(CONFIG_RTE_PROC_INFO) += proc_info
 DIRS-$(CONFIG_RTE_LIBRTE_PDUMP) += pdump
 
 ifeq ($(CONFIG_RTE_LIBRTE_CRYPTODEV),y)
diff --git a/config/common_linuxapp b/config/common_linuxapp
index 74c7d64..15c6961 100644
--- a/config/common_linuxapp
+++ b/config/common_linuxapp
@@ -50,3 +50,4 @@  CONFIG_RTE_LIBRTE_AVP_PMD=y
 CONFIG_RTE_LIBRTE_NFP_PMD=y
 CONFIG_RTE_LIBRTE_POWER=y
 CONFIG_RTE_VIRTIO_USER=y
+CONFIG_RTE_PROC_INFO=y