diff mbox

[dpdk-dev,v2] net/i40e: fix issue of pctype doesn't take effect in X722

Message ID 1516010755-136835-1-git-send-email-rosen.xu@intel.com (mailing list archive)
State Accepted, archived
Delegated to: Helin Zhang
Headers

Checks

Context Check Description
ci/checkpatch success coding style OK
ci/Intel-compilation fail Compilation issues

Commit Message

Xu, Rosen Jan. 15, 2018, 10:05 a.m. UTC 
  Pctype should be setted after Port's MAC type setted, but in current code
pctype is setted before Port's MAC type setted. Move pctype initialization
after shared code initialization which initialize Port's MARC type.

Fixes: a286ebeb0714 ("net/i40e: add dynamic mapping of SW flow types to HW pctypes")
Cc: stable@dpdk.org

Signed-off-by: Rosen Xu <rosen.xu@intel.com>
---
 drivers/net/i40e/i40e_ethdev.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

Comments

Xing, Beilei Jan. 15, 2018, 10:18 a.m. UTC | #1 
> -----Original Message-----
> From: Xu, Rosen
> Sent: Monday, January 15, 2018 6:06 PM
> To: Xing, Beilei <beilei.xing@intel.com>; Zhang, Qi Z <qi.z.zhang@intel.com>
> Cc: dev@dpdk.org; stable@dpdk.org
> Subject: [PATCH v2] net/i40e: fix issue of pctype doesn't take effect in X722
> 
> Pctype should be setted after Port's MAC type setted, but in current code
> pctype is setted before Port's MAC type setted. Move pctype initialization
> after shared code initialization which initialize Port's MARC type.
> 
> Fixes: a286ebeb0714 ("net/i40e: add dynamic mapping of SW flow types to
> HW pctypes")
> Cc: stable@dpdk.org
> 
> Signed-off-by: Rosen Xu <rosen.xu@intel.com> 
Acked-by: Beilei Xing <beilei.xing@intel.com>
Zhang, Helin Jan. 15, 2018, 4:14 p.m. UTC | #2 
> -----Original Message-----
> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Xing, Beilei
> Sent: Monday, January 15, 2018 6:18 PM
> To: Xu, Rosen; Zhang, Qi Z
> Cc: dev@dpdk.org; stable@dpdk.org
> Subject: Re: [dpdk-dev] [PATCH v2] net/i40e: fix issue of pctype doesn't take
> effect in X722
> 
> 
> 
> > -----Original Message-----
> > From: Xu, Rosen
> > Sent: Monday, January 15, 2018 6:06 PM
> > To: Xing, Beilei <beilei.xing@intel.com>; Zhang, Qi Z
> > <qi.z.zhang@intel.com>
> > Cc: dev@dpdk.org; stable@dpdk.org
> > Subject: [PATCH v2] net/i40e: fix issue of pctype doesn't take effect
> > in X722
> >
> > Pctype should be setted after Port's MAC type setted, but in current
> > code pctype is setted before Port's MAC type setted. Move pctype
> > initialization after shared code initialization which initialize Port's MARC type.
> >
> > Fixes: a286ebeb0714 ("net/i40e: add dynamic mapping of SW flow types
> > to HW pctypes")
> > Cc: stable@dpdk.org
> >
> > Signed-off-by: Rosen Xu <rosen.xu@intel.com>
> Acked-by: Beilei Xing <beilei.xing@intel.com>
Applied to dpdk-next-net-intel, with minor commit log changes. Thanks!

/Helin
diff mbox

Patch

diff --git a/drivers/net/i40e/i40e_ethdev.c b/drivers/net/i40e/i40e_ethdev.c
index 7796e9e..9882701 100644
--- a/drivers/net/i40e/i40e_ethdev.c
+++ b/drivers/net/i40e/i40e_ethdev.c
@@ -1057,7 +1057,6 @@  static inline void i40e_GLQF_reg_init(struct i40e_hw *hw)
 		return 0;
 	}
 	i40e_set_default_ptype_table(dev);
-	i40e_set_default_pctype_table(dev);
 	pci_dev = RTE_ETH_DEV_TO_PCI(dev);
 	intr_handle = &pci_dev->intr_handle;
 
@@ -1103,6 +1102,8 @@  static inline void i40e_GLQF_reg_init(struct i40e_hw *hw)
 		return ret;
 	}
 
+	i40e_set_default_pctype_table(dev);
+
 	/*
 	 * To work around the NVM issue, initialize registers
 	 * for packet type of QinQ by software.